Commit 88dbe7e5 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

IndexedDB: clang-tidy fixes to tests.

Change-Id: I9fc513f40e02ff304bad940bf413543dc594dfce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311267
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790910}
parent fdd97404
......@@ -693,8 +693,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks {
: IndexedDBCallbacks(nullptr,
url::Origin(),
mojo::NullAssociatedRemote(),
base::SequencedTaskRunnerHandle::Get()),
error_called_(false) {}
base::SequencedTaskRunnerHandle::Get()) {}
void OnError(const IndexedDBDatabaseError& error) override {
error_called_ = true;
EXPECT_EQ(blink::mojom::IDBException::kQuotaError, error.code());
......@@ -703,7 +702,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks {
private:
~LookingForQuotaErrorMockCallbacks() override = default;
bool error_called_;
bool error_called_ = false;
DISALLOW_COPY_AND_ASSIGN(LookingForQuotaErrorMockCallbacks);
};
......@@ -757,7 +756,7 @@ TEST_F(IndexedDBFactoryTest, NotifyQuotaOnDatabaseError) {
class ErrorCallbacks : public MockIndexedDBCallbacks {
public:
ErrorCallbacks() : MockIndexedDBCallbacks(false), saw_error_(false) {}
ErrorCallbacks() : MockIndexedDBCallbacks(false) {}
void OnError(const IndexedDBDatabaseError& error) override {
saw_error_ = true;
......@@ -766,7 +765,7 @@ class ErrorCallbacks : public MockIndexedDBCallbacks {
private:
~ErrorCallbacks() override = default;
bool saw_error_;
bool saw_error_ = false;
DISALLOW_COPY_AND_ASSIGN(ErrorCallbacks);
};
......
......@@ -49,7 +49,7 @@ void CreateAndBindTransactionPlaceholder(
class LevelDBLock {
public:
LevelDBLock() : env_(nullptr), lock_(nullptr) {}
LevelDBLock() = default;
LevelDBLock(leveldb::Env* env, leveldb::FileLock* lock)
: env_(env), lock_(lock) {}
~LevelDBLock() {
......@@ -58,8 +58,8 @@ class LevelDBLock {
}
private:
leveldb::Env* env_;
leveldb::FileLock* lock_;
leveldb::Env* env_ = nullptr;
leveldb::FileLock* lock_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(LevelDBLock);
};
......@@ -228,7 +228,7 @@ class ForceCloseDBCallbacks : public IndexedDBCallbacks {
IndexedDBConnection* connection() { return connection_.get(); }
protected:
~ForceCloseDBCallbacks() override {}
~ForceCloseDBCallbacks() override = default;
private:
scoped_refptr<IndexedDBContextImpl> idb_context_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment