Commit 88dbe7e5 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

IndexedDB: clang-tidy fixes to tests.

Change-Id: I9fc513f40e02ff304bad940bf413543dc594dfce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311267
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790910}
parent fdd97404
...@@ -693,8 +693,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks { ...@@ -693,8 +693,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks {
: IndexedDBCallbacks(nullptr, : IndexedDBCallbacks(nullptr,
url::Origin(), url::Origin(),
mojo::NullAssociatedRemote(), mojo::NullAssociatedRemote(),
base::SequencedTaskRunnerHandle::Get()), base::SequencedTaskRunnerHandle::Get()) {}
error_called_(false) {}
void OnError(const IndexedDBDatabaseError& error) override { void OnError(const IndexedDBDatabaseError& error) override {
error_called_ = true; error_called_ = true;
EXPECT_EQ(blink::mojom::IDBException::kQuotaError, error.code()); EXPECT_EQ(blink::mojom::IDBException::kQuotaError, error.code());
...@@ -703,7 +702,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks { ...@@ -703,7 +702,7 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks {
private: private:
~LookingForQuotaErrorMockCallbacks() override = default; ~LookingForQuotaErrorMockCallbacks() override = default;
bool error_called_; bool error_called_ = false;
DISALLOW_COPY_AND_ASSIGN(LookingForQuotaErrorMockCallbacks); DISALLOW_COPY_AND_ASSIGN(LookingForQuotaErrorMockCallbacks);
}; };
...@@ -757,7 +756,7 @@ TEST_F(IndexedDBFactoryTest, NotifyQuotaOnDatabaseError) { ...@@ -757,7 +756,7 @@ TEST_F(IndexedDBFactoryTest, NotifyQuotaOnDatabaseError) {
class ErrorCallbacks : public MockIndexedDBCallbacks { class ErrorCallbacks : public MockIndexedDBCallbacks {
public: public:
ErrorCallbacks() : MockIndexedDBCallbacks(false), saw_error_(false) {} ErrorCallbacks() : MockIndexedDBCallbacks(false) {}
void OnError(const IndexedDBDatabaseError& error) override { void OnError(const IndexedDBDatabaseError& error) override {
saw_error_ = true; saw_error_ = true;
...@@ -766,7 +765,7 @@ class ErrorCallbacks : public MockIndexedDBCallbacks { ...@@ -766,7 +765,7 @@ class ErrorCallbacks : public MockIndexedDBCallbacks {
private: private:
~ErrorCallbacks() override = default; ~ErrorCallbacks() override = default;
bool saw_error_; bool saw_error_ = false;
DISALLOW_COPY_AND_ASSIGN(ErrorCallbacks); DISALLOW_COPY_AND_ASSIGN(ErrorCallbacks);
}; };
......
...@@ -49,7 +49,7 @@ void CreateAndBindTransactionPlaceholder( ...@@ -49,7 +49,7 @@ void CreateAndBindTransactionPlaceholder(
class LevelDBLock { class LevelDBLock {
public: public:
LevelDBLock() : env_(nullptr), lock_(nullptr) {} LevelDBLock() = default;
LevelDBLock(leveldb::Env* env, leveldb::FileLock* lock) LevelDBLock(leveldb::Env* env, leveldb::FileLock* lock)
: env_(env), lock_(lock) {} : env_(env), lock_(lock) {}
~LevelDBLock() { ~LevelDBLock() {
...@@ -58,8 +58,8 @@ class LevelDBLock { ...@@ -58,8 +58,8 @@ class LevelDBLock {
} }
private: private:
leveldb::Env* env_; leveldb::Env* env_ = nullptr;
leveldb::FileLock* lock_; leveldb::FileLock* lock_ = nullptr;
DISALLOW_COPY_AND_ASSIGN(LevelDBLock); DISALLOW_COPY_AND_ASSIGN(LevelDBLock);
}; };
...@@ -228,7 +228,7 @@ class ForceCloseDBCallbacks : public IndexedDBCallbacks { ...@@ -228,7 +228,7 @@ class ForceCloseDBCallbacks : public IndexedDBCallbacks {
IndexedDBConnection* connection() { return connection_.get(); } IndexedDBConnection* connection() { return connection_.get(); }
protected: protected:
~ForceCloseDBCallbacks() override {} ~ForceCloseDBCallbacks() override = default;
private: private:
scoped_refptr<IndexedDBContextImpl> idb_context_; scoped_refptr<IndexedDBContextImpl> idb_context_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment