Commit 8958811b authored by Alice Wang's avatar Alice Wang Committed by Chromium LUCI CQ

[Signin][Android] Change account picker methods to package private

This CL changes several account picker methods to package private as
we already finished modularization of account picker.

Bug: 1155123
Change-Id: I33252c72ac37eaa121e35aea59578390018571ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631499Reviewed-by: default avatarTanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844741}
parent a8d5415e
...@@ -22,9 +22,8 @@ import org.chromium.ui.modelutil.PropertyModelChangeProcessor.ViewBinder; ...@@ -22,9 +22,8 @@ import org.chromium.ui.modelutil.PropertyModelChangeProcessor.ViewBinder;
/** /**
* This class regroups the buildView and bindView util methods of the * This class regroups the buildView and bindView util methods of the
* existing account row. * existing account row.
* TODO(https://crbug.com/1155123): Change this class to package internal after modularization
*/ */
public class ExistingAccountRowViewBinder implements ViewBinder<PropertyModel, View, PropertyKey> { class ExistingAccountRowViewBinder implements ViewBinder<PropertyModel, View, PropertyKey> {
/** /**
* View binder that associates an existing account view with the model of * View binder that associates an existing account view with the model of
* {@link ExistingAccountRowProperties}. * {@link ExistingAccountRowProperties}.
...@@ -60,9 +59,8 @@ public class ExistingAccountRowViewBinder implements ViewBinder<PropertyModel, V ...@@ -60,9 +59,8 @@ public class ExistingAccountRowViewBinder implements ViewBinder<PropertyModel, V
* *
* @param profileData profile data needs to bind. * @param profileData profile data needs to bind.
* @param view A view object inflated from @layout/account_picker_row. * @param view A view object inflated from @layout/account_picker_row.
* TODO(https://crbug.com/1155123): Change this method to package internal after modularization
*/ */
public static void bindAccountView(DisplayableProfileData profileData, View view) { static void bindAccountView(DisplayableProfileData profileData, View view) {
ImageView accountImage = view.findViewById(R.id.account_image); ImageView accountImage = view.findViewById(R.id.account_image);
accountImage.setImageDrawable(profileData.getImage()); accountImage.setImageDrawable(profileData.getImage());
......
...@@ -14,16 +14,14 @@ import org.chromium.ui.modelutil.PropertyModelChangeProcessor.ViewBinder; ...@@ -14,16 +14,14 @@ import org.chromium.ui.modelutil.PropertyModelChangeProcessor.ViewBinder;
/** /**
* This class binds an {@link OnClickListener} to a {@link View}. * This class binds an {@link OnClickListener} to a {@link View}.
* TODO(crbug/1155123): Change this class to package internal after modularization
*/ */
public class OnClickListenerViewBinder implements ViewBinder<PropertyModel, View, PropertyKey> { class OnClickListenerViewBinder implements ViewBinder<PropertyModel, View, PropertyKey> {
private final ReadableObjectPropertyKey<OnClickListener> mOnClickListenerKey; private final ReadableObjectPropertyKey<OnClickListener> mOnClickListenerKey;
/** /**
* TODO(crbug/1155123): Change this method to package internal after modularization * Constructs a view binder for a key of {@link OnClickListener}.
*/ */
public OnClickListenerViewBinder( OnClickListenerViewBinder(ReadableObjectPropertyKey<OnClickListener> onClickListenerKey) {
ReadableObjectPropertyKey<OnClickListener> onClickListenerKey) {
mOnClickListenerKey = onClickListenerKey; mOnClickListenerKey = onClickListenerKey;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment