Simplify ServiceWorkerVersion::FinishStartWorker()

The method previously used a template function but the template
function was used only from the method. Merge them so that stack
traces are easy to analyze for crashes which contain the method.

Note that this CL doesn't address the crash.

Bug: 1161800
Change-Id: I59898a39b880b6c31e84f96878f898c57f9eefdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626992Reviewed-by: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843437}

content/browser/service_worker/service_worker_version.cc

@@ -93,16 +93,6 @@ void RunSoon(base::OnceClosure callback) {
   }
 }
 
-template <typename CallbackArray, typename Arg>
-void RunCallbacks(ServiceWorkerVersion* version,
-                  CallbackArray* callbacks_ptr,
-                  const Arg& arg) {
-  CallbackArray callbacks;
-  callbacks.swap(*callbacks_ptr);
-  for (auto& callback : callbacks)
-    std::move(callback).Run(arg);
-}
-
 // An adapter to run a |callback| after StartWorker.
 void RunCallbackAfterStartWorker(base::WeakPtr<ServiceWorkerVersion> version,
                                  ServiceWorkerVersion::StatusCallback callback,
@@ -2285,7 +2275,10 @@ void ServiceWorkerVersion::OnStoppedInternal(EmbeddedWorkerStatus old_status) {
 
 void ServiceWorkerVersion::FinishStartWorker(
     blink::ServiceWorkerStatusCode status) {
-  RunCallbacks(this, &start_callbacks_, status);
+  std::vector<StatusCallback> callbacks;
+  callbacks.swap(start_callbacks_);
+  for (auto& callback : callbacks)
+    std::move(callback).Run(status);
 }
 
 void ServiceWorkerVersion::CleanUpExternalRequest(