Commit 8bded5ec authored by mrefaat's avatar mrefaat Committed by Commit Bot

Disable TabGridMediator failing tests

These tests started failing once they were landed.
created crbug/819658 to track progress and re-enable them.
link for logs:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/10443/steps/ios_chrome_unittests%20%28iPhone%206s%20iOS%2010.3.3%29%20on%20iOS-10.3.3


Bug: 819658

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I470732c12bffc2e8e105c159c8616d679771381c
Reviewed-on: https://chromium-review.googlesource.com/951649Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541598}
parent a58fea8d
...@@ -62,7 +62,13 @@ class TabGridMediatorTest : public PlatformTest { ...@@ -62,7 +62,13 @@ class TabGridMediatorTest : public PlatformTest {
// Tests that the consumer is populated after the tab model is set on the // Tests that the consumer is populated after the tab model is set on the
// mediator. // mediator.
TEST_F(TabGridMediatorTest, ConsumerPopulateItems) { // TODO(crbug.com/819658): Test fails on device. Re-enable after fixing.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_ConsumerPopulateItems ConsumerPopulateItems
#else
#define MAYBE_ConsumerPopulateItems DISABLED_ConsumerPopulateItems
#endif
TEST_F(TabGridMediatorTest, MAYBE_ConsumerPopulateItems) {
[[consumer_ verify] populateItems:[OCMArg checkWithBlock:^BOOL(id value) { [[consumer_ verify] populateItems:[OCMArg checkWithBlock:^BOOL(id value) {
NSArray* items = NSArray* items =
base::mac::ObjCCastStrict<NSArray>(value); base::mac::ObjCCastStrict<NSArray>(value);
...@@ -73,7 +79,13 @@ TEST_F(TabGridMediatorTest, ConsumerPopulateItems) { ...@@ -73,7 +79,13 @@ TEST_F(TabGridMediatorTest, ConsumerPopulateItems) {
} }
// Tests that the consumer is notified when a web state is inserted. // Tests that the consumer is notified when a web state is inserted.
TEST_F(TabGridMediatorTest, ConsumerInsertItem) { // TODO(crbug.com/819658): Test fails on device. Re-enable after fixing.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_ConsumerInsertItem ConsumerInsertItem
#else
#define MAYBE_ConsumerInsertItem DISABLED_ConsumerInsertItem
#endif
TEST_F(TabGridMediatorTest, MAYBE_ConsumerInsertItem) {
auto web_state = std::make_unique<web::TestWebState>(); auto web_state = std::make_unique<web::TestWebState>();
TabIdTabHelper::CreateForWebState(web_state.get()); TabIdTabHelper::CreateForWebState(web_state.get());
NSString* item_identifier = NSString* item_identifier =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment