Reland "[CCA WebUI] Don't capture navigation other than main page URL for CCA"
This reverts commit 79e008a0. Reason for revert: The CL is reverted but the failure (SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps) does not fix: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9028 So it is very likely that the CL is not the culprit. Original change's description: > Revert "[CCA WebUI] Don't capture navigation other than main page URL for CCA" > > This reverts commit ab12c6e3. > > Reason for revert: Breaks browser_tests: SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9011 > > Original change's description: > > [CCA WebUI] Don't capture navigation other than main page URL for CCA > > > > We have the following requirements: > > 1. We prefer loading CCA UI in the app window rather than browser tab > > => Therefore we added "capture_navigation=true" for CCA > > 2. We don't want to load resource URLs or invalid URL in the app window > > => Short term: Landing this CL to filter out unwanted URLs > > > > We decide not to support URL filtering feature for capture navigation > > since only camera app has such requirement at this moment. > > (crbug.com/1132151) > > > > Bug: 980846 > > Test: Type CCA url other than chrome://camera-app/views/main.html and > > the page is loaded in browser tab > > > > Change-Id: I467aa1498aa9fe975d34bdf82adee7f6dff6a14c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440076 > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Jiewei Qian <qjw@chromium.org> > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814557} > > TBR=ortuno@chromium.org,wtlee@chromium.org,qjw@chromium.org > > Change-Id: I12e4bbd7ee461e7ed0a3d0664e90ca3e4ea435f9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 980846 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457586 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814741} TBR=ortuno@chromium.org,eirage@chromium.org,wtlee@chromium.org,qjw@chromium.org # Not skipping CQ checks because this is a reland. Bug: 980846 Change-Id: Ia0244f12f8d12c03184b73c27e374072b8c76b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460250Reviewed-by:Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815033}
Showing
Please register or sign in to comment