Commit 92ead649 authored by Thomas Guilbert's avatar Thomas Guilbert Committed by Commit Bot

[Style] Cleanup BlinkPlatformImpl overrides.

Chromium style guide recommends grouping overrides for a given interface
together, with no new line in between methods.

This CL applies the rule to blink::Platform implementers.

Change-Id: I27fc748361d63a1bb18b8a705b46572aadeae80c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492667
Commit-Queue: Charlie Reis <creis@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820122}
parent 9a91f85e
......@@ -32,16 +32,13 @@ class CONTENT_EXPORT BlinkPlatformImpl : public blink::Platform {
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner);
~BlinkPlatformImpl() override;
// Platform methods (partial implementation):
// blink::Platform implementation.
blink::WebThemeEngine* ThemeEngine() override;
bool IsURLSupportedForAppCache(const blink::WebURL& url) override;
bool IsURLSavableForSavableResource(const blink::WebURL& url) override;
size_t MaxDecodedImageBytes() override;
bool IsLowEndDevice() override;
void RecordAction(const blink::UserMetricsAction&) override;
blink::WebData GetDataResource(int resource_id,
ui::ScaleFactor scale_factor) override;
blink::WebData UncompressDataResource(int resource_id) override;
......@@ -56,7 +53,6 @@ class CONTENT_EXPORT BlinkPlatformImpl : public blink::Platform {
blink::WebCrypto* Crypto() override;
blink::ThreadSafeBrowserInterfaceBrokerProxy* GetBrowserInterfaceBroker()
override;
scoped_refptr<base::SingleThreadTaskRunner> GetIOTaskRunner() const override;
std::unique_ptr<NestedMessageLoopRunner> CreateNestedMessageLoopRunner()
const override;
......
......@@ -69,7 +69,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
// Shutdown must be called just prior to shutting down blink.
void Shutdown();
// Platform methods:
// blink::Platform implementation.
blink::WebSandboxSupport* GetSandboxSupport() override;
blink::WebThemeEngine* ThemeEngine() override;
virtual bool sandboxEnabled();
......@@ -105,10 +105,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
const blink::WebSecurityOrigin& origin) override;
viz::FrameSinkId GenerateFrameSinkId() override;
bool IsLockedToSite() const override;
blink::WebString FileSystemCreateOriginIdentifier(
const blink::WebSecurityOrigin& origin) override;
bool IsThreadedAnimationEnabled() override;
bool IsGpuCompositingDisabled() override;
#if defined(OS_ANDROID)
......@@ -124,18 +122,15 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
size_t AudioHardwareBufferSize() override;
unsigned AudioHardwareOutputChannels() override;
base::TimeDelta GetHungRendererDelay() override;
std::unique_ptr<blink::WebAudioDevice> CreateAudioDevice(
unsigned input_channels,
unsigned channels,
const blink::WebAudioLatencyHint& latency_hint,
blink::WebAudioDevice::RenderCallback* callback,
const blink::WebString& input_device_id) override;
bool DecodeAudioFileData(blink::WebAudioBus* destination_bus,
const char* audio_file_data,
size_t data_size) override;
scoped_refptr<media::AudioCapturerSource> NewAudioCapturerSource(
blink::WebLocalFrame* web_frame,
const media::AudioSourceParameters& params) override;
......@@ -173,9 +168,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
bool IsWebRtcSrtpAesGcmEnabled() override;
bool IsWebRtcSrtpEncryptedHeadersEnabled() override;
bool AllowsLoopbackInPeerConnection() override;
blink::WebVideoCaptureImplManager* GetVideoCaptureImplManager() override;
std::unique_ptr<blink::WebGraphicsContext3DProvider>
CreateOffscreenGraphicsContext3DProvider(
const blink::Platform::ContextAttributes& attributes,
......@@ -190,7 +183,6 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
blink::WebString ConvertIDNToUnicode(const blink::WebString& host) override;
void SetDisplayThreadPriority(base::PlatformThreadId thread_id) override;
blink::BlameContext* GetTopLevelBlameContext() override;
std::unique_ptr<blink::WebDedicatedWorkerHostFactoryClient>
CreateDedicatedWorkerHostFactoryClient(
blink::WebDedicatedWorker*,
......@@ -202,11 +194,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
const blink::WebSecurityOrigin& script_origin) override;
bool IsExcludedHeaderForServiceWorkerFetchEvent(
const blink::WebString& header_name) override;
void RecordMetricsForBackgroundedRendererPurge() override;
std::unique_ptr<blink::WebCodeCacheLoader> CreateCodeCacheLoader() override;
std::unique_ptr<blink::WebURLLoaderFactory> WrapURLLoaderFactory(
blink::CrossVariantMojoRemote<
network::mojom::URLLoaderFactoryInterfaceBase> url_loader_factory)
......@@ -216,7 +205,6 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
std::unique_ptr<media::MediaLog> GetMediaLog(
blink::MediaInspectorContext* inspector_context,
scoped_refptr<base::SingleThreadTaskRunner> owner_task_runner) override;
media::GpuVideoAcceleratorFactories* GetGpuFactories() override;
void SetRenderingColorSpace(const gfx::ColorSpace& color_space) override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment