Commit 969fb156 authored by Sky Malice's avatar Sky Malice Committed by Commit Bot

Reland "🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" "

This reverts commit d8ad718b.

Reason for revert: Goldens break every day as they contain information relative to current time. Needs updating before they will consistently work.

Original change's description:
> Revert "🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" "
>
> This reverts commit 1d9e3ca2.
>
> Reason for revert: Updated golden images, test should now pass
>
> Original change's description:
> > 🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" 
> >
> > This reverts commit 46de280d.
> >
> > Reason for revert: still flaky.
> > See https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/707
> >
> > Original change's description:
> > > enable FeedNewTabPageCardInstrumentationTest
> > >
> > > Bug: 1143781
> > > Change-Id: Ic7c1adad83cb472aeaeb8e82534288184a89d544
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518183
> > > Reviewed-by: Dan H <harringtond@chromium.org>
> > > Commit-Queue: Arthur Wang <wuwang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#824229}
> >
> > TBR=harringtond@chromium.org,wuwang@chromium.org
> >
> > Change-Id: I9ccace6afc3b4193000d094392c78468887a6249
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1143781
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519975
> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#824385}
>
> TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org
>
> Change-Id: I632bfabe8eacccec82dbd00d231569398f809b2c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1143781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520812
> Reviewed-by: Dan H <harringtond@chromium.org>
> Commit-Queue: Dan H <harringtond@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#824433}

TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1143781
Change-Id: Ia9f3b45b0f1924e809e95a0f7112b14237350623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526943Reviewed-by: default avatarSky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825372}
parent ea6ebba4
......@@ -15,6 +15,7 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
......@@ -56,6 +57,7 @@ public final class FeedNewTabPageCardInstrumentationTest {
@Feature({"FeedNewTabPage", "WPRRecordReplayTest", "RenderTest"})
@WPRArchiveDirectory("chrome/android/feed/core/javatests/src/org/chromium/chrome/"
+ "browser/feed/wpr_tests")
@DisabledTest(message = "https://crbug.com/1143781")
public void
launchNTP_withMultipleFeedCardsRendered() throws IOException, InterruptedException {
mActivityTestRule.loadUrlInNewTab(UrlConstants.NTP_URL);
......
ab80612a3f194f9402f97f25dc516305ab910715
\ No newline at end of file
0846bac870a018d9ed4820943700b2c978c5ccca
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment