Commit 984d91ec authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Add accessibility announcements when PageInfo subpages are opened

Bug: 1077766
Change-Id: I1b30c374cdc95632f42080cad20d121127abad42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517439Reviewed-by: default avatarEhimare Okoyomon <eokoyomon@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823936}
parent 4ad0209b
...@@ -3197,9 +3197,6 @@ Data from your Incognito session will only be cleared from Chrome when you <ph n ...@@ -3197,9 +3197,6 @@ Data from your Incognito session will only be cleared from Chrome when you <ph n
<message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_MENU_OS_VERSION_UNSUPPORTED" desc="Content description for the menu button when it is covered by the warning icon that is displayed when the current Android OS version is unsupported."> <message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_MENU_OS_VERSION_UNSUPPORTED" desc="Content description for the menu button when it is covered by the warning icon that is displayed when the current Android OS version is unsupported.">
Chrome can’t update. More options Chrome can’t update. More options
</message> </message>
<message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_SITE_INFO" desc="Content description for the page icon that gives more site information when clicked. The icon can be a magnifier for search result pages, or other icons representing the page state.">
Site information
</message>
<message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_MIC" desc="Content description for the voice search button."> <message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_MIC" desc="Content description for the voice search button.">
Start voice search Start voice search
</message> </message>
......
...@@ -563,6 +563,9 @@ ...@@ -563,6 +563,9 @@
<message name="IDS_COOKIES_TITLE" desc="Title for the Cookies settings screen [CHAR-LIMIT=32]"> <message name="IDS_COOKIES_TITLE" desc="Title for the Cookies settings screen [CHAR-LIMIT=32]">
Cookies Cookies
</message> </message>
<message name="IDS_ACCESSIBILITY_TOOLBAR_BTN_SITE_INFO" desc="Content description for the page icon that gives more site information when clicked. The icon can be a magnifier for search result pages, or other icons representing the page state.">
Site information
</message>
<!-- Media Capture and Streams --> <!-- Media Capture and Streams -->
<message name="IDS_MEDIA_CAPTURE_NOTIFICATION_APP_NAME_SEPARATOR" desc="A separator between the app name and notification message."> <message name="IDS_MEDIA_CAPTURE_NOTIFICATION_APP_NAME_SEPARATOR" desc="A separator between the app name and notification message.">
......
...@@ -91,6 +91,7 @@ ...@@ -91,6 +91,7 @@
android:layout_marginStart="-12dp" android:layout_marginStart="-12dp"
android:layout_marginEnd="20dp" android:layout_marginEnd="20dp"
android:background="?attr/selectableItemBackgroundBorderless" android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/back"
android:minWidth="@dimen/min_touch_target_size" android:minWidth="@dimen/min_touch_target_size"
android:minHeight="@dimen/min_touch_target_size" android:minHeight="@dimen/min_touch_target_size"
android:src="@drawable/ic_arrow_back_white_24dp" android:src="@drawable/ic_arrow_back_white_24dp"
......
...@@ -144,5 +144,8 @@ public class PageInfoContainer extends FrameLayout { ...@@ -144,5 +144,8 @@ public class PageInfoContainer extends FrameLayout {
mSubpageHeader.setVisibility(subPageTitle != null ? VISIBLE : GONE); mSubpageHeader.setVisibility(subPageTitle != null ? VISIBLE : GONE);
mSubpageTitle.setText(subPageTitle); mSubpageTitle.setText(subPageTitle);
mContent.addView(view); mContent.addView(view);
announceForAccessibility(subPageTitle != null
? subPageTitle
: getResources().getString(R.string.accessibility_toolbar_btn_site_info));
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment