Commit 9a985270 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

logging.h related include-what-you-use (ash/)

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: If22a9fad1fb5c1fa306e539ff8aa27c020f3ec5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156415
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760535}
parent 550a724f
......@@ -5,6 +5,8 @@
#ifndef ASH_HUD_DISPLAY_GRAPH_H_
#define ASH_HUD_DISPLAY_GRAPH_H_
#include <vector>
#include "base/containers/ring_buffer.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/geometry/point.h"
......
......@@ -7,6 +7,7 @@
#include <unistd.h>
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/process/internal_linux.h"
#include "base/process/process_iterator.h"
#include "base/process/process_metrics.h"
......
......@@ -6,6 +6,7 @@
#define ASH_KEYBOARD_UI_TEST_TEST_KEYBOARD_CONTROLLER_OBSERVER_H_
#include "ash/public/cpp/keyboard/keyboard_controller_observer.h"
#include "base/macros.h"
namespace keyboard {
......
......@@ -7,6 +7,7 @@
#include <memory>
#include "ash/metrics/task_switch_time_tracker.h"
#include "base/logging.h"
namespace ash {
......
......@@ -8,6 +8,7 @@
#include <vector>
#include "ash/public/cpp/ash_public_export.h"
#include "base/macros.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/geometry/rect.h"
......
......@@ -6,6 +6,7 @@
#define ASH_PUBLIC_CPP_FPS_COUNTER_H_
#include "ash/public/cpp/ash_public_export.h"
#include "base/macros.h"
#include "base/time/time.h"
#include "ui/compositor/compositor_observer.h"
......
......@@ -11,6 +11,7 @@
#include "ash/public/cpp/ash_public_export.h"
#include "ash/public/cpp/keyboard/keyboard_config.h"
#include "ash/public/cpp/keyboard/keyboard_types.h"
#include "base/callback_forward.h"
#include "base/optional.h"
#include "ui/gfx/geometry/rect.h"
......
......@@ -5,6 +5,8 @@
#ifndef ASH_PUBLIC_CPP_SHELF_UI_INFO_H_
#define ASH_PUBLIC_CPP_SHELF_UI_INFO_H_
#include <vector>
#include "ash/public/cpp/ash_public_export.h"
#include "ash/public/cpp/shelf_types.h"
#include "ui/gfx/geometry/point.h"
......
......@@ -10,6 +10,7 @@
#include "ash/public/cpp/keyboard/keyboard_config.h"
#include "ash/public/cpp/keyboard/keyboard_controller.h"
#include "ash/public/cpp/keyboard/keyboard_controller_observer.h"
#include "base/macros.h"
namespace ash {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment