[canvas] Don't copy into byte array of size 0

When StaticBitmapImage::SizeInBytes returned 0, StaticBitmapImage::CopyToByteArray did not result in a no-op as expected. With this CL we add a check to StaticBitmapImage::CopyToByteArray to return early if the incoming byte array has size 0. R=jbroman@chromium.org Bug: chromium:1017918 Change-Id: I79952218a483735815144000185a94f313a8e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883627 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709921}

[canvas] Don't copy into byte array of size 0
When StaticBitmapImage::SizeInBytes returned 0, StaticBitmapImage::CopyToByteArray did not result in a no-op as expected. With this CL we add a check to StaticBitmapImage::CopyToByteArray to return early if the incoming byte array has size 0. R=jbroman@chromium.org Bug: chromium:1017918 Change-Id: I79952218a483735815144000185a94f313a8e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883627 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709921}
9b571645 · Andreas Haas · Commit Bot · fb7068fc · 9b571645 · 9b571645
Commit 9b571645 authored Oct 28, 2019 by Andreas Haas Committed by Commit Bot Oct 28, 2019
2 changed files
--- a/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
+++ b/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
@@ -111,6 +111,9 @@ bool StaticBitmapImage::CopyToByteArray(
  if (!src_image)
    return true;

+  if (dst.size() == 0)
+    return true;
+
  SkColorType color_type =
      (color_params.GetSkColorType() == kRGBA_F16_SkColorType)
          ? kRGBA_F16_SkColorType

--- a/third_party/blink/web_tests/fast/canvas/bug1017918.html
+++ b/third_party/blink/web_tests/fast/canvas/bug1017918.html
+<!DOCTYPE html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+
+<canvas id="canvas1" width=974px></canvas>
+<script>
+test(() => {
+  let C = document.getElementById("canvas1");
+  let Z = C.getContext("2d");
+  Z.getImageData(174.696924716, -3.94829667221, 6.80556775521, 291126556.736);
+}, "Regression test for https://crbug.com/1017918.");
+</script>