Commit 9e3969e7 authored by sandromaggi's avatar sandromaggi Committed by Commit Bot

[Autofill Assistant] Prevent clipping of poodle.

This CL makes the box around the poodle bigger, such that the animation
inside does not clip.

This requires an adaption of AnimatedPoodle.java, see
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2396454/

Before: https://screenshot.googleplex.com/RKTuHnfqAUT
After: https://screenshot.googleplex.com/Nh1CExNGP14

Bug: b/146418409
Change-Id: Ia15cff2f7d680c0a1fcc92d02fe6bb9e1a691c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991427Reviewed-by: default avatarClemens Arbesser <arbesser@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#730107}
parent 183d0666
...@@ -7,24 +7,20 @@ ...@@ -7,24 +7,20 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<!-- Horizontal spacing is 24dp, on end it's 16dp from LinearLayout + 8dp
from ChromeImageView. -->
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:minHeight="56dp" android:minHeight="56dp"
android:orientation="horizontal" android:orientation="horizontal"
android:paddingStart="@dimen/autofill_assistant_header_horizontal_spacing" android:paddingStart="@dimen/autofill_assistant_header_horizontal_spacing"
android:paddingEnd="16dp"> android:paddingEnd="@dimen/autofill_assistant_header_horizontal_spacing">
<!-- Move poodle down the same space as profile icon. -->
<LinearLayout <LinearLayout
android:id="@+id/poodle_wrapper" android:id="@+id/poodle_wrapper"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal" android:orientation="horizontal"/>
android:layout_marginTop="@dimen/autofill_assistant_profile_icon_padding"/> <!-- 16dp on start which are 8dp from the TextView + 8dp from the poodle. -->
<!-- 16dp on start, 24dp on end which are 16dp from the TextView + 8dp from <!-- 24dp on end which are 16dp from the TextView + 8dp from the ChromeImageView. -->
ChromeImageView. -->
<!-- 14dp on top (as margin, to prevent overlap with toolbar) visual alignment. --> <!-- 14dp on top (as margin, to prevent overlap with toolbar) visual alignment. -->
<TextView <TextView
android:id="@+id/status_message" android:id="@+id/status_message"
...@@ -32,7 +28,7 @@ ...@@ -32,7 +28,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_weight="1.0" android:layout_weight="1.0"
android:gravity="center_vertical" android:gravity="center_vertical"
android:paddingStart="16dp" android:paddingStart="8dp"
android:paddingEnd="16dp" android:paddingEnd="16dp"
android:layout_marginTop="14dp" android:layout_marginTop="14dp"
android:layout_marginBottom="@dimen/autofill_assistant_header_text_vertical_spacing" android:layout_marginBottom="@dimen/autofill_assistant_header_text_vertical_spacing"
......
...@@ -9,8 +9,8 @@ ...@@ -9,8 +9,8 @@
<dimen name="autofill_assistant_poodle_size">32dp</dimen> <dimen name="autofill_assistant_poodle_size">32dp</dimen>
<dimen name="autofill_assistant_profile_size">32dp</dimen> <dimen name="autofill_assistant_profile_size">32dp</dimen>
<dimen name="autofill_assistant_info_box_spacing">16dp</dimen> <dimen name="autofill_assistant_info_box_spacing">16dp</dimen>
<dimen name="autofill_assistant_poodle_view_size">32dp</dimen> <dimen name="autofill_assistant_poodle_view_size">48dp</dimen>
<dimen name="autofill_assistant_header_horizontal_spacing">24dp</dimen> <dimen name="autofill_assistant_header_horizontal_spacing">16dp</dimen>
<dimen name="autofill_assistant_header_text_vertical_spacing">8dp</dimen> <dimen name="autofill_assistant_header_text_vertical_spacing">8dp</dimen>
<!-- The padding should match autofill_assistant_minimum_touch_target_size - <!-- The padding should match autofill_assistant_minimum_touch_target_size -
autofill_assistant_profile_size * 2. --> autofill_assistant_profile_size * 2. -->
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment