Commit 9f490849 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Chromium LUCI CQ

[Passwords] Use network::IsOriginPotentiallyTrustworthy in TTF

This change replaces network::IsUrlPotentiallyTrustworthy with
network::IsOriginPotentiallyTrustworthy in the Touch To Fill controller.
The small difference between those two APIs is irrelevant for Touch To
Fill, and the latter matches the semantics of
TouchToFillView::IsOriginSecure better.

Bug: 1012717, 1153336
Change-Id: I06553ac01aeae540426e6df30631e03db0ccfe60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574743
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834163}
parent 7955d904
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#include "services/metrics/public/cpp/ukm_recorder.h" #include "services/metrics/public/cpp/ukm_recorder.h"
#include "services/metrics/public/cpp/ukm_source_id.h" #include "services/metrics/public/cpp/ukm_source_id.h"
#include "services/network/public/cpp/is_potentially_trustworthy.h" #include "services/network/public/cpp/is_potentially_trustworthy.h"
#include "url/origin.h"
using ShowVirtualKeyboard = using ShowVirtualKeyboard =
password_manager::PasswordManagerDriver::ShowVirtualKeyboard; password_manager::PasswordManagerDriver::ShowVirtualKeyboard;
...@@ -58,10 +59,11 @@ void TouchToFillController::Show(base::span<const UiCredential> credentials, ...@@ -58,10 +59,11 @@ void TouchToFillController::Show(base::span<const UiCredential> credentials,
view_ = TouchToFillViewFactory::Create(this); view_ = TouchToFillViewFactory::Create(this);
const GURL& url = driver_->GetLastCommittedURL(); const GURL& url = driver_->GetLastCommittedURL();
view_->Show(url, view_->Show(
TouchToFillView::IsOriginSecure( url,
network::IsUrlPotentiallyTrustworthy(url)), TouchToFillView::IsOriginSecure(
credentials); network::IsOriginPotentiallyTrustworthy(url::Origin::Create(url))),
credentials);
} }
void TouchToFillController::OnCredentialSelected( void TouchToFillController::OnCredentialSelected(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment