[CrOS Settings] Add recordSettingChange() metric in simple cases.

This CL adds recordSettingChange() calls in instances in settings related to browser broxy calls, excluding internet pages and sync pages that are shared with browser settings, which will be addressed in later CLs. Bug: 1049830 Change-Id: I55842b288c7a92c460bc8ea906b5e780a84c4bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053087 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#742712}

[CrOS Settings] Add recordSettingChange() metric in simple cases.
This CL adds recordSettingChange() calls in instances in settings related to browser broxy calls, excluding internet pages and sync pages that are shared with browser settings, which will be addressed in later CLs. Bug: 1049830 Change-Id: I55842b288c7a92c460bc8ea906b5e780a84c4bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053087 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#742712}
a9992e3c · Regan Hsu · Commit Bot · 97aaf21b · a9992e3c · a9992e3c
Commit a9992e3c authored Feb 19, 2020 by Regan Hsu Committed by Commit Bot Feb 19, 2020
62 changed files
--- a/chrome/browser/resources/settings/chromeos/crostini_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/BUILD.gn
@@ -21,6 +21,7 @@ js_type_check("closure_compile") {
 js_library("crostini_arc_adb") {
  deps = [
    ":crostini_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "../localized_link:localized_link",
    "//ui/webui/resources/cr_elements/policy:cr_policy_indicator",
@@ -62,6 +63,7 @@ js_library("crostini_page") {
 js_library("crostini_shared_paths") {
  deps = [
    ":crostini_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "../../prefs:prefs_behavior",
  ]
@@ -70,6 +72,7 @@ js_library("crostini_shared_paths") {
 js_library("crostini_shared_usb_devices") {
  deps = [
    ":crostini_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "//ui/webui/resources/js:web_ui_listener_behavior",
  ]
@@ -86,6 +89,7 @@ js_library("crostini_port_forwarding") {
 js_library("crostini_subpage") {
  deps = [
    ":crostini_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "..:route_origin_behavior",
    "../..:router",

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_arc_adb_confirmation_dialog.html
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_arc_adb_confirmation_dialog.html
@@ -5,6 +5,7 @@
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="crostini_browser_proxy.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-crostini-arc-adb-confirmation-dialog">
  <template>

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_arc_adb_confirmation_dialog.js
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_arc_adb_confirmation_dialog.js
@@ -41,8 +41,10 @@ Polymer({
  onRestartTap_() {
    if (this.isEnabling_()) {
      settings.CrostiniBrowserProxyImpl.getInstance().enableArcAdbSideload();
+      settings.recordSettingChange();
    } else if (this.isDisabling_()) {
      settings.CrostiniBrowserProxyImpl.getInstance().disableArcAdbSideload();
+      settings.recordSettingChange();
    } else {
      assertNotReached();
    }

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_paths.html
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_paths.html
@@ -6,6 +6,7 @@
 <link rel="import" href="../../i18n_setup.html">
 <link rel="import" href="../../prefs/prefs_behavior.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-crostini-shared-paths">
  <template>

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_paths.js
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_paths.js
@@ -85,6 +85,7 @@ Polymer({
            this.$$('#removeSharedPathFailedDialog').showModal();
          }
        });
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_usb_devices.html
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_usb_devices.html
@@ -3,6 +3,7 @@
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_toggle/cr_toggle.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-crostini-shared-usb-devices">
  <template>

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_usb_devices.js
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_shared_usb_devices.js
@@ -47,5 +47,6 @@ Polymer({
    const deviceInfo = event.model.item;
    settings.CrostiniBrowserProxyImpl.getInstance().setCrostiniUsbDeviceShared(
        deviceInfo.guid, event.target.checked);
+    settings.recordSettingChange();
  },
 });
--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_subpage.html
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_subpage.html
@@ -11,6 +11,7 @@
 <link rel="import" href="../route_origin_behavior.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-crostini-subpage">
  <template>
@@ -27,7 +28,7 @@
          </div>
        </div>
        <cr-button on-click="onContainerUpgradeClick_"
-            aria-labelledby="upgradeCrostiniLabel" 
+            aria-labelledby="upgradeCrostiniLabel"
            disabled="[[disableUpgradeButton_]]">
          $i18n{crostiniContainerUpgradeButton}
        </cr-button>

--- a/chrome/browser/resources/settings/chromeos/crostini_page/crostini_subpage.js
+++ b/chrome/browser/resources/settings/chromeos/crostini_page/crostini_subpage.js
@@ -188,6 +188,7 @@ Polymer({
   */
  onRemoveClick_() {
    settings.CrostiniBrowserProxyImpl.getInstance().requestRemoveCrostini();
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/device_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/device_page/BUILD.gn
@@ -61,6 +61,7 @@ js_library("keyboard") {
 js_library("stylus") {
  deps = [
    ":device_page_browser_proxy",
+    "..:metrics_recorder",
    "../../prefs:prefs_types",
    "//ui/webui/resources/cr_elements/policy:cr_policy_indicator",
    "//ui/webui/resources/js:cr",
@@ -127,6 +128,7 @@ js_library("night_light_slider") {
 js_library("power") {
  deps = [
    ":device_page_browser_proxy",
+    "..:metrics_recorder",
    "../..:router",
    "../../prefs:prefs_types",
    "//ui/webui/resources/js:i18n_behavior",

--- a/chrome/browser/resources/settings/chromeos/device_page/power.html
+++ b/chrome/browser/resources/settings/chromeos/device_page/power.html
@@ -8,6 +8,7 @@
 <link rel="import" href="../../controls/settings_toggle_button.html">
 <link rel="import" href="../../router.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-power">
  <template>

--- a/chrome/browser/resources/settings/chromeos/device_page/power.js
+++ b/chrome/browser/resources/settings/chromeos/device_page/power.js
@@ -187,6 +187,7 @@ Polymer({
    const behavior = /** @type {settings.IdleBehavior} */
        (parseInt(this.$.idleSelect.value, 10));
    settings.DevicePageBrowserProxyImpl.getInstance().setIdleBehavior(behavior);
+    settings.recordSettingChange();
  },
  /** @private */
@@ -196,6 +197,7 @@ Polymer({
    settings.DevicePageBrowserProxyImpl.getInstance().setLidClosedBehavior(
        this.$.lidClosedToggle.checked ? settings.LidClosedBehavior.SUSPEND :
                                         settings.LidClosedBehavior.DO_NOTHING);
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/device_page/stylus.html
+++ b/chrome/browser/resources/settings/chromeos/device_page/stylus.html
@@ -7,6 +7,7 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner-lite.html">
 <link rel="import" href="../../controls/settings_toggle_button.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-stylus">
  <template>

--- a/chrome/browser/resources/settings/chromeos/device_page/stylus.js
+++ b/chrome/browser/resources/settings/chromeos/device_page/stylus.js
@@ -152,6 +152,7 @@ Polymer({
    this.browserProxy_.setPreferredNoteTakingAppEnabledOnLockScreen(
        this.selectedApp_.lockScreenSupport ==
        settings.NoteAppLockScreenSupport.SUPPORTED);
+    settings.recordSettingChange();
  },
  /** @private */
@@ -161,6 +162,7 @@ Polymer({
    if (app && !app.preferred) {
      this.browserProxy_.setPreferredNoteTakingApp(app.value);
+      settings.recordSettingChange();
    }
  },

--- a/chrome/browser/resources/settings/chromeos/google_assistant_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/google_assistant_page/BUILD.gn
@@ -19,6 +19,7 @@ js_library("google_assistant_browser_proxy") {
 js_library("google_assistant_page") {
  deps = [
    ":google_assistant_browser_proxy",
+    "..:metrics_recorder",
    "../../prefs:prefs_behavior",
    "//ui/webui/resources/js:cr",
    "//ui/webui/resources/js:i18n_behavior",

--- a/chrome/browser/resources/settings/chromeos/google_assistant_page/google_assistant_page.html
+++ b/chrome/browser/resources/settings/chromeos/google_assistant_page/google_assistant_page.html
@@ -14,6 +14,7 @@
 <link rel="import" href="../../prefs/prefs_behavior.html">
 <link rel="import" href="../../settings_shared_css.html">
 <link rel="import" href="../../prefs/pref_util.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-google-assistant-page">
  <template>

--- a/chrome/browser/resources/settings/chromeos/google_assistant_page/google_assistant_page.js
+++ b/chrome/browser/resources/settings/chromeos/google_assistant_page/google_assistant_page.js
@@ -138,11 +138,13 @@ Polymer({
  /** @private */
  onGoogleAssistantSettingsTapped_() {
    this.browserProxy_.showGoogleAssistantSettings();
+    settings.recordSettingChange();
  },
  /** @private */
  onRetrainVoiceModelTapped_() {
    this.browserProxy_.retrainAssistantVoiceModel();
+    settings.recordSettingChange();
  },
  /** @private */

--- a/chrome/browser/resources/settings/chromeos/multidevice_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/multidevice_page/BUILD.gn
@@ -59,6 +59,7 @@ js_library("multidevice_page") {
    ":multidevice_browser_proxy",
    ":multidevice_constants",
    ":multidevice_feature_behavior",
+    "..:metrics_recorder",
    "..:os_route",
    "../..:router",
    "../../controls:password_prompt_dialog",
@@ -80,6 +81,7 @@ js_library("multidevice_smartlock_subpage") {
  deps = [
    ":multidevice_constants",
    ":multidevice_feature_behavior",
+    "..:metrics_recorder",
    "..:os_route",
    "../..:settings_routes",
    "../../prefs:prefs_behavior",

--- a/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_page.html
+++ b/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_page.html
@@ -15,6 +15,7 @@
 <link rel="import" href="../../settings_page/settings_subpage.html">
 <link rel="import" href="../../settings_shared_css.html">
 <link rel="import" href="../localized_link/localized_link.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="multidevice_browser_proxy.html">
 <link rel="import" href="multidevice_constants.html">
 <link rel="import" href="multidevice_feature_behavior.html">

--- a/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_page.js
+++ b/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_page.js
@@ -265,6 +265,7 @@ Polymer({
      this.browserProxy_.setFeatureEnabledState(
          this.featureToBeEnabledOnceAuthenticated_, true /* enabled */,
          this.authToken_);
+      settings.recordSettingChange();
      // Reset |this.authToken_| now that it has been used. This ensures that
      // users cannot keep an old auth token and reuse it on an subsequent
@@ -300,6 +301,7 @@ Polymer({
    // features does not require authentication.
    if (!enabled || !this.isAuthenticationRequiredToEnable_(feature)) {
      this.browserProxy_.setFeatureEnabledState(feature, enabled);
+      settings.recordSettingChange();
      return;
    }
@@ -344,6 +346,7 @@ Polymer({
  /** @private */
  onForgetDeviceRequested_() {
    this.browserProxy_.removeHostDevice();
+    settings.recordSettingChange();
    settings.Router.getInstance().navigateTo(settings.routes.MULTIDEVICE);
  },

--- a/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_smartlock_subpage.html
+++ b/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_smartlock_subpage.html
@@ -10,6 +10,7 @@
 <link rel="import" href="multidevice_radio_button.html">
 <link rel="import" href="../../i18n_setup.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-multidevice-smartlock-subpage">
  <template>

--- a/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_smartlock_subpage.js
+++ b/chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_smartlock_subpage.js
@@ -148,6 +148,7 @@ Polymer({
    if (!enabled) {
      // No authentication check is required to disable.
      this.browserProxy_.setSmartLockSignInEnabled(false /* enabled */);
+      settings.recordSettingChange();
      return;
    }
@@ -171,6 +172,7 @@ Polymer({
    if (this.authToken_ !== '') {
      this.browserProxy_.setSmartLockSignInEnabled(
          true /* enabled */, this.authToken_);
+      settings.recordSettingChange();
    }
    // Always require password entry if re-enabling SignIn with Smart Lock.

--- a/chrome/browser/resources/settings/chromeos/os_about_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_about_page/BUILD.gn
@@ -14,6 +14,7 @@ js_type_check("closure_compile") {
 js_library("os_about_page") {
  deps = [
+    "..:metrics_recorder",
    "..:os_route",
    "../..:lifetime_browser_proxy",
    "../..:router",

--- a/chrome/browser/resources/settings/chromeos/os_about_page/os_about_page.html
+++ b/chrome/browser/resources/settings/chromeos/os_about_page/os_about_page.html
@@ -14,6 +14,7 @@
 <link rel="import" href="../../settings_page/settings_subpage.html">
 <link rel="import" href="../../settings_page_css.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="../os_icons.html">
 <link rel="import" href="../os_reset_page/os_powerwash_dialog.html">
 <link rel="import" href="../localized_link/localized_link.html">

--- a/chrome/browser/resources/settings/chromeos/os_about_page/os_about_page.js
+++ b/chrome/browser/resources/settings/chromeos/os_about_page/os_about_page.js
@@ -271,6 +271,7 @@ Polymer({
  /** @private */
  onRelaunchClick_() {
+    settings.recordSettingChange();
    this.lifetimeBrowserProxy_.relaunch();
  },
@@ -463,6 +464,7 @@ Polymer({
  /** @private */
  onRelaunchAndPowerwashClick_() {
+    settings.recordSettingChange();
    if (this.currentUpdateStatusEvent_.rollback) {
      // Wipe already initiated, simply relaunch.
      this.lifetimeBrowserProxy_.relaunch();

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/BUILD.gn
@@ -135,6 +135,7 @@ js_library("permission_item") {
    ":store_client",
    ":toggle_row",
    ":util",
+    "../..:metrics_recorder",
  ]
 }
@@ -143,6 +144,7 @@ js_library("pin_to_shelf_item") {
    ":browser_proxy",
    ":toggle_row",
    ":types",
+    "../..:metrics_recorder",
  ]
 }
@@ -199,6 +201,7 @@ js_library("uninstall_button") {
  deps = [
    ":store_client",
    ":util",
+    "../..:metrics_recorder",
    "//ui/webui/resources/cr_elements/cr_button:cr_button",
    "//ui/webui/resources/cr_elements/policy:cr_tooltip_icon",
    "//ui/webui/resources/js:i18n_behavior",

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/permission_item.html
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/permission_item.html
@@ -2,6 +2,7 @@
 <link rel="import" href="shared_style.html">
 <link rel="import" href="toggle_row.html">
+<link rel="import" href="../../metrics_recorder.html">
 <dom-module id="app-management-permission-item">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/permission_item.js
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/permission_item.js
@@ -150,6 +150,7 @@ Polymer({
    app_management.BrowserProxy.getInstance().handler.setPermission(
        this.app_.id, newPermission);
+    settings.recordSettingChange();
    app_management.util.recordAppManagementUserAction(
        this.app_.type,
        this.getUserMetricActionForPermission_(

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/pin_to_shelf_item.html
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/pin_to_shelf_item.html
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="toggle_row.html">
+<link rel="import" href="../../metrics_recorder.html">
 <dom-module id="app-management-pin-to-shelf-item">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/pin_to_shelf_item.js
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/pin_to_shelf_item.js
@@ -85,6 +85,7 @@ Polymer({
        this.app_.id,
        newState,
    );
+    settings.recordSettingChange();
    const userAction = newStateBool ?
        AppManagementUserAction.PinToShelfTurnedOn :
        AppManagementUserAction.PinToShelfTurnedOff;

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/uninstall_button.html
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/uninstall_button.html
@@ -3,6 +3,7 @@
 <link rel="import" href="shared_style.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_button/cr_button.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_tooltip_icon.html">
+<link rel="import" href="../../metrics_recorder.html">
 <dom-module id="app-management-uninstall-button">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/uninstall_button.js
+++ b/chrome/browser/resources/settings/chromeos/os_apps_page/app_management_page/uninstall_button.js
@@ -79,6 +79,7 @@ Polymer({
   */
  onClick_() {
    app_management.BrowserProxy.getInstance().handler.uninstall(this.app_.id);
+    settings.recordSettingChange();
    app_management.util.recordAppManagementUserAction(
        this.app_.type, AppManagementUserAction.UninstallDialogLaunched);
  },

--- a/chrome/browser/resources/settings/chromeos/os_languages_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_languages_page/BUILD.gn
@@ -43,6 +43,7 @@ js_library("os_languages_section") {
 js_library("os_languages_page") {
  deps = [
+    "..:metrics_recorder",
    "..:os_route",
    "../..:lifetime_browser_proxy",
    "../..:router",

--- a/chrome/browser/resources/settings/chromeos/os_languages_page/os_languages_page.html
+++ b/chrome/browser/resources/settings/chromeos/os_languages_page/os_languages_page.html
@@ -28,6 +28,7 @@
 <link rel="import" href="../../router.html">
 <link rel="import" href="../../settings_shared_css.html">
 <link rel="import" href="../../settings_vars_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="os-settings-languages-page">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_languages_page/os_languages_page.js
+++ b/chrome/browser/resources/settings/chromeos/os_languages_page/os_languages_page.js
@@ -322,6 +322,7 @@ Polymer({
  onMoveToTopTap_() {
    /** @type {!CrActionMenuElement} */ (this.$.menu.get()).close();
    this.languageHelper.moveLanguageToFront(this.detailLanguage_.language.code);
+    settings.recordSettingChange();
  },
  /**
@@ -332,6 +333,7 @@ Polymer({
    /** @type {!CrActionMenuElement} */ (this.$.menu.get()).close();
    this.languageHelper.moveLanguage(
        this.detailLanguage_.language.code, true /* upDirection */);
+    settings.recordSettingChange();
  },
  /**
@@ -342,6 +344,7 @@ Polymer({
    /** @type {!CrActionMenuElement} */ (this.$.menu.get()).close();
    this.languageHelper.moveLanguage(
        this.detailLanguage_.language.code, false /* upDirection */);
+    settings.recordSettingChange();
  },
  /**
@@ -351,6 +354,7 @@ Polymer({
  onRemoveLanguageTap_() {
    /** @type {!CrActionMenuElement} */ (this.$.menu.get()).close();
    this.languageHelper.disableLanguage(this.detailLanguage_.language.code);
+    settings.recordSettingChange();
  },
  /**
@@ -448,6 +452,7 @@ Polymer({
   * @private
   */
  onRestartTap_() {
+    settings.recordSettingChange();
    settings.LifetimeBrowserProxyImpl.getInstance().signOutAndRestart();
  },

--- a/chrome/browser/resources/settings/chromeos/os_people_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/BUILD.gn
@@ -46,6 +46,7 @@ js_library("fingerprint_browser_proxy") {
 js_library("fingerprint_list") {
  deps = [
    ":fingerprint_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "../..:router",
    "//third_party/polymer/v1_0/components-chromium/iron-resizable-behavior:iron-resizable-behavior-extracted",
@@ -61,6 +62,7 @@ js_library("fingerprint_list") {
 js_library("kerberos_accounts") {
  deps = [
    ":kerberos_accounts_browser_proxy",
+    "..:metrics_recorder",
    "../..:router",
    "//ui/webui/resources/js:cr",
    "//ui/webui/resources/js:i18n_behavior",
@@ -76,6 +78,7 @@ js_library("kerberos_accounts_browser_proxy") {
 js_library("kerberos_add_account_dialog") {
  deps = [
    ":kerberos_accounts_browser_proxy",
+    "..:metrics_recorder",
    "//chrome/browser/resources/settings/controls:settings_textarea",
    "//ui/webui/resources/cr_elements/cr_input:cr_input",
    "//ui/webui/resources/js:cr",
@@ -155,6 +158,7 @@ js_library("os_sync_browser_proxy") {
 js_library("os_sync_controls") {
  deps = [
    ":os_sync_browser_proxy",
+    "..:metrics_recorder",
    "../../:router",
    "//ui/webui/resources/cr_elements/cr_toggle:cr_toggle",
    "//ui/webui/resources/js:assert",
@@ -165,6 +169,7 @@ js_library("os_sync_controls") {
 js_library("setup_fingerprint_dialog") {
  deps = [
    ":fingerprint_browser_proxy",
+    "..:metrics_recorder",
    "//ui/webui/resources/cr_elements/chromeos/cr_lottie:cr_lottie",
    "//ui/webui/resources/cr_elements/cr_fingerprint:cr_fingerprint_progress_arc",
    "//ui/webui/resources/js:i18n_behavior",

--- a/chrome/browser/resources/settings/chromeos/os_people_page/fingerprint_list.html
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/fingerprint_list.html
@@ -17,6 +17,7 @@
 <link rel="import" href="../os_route.html">
 <link rel="import" href="../../router.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-fingerprint-list">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_people_page/fingerprint_list.js
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/fingerprint_list.js
@@ -150,6 +150,7 @@ Polymer({
  onFingerprintDeleteTapped_(e) {
    this.browserProxy_.removeEnrollment(e.model.index).then(success => {
      if (success) {
+        settings.recordSettingChange();
        this.updateFingerprintsList_();
      }
    });

--- a/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_accounts.html
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_accounts.html
@@ -12,6 +12,7 @@
 <link rel="import" href="../../i18n_setup.html">
 <link rel="import" href="../../router.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="kerberos_accounts_browser_proxy.html">
 <link rel="import" href="kerberos_add_account_dialog.html">

--- a/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_accounts.js
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_accounts.js
@@ -168,6 +168,7 @@ Polymer({
            console.error('Unexpected error removing account: ' + error);
          }
        });
+    settings.recordSettingChange();
    this.closeActionMenu_();
  },
@@ -178,6 +179,7 @@ Polymer({
  onSetAsActiveAccountClick_() {
    this.browserProxy_.setAsActiveAccount(
        /** @type {!settings.KerberosAccount} */ (this.selectedAccount_));
+    settings.recordSettingChange();
    this.closeActionMenu_();
  },

--- a/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_add_account_dialog.html
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_add_account_dialog.html
@@ -15,6 +15,7 @@
 <link rel="import" href="../../controls/settings_textarea.html">
 <link rel="import" href="../../settings_shared_css.html">
 <link rel="import" href="kerberos_accounts_browser_proxy.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="kerberos-add-account-dialog">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_add_account_dialog.js
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/kerberos_add_account_dialog.js
@@ -208,6 +208,7 @@ Polymer({
          // Triggers the UI to update error messages.
          this.updateErrorMessages_(error);
        });
+    settings.recordSettingChange();
  },
  /** @private */
@@ -253,6 +254,7 @@ Polymer({
      // Triggers the UI to update error messages.
      this.updateConfigErrorMessage_(result);
    });
+    settings.recordSettingChange();
  },
  onAdvancedConfigClose_(event) {
@@ -418,4 +420,4 @@ Polymer({
  showError_(errorText) {
    return !!errorText;
  }
 });
\ No newline at end of file
--- a/chrome/browser/resources/settings/chromeos/os_people_page/os_sync_controls.html
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/os_sync_controls.html
@@ -6,6 +6,7 @@
 <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
 <link rel="import" href="../os_route.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="os_sync_browser_proxy.html">
 <dom-module id="os-sync-controls">

--- a/chrome/browser/resources/settings/chromeos/os_people_page/os_sync_controls.js
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/os_sync_controls.js
@@ -125,11 +125,13 @@ Polymer({
  /** @private */
  onTurnOnSyncButtonClick_() {
    this.browserProxy_.setOsSyncFeatureEnabled(true);
+    settings.recordSettingChange();
  },
  /** @private */
  onTurnOffSyncButtonClick_() {
    this.browserProxy_.setOsSyncFeatureEnabled(false);
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/os_people_page/setup_fingerprint_dialog.html
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/setup_fingerprint_dialog.html
@@ -8,6 +8,7 @@
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="fingerprint_browser_proxy.html">
 <dom-module id="settings-setup-fingerprint-dialog">

--- a/chrome/browser/resources/settings/chromeos/os_people_page/setup_fingerprint_dialog.js
+++ b/chrome/browser/resources/settings/chromeos/os_people_page/setup_fingerprint_dialog.js
@@ -341,6 +341,7 @@ Polymer({
    this.$.arc.reset();
    this.step_ = settings.FingerprintSetupStep.MOVE_FINGER;
    this.browserProxy_.startEnroll(this.authToken);
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/BUILD.gn
@@ -31,6 +31,7 @@ js_library("cups_add_printer_dialog_elements") {
 js_library("cups_edit_printer_dialog") {
  deps = [
+    "..:metrics_recorder",
    "../localized_link:localized_link",
    "//ui/webui/resources/cr_components/chromeos/network:mojo_interface_provider",
    "//ui/webui/resources/cr_components/chromeos/network:network_listener_behavior",
@@ -46,6 +47,7 @@ js_library("cups_nearby_printers") {
    ":cups_printers_entry",
    ":cups_printers_entry_list_behavior",
    ":cups_printers_entry_manager",
+    "..:metrics_recorder",
    "//ui/webui/resources/js:list_property_update_behavior",
    "//ui/webui/resources/js:web_ui_listener_behavior",
  ]
@@ -113,6 +115,7 @@ js_library("cups_saved_printers") {
    ":cups_printers_entry",
    ":cups_printers_entry_list_behavior",
    ":cups_printers_entry_manager",
+    "..:metrics_recorder",
    "//ui/webui/resources/cr_elements/cr_action_menu:cr_action_menu",
    "//ui/webui/resources/js:list_property_update_behavior",
    "//ui/webui/resources/js:web_ui_listener_behavior",

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_edit_printer_dialog.html
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_edit_printer_dialog.html
@@ -8,8 +8,9 @@
 <link rel="import" href="chrome://resources/cr_elements/cr_scrollable_behavior.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html">
 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
-<link rel="import" href="../localized_link/localized_link.html">
 <link rel="import" href="../../i18n_setup.html">
+<link rel="import" href="../localized_link/localized_link.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="cups_add_printer_dialog_elements.html">
 <link rel="import" href="cups_printer_dialog_util.html">
 <link rel="import" href="cups_printer_shared_css.html">

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_edit_printer_dialog.js
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_edit_printer_dialog.js
@@ -256,6 +256,7 @@ Polymer({
              this.onPrinterEditSucceeded_.bind(this),
              this.onPrinterEditFailed_.bind(this));
    }
+    settings.recordSettingChange();
  },
  /**

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_nearby_printers.html
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_nearby_printers.html
@@ -9,6 +9,7 @@
 <link rel="import" href="cups_printers_entry.html">
 <link rel="import" href="cups_printers_entry_manager.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-cups-nearby-printers">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_nearby_printers.js
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_nearby_printers.js
@@ -103,6 +103,7 @@ Polymer({
            this.onAddNearbyPrintersSucceeded_.bind(
                this, item.printerInfo.printerName),
            this.onAddNearbyPrinterFailed_.bind(this));
+    settings.recordSettingChange();
  },
  /**
@@ -140,6 +141,7 @@ Polymer({
            this.onQueryDiscoveredPrinterSucceeded_.bind(
                this, item.printerInfo.printerName),
            queryDiscoveredPrinterFailed);
+    settings.recordSettingChange();
  },
  /**
@@ -219,4 +221,4 @@ Polymer({
  getFilteredPrintersLength_() {
    return this.filteredPrinters_.length;
  },
 });
\ No newline at end of file
--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_saved_printers.html
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_saved_printers.html
@@ -10,6 +10,7 @@
 <link rel="import" href="cups_printers_browser_proxy.html">
 <link rel="import" href="cups_printers_entry_list_behavior.html">
 <link rel="import" href="cups_printers_entry.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="../../settings_shared_css.html">
 <dom-module id="settings-cups-saved-printers">

--- a/chrome/browser/resources/settings/chromeos/os_printing_page/cups_saved_printers.js
+++ b/chrome/browser/resources/settings/chromeos/os_printing_page/cups_saved_printers.js
@@ -164,6 +164,7 @@ Polymer({
  onRemoveTap_() {
    this.browserProxy_.removeCupsPrinter(
        this.activePrinter.printerId, this.activePrinter.printerName);
+    settings.recordSettingChange();
    this.activePrinter = null;
    this.activeListEntryIndex_ = -1;
    this.closeActionMenu_();

--- a/chrome/browser/resources/settings/chromeos/os_reset_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/os_reset_page/BUILD.gn
@@ -15,6 +15,7 @@ js_type_check("closure_compile") {
 js_library("os_powerwash_dialog") {
  deps = [
    ":os_reset_browser_proxy",
+    "..:metrics_recorder",
    "../..:lifetime_browser_proxy",
    "../localized_link:localized_link",
  ]

--- a/chrome/browser/resources/settings/chromeos/os_reset_page/os_powerwash_dialog.html
+++ b/chrome/browser/resources/settings/chromeos/os_reset_page/os_powerwash_dialog.html
@@ -6,6 +6,7 @@
 <link rel="import" href="../localized_link/localized_link.html">
 <link rel="import" href="../../lifetime_browser_proxy.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="os-settings-powerwash-dialog">
  <template>

--- a/chrome/browser/resources/settings/chromeos/os_reset_page/os_powerwash_dialog.js
+++ b/chrome/browser/resources/settings/chromeos/os_reset_page/os_powerwash_dialog.js
@@ -30,6 +30,7 @@ Polymer({
  /** @private */
  onRestartTap_() {
+    settings.recordSettingChange();
    settings.LifetimeBrowserProxyImpl.getInstance().factoryReset(
        this.requestTpmFirmwareUpdate);
  },

--- a/chrome/browser/resources/settings/chromeos/personalization_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/personalization_page/BUILD.gn
@@ -15,6 +15,7 @@ js_type_check("closure_compile") {
 js_library("change_picture") {
  deps = [
    ":change_picture_browser_proxy",
+    "..:metrics_recorder",
    "..:os_route",
    "//third_party/polymer/v1_0/components-chromium/iron-selector:iron-selector-extracted",
    "//ui/webui/resources/cr_elements/chromeos/cr_picture:cr_picture_list",

--- a/chrome/browser/resources/settings/chromeos/personalization_page/change_picture.html
+++ b/chrome/browser/resources/settings/chromeos/personalization_page/change_picture.html
@@ -11,6 +11,7 @@
 <link rel="import" href="../os_route.html">
 <link rel="import" href="../../settings_shared_css.html">
 <link rel="import" href="change_picture_browser_proxy.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-change-picture">
  <template>

--- a/chrome/browser/resources/settings/chromeos/personalization_page/change_picture.js
+++ b/chrome/browser/resources/settings/chromeos/personalization_page/change_picture.js
@@ -187,9 +187,11 @@ Polymer({
        break;
      case CrPicture.SelectionTypes.FILE:
        this.browserProxy_.chooseFile();
+        settings.recordSettingChange();
        break;
      case CrPicture.SelectionTypes.PROFILE:
        this.browserProxy_.selectProfileImage();
+        settings.recordSettingChange();
        break;
      case CrPicture.SelectionTypes.OLD:
        const imageIndex = image.dataset.imageIndex;
@@ -198,9 +200,11 @@ Polymer({
        } else {
          this.browserProxy_.selectOldImage();
        }
+        settings.recordSettingChange();
        break;
      case CrPicture.SelectionTypes.DEFAULT:
        this.browserProxy_.selectDefaultImage(image.dataset.url);
+        settings.recordSettingChange();
        break;
      default:
        assertNotReached('Selected unknown image type');

--- a/chrome/browser/resources/settings/chromeos/plugin_vm_page/BUILD.gn
+++ b/chrome/browser/resources/settings/chromeos/plugin_vm_page/BUILD.gn
@@ -11,6 +11,7 @@ js_type_check("closure_compile") {
    ":plugin_vm_remove_confirmation_dialog",
    ":plugin_vm_shared_paths",
    ":plugin_vm_subpage",
+    "..:metrics_recorder",
  ]
 }

--- a/chrome/browser/resources/settings/chromeos/plugin_vm_page/plugin_vm_shared_paths.html
+++ b/chrome/browser/resources/settings/chromeos/plugin_vm_page/plugin_vm_shared_paths.html
@@ -3,6 +3,7 @@
 <link rel="import" href="chrome://resources/cr_elements/cr_icon_button/cr_icon_button.html">
 <link rel="import" href="plugin_vm_browser_proxy.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <dom-module id="settings-plugin-vm-shared-paths">
  <template>

--- a/chrome/browser/resources/settings/chromeos/plugin_vm_page/plugin_vm_shared_paths.js
+++ b/chrome/browser/resources/settings/chromeos/plugin_vm_page/plugin_vm_shared_paths.js
@@ -64,6 +64,7 @@ Polymer({
  onRemoveSharedPathClick_(event) {
    settings.PluginVmBrowserProxyImpl.getInstance().removePluginVmSharedPath(
        PLUGIN_VM, event.model.item.path);
+    settings.recordSettingChange();
  },
 });
 })();