Skip to content

GitLab

T
tangled
Commit b59350b3 authored by Sam Sebree's avatar Sam Sebree Committed by Commit Bot
Browse files
Options

Reland "[Controls Refresh] Regression: Focus is not seen on color selector... 

Reland "[Controls Refresh] Regression: Focus is not seen on color selector icon when the focus is traversed using Tab key."

This is a reland of 2292ef33

This change addresses the bug in which the color picker selection
ring gets placed in the top left corner after closing a color picker
with (255,255,255) is selected.

Bug: 1046648
Change-Id: I78e0fd3175ad1b1cfac9226dc451062ec9e14b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036346
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738396}
parent cdecfbc9
Hide whitespace changes
Inline Side-by-side
Showing with 28 additions and 0 deletions
third_party/blink/renderer/core/html/forms/resources/color_picker.js
View file @ b59350b3
...@@ -1014,6 +1014,7 @@ class ColorSelectionRing extends HTMLElement { ...@@ -1014,6 +1014,7 @@ class ColorSelectionRing extends HTMLElement {
initialize() { initialize() {
this.set(this.backingColorPalette_.left, this.backingColorPalette_.top); this.set(this.backingColorPalette_.left, this.backingColorPalette_.top);
this.onPositionChange_();
} }
/** /**
......
third_party/blink/web_tests/virtual/controls-refresh/color/color-picker-top-left-selection-position-after-reopen.html 0 → 100644
View file @ b59350b3
<!DOCTYPE html>
<html>
<head>
<script>
testRunner.waitUntilDone();
</script>
<script src='../../../fast/forms/resources/picker-common.js'></script>
</head>
<body>
<input type='color' id='color' value='#FFFFFF'>
<p id='description' style='opacity: 0'></p>
<div id='console' style='opacity: 0'></div>
<script>
openPickerWithPromise(document.getElementById('color')).then(() => {
eventSender.keyDown('Enter');
openPicker(document.getElementById('color'),
() => testRunner.notifyDone(),
() => testRunner.notifyDone());
})
</script>
</body>
</html>
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment