Commit b95cf525 authored by Stephen Martinis's avatar Stephen Martinis Committed by Commit Bot

Reland "Reland "Only retry failed tests for layout tests""

This reverts commit bcb0488a.

Reason for revert: Bug fixed

Original change's description:
> Revert "Reland "Only retry failed tests for layout tests""
> 
> This reverts commit c24c2363.
> 
> Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1018590 broke webkit
> 
> Original change's description:
> > Reland "Only retry failed tests for layout tests"
> > 
> > This reverts commit 23ea7f24.
> > 
> > Reason for revert: Issue fixed
> > 
> > Original change's description:
> > > Revert "Only retry failed tests for layout tests"
> > > 
> > > This reverts commit ecb97ada.
> > > 
> > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid
> > > 
> > > Original change's description:
> > > > Only retry failed tests for layout tests
> > > > 
> > > > Recently layout tests have been fairly flaky; this is causing extra load
> > > > on the CQ. Every time layout tests fails, they are retried without patch
> > > > to determine if the failure is a flake or a failure at tip of tree. This
> > > > means that layout tests are running more than other test suites, and
> > > > since layout tests take a long time to run, we end up consuming more
> > > > capacity from our swarming pool than we should.
> > > > 
> > > > Isolated script tests don't have the ability to retry only the tests
> > > > that failed, which is what other test suites do. This CL changes that so
> > > > that layout tests, when re-run without the patch, retry on the tests that
> > > > fail, which should significantly reduce swarming load and cycle time for
> > > > running layout tests without patch.
> > > > 
> > > > Bug: 533481
> > > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
> > > > Reviewed-on: https://chromium-review.googlesource.com/1015843
> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#551821}
> > > 
> > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> > > 
> > > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 533481
> > > Reviewed-on: https://chromium-review.googlesource.com/1018161
> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#551877}
> > 
> > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 533481
> > Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f
> > Reviewed-on: https://chromium-review.googlesource.com/1022552
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552482}
> 
> TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> 
> Change-Id: Ibd7819d1adb43895e33b74622438aa61517a036d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 533481
> Reviewed-on: https://chromium-review.googlesource.com/1022558
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552484}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 533481
Change-Id: I87279f430e6bee58068bad4f3bce71d1923e0834
Reviewed-on: https://chromium-review.googlesource.com/1024719Reviewed-by: default avatarStephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552968}
parent 03745f3a
......@@ -2304,6 +2304,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -2821,6 +2822,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -4822,6 +4824,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -5344,6 +5347,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7673,6 +7677,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7702,6 +7707,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -7731,6 +7737,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -8462,6 +8469,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -8633,6 +8641,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
......@@ -1397,6 +1397,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
......@@ -467,6 +467,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -937,6 +938,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -1407,6 +1409,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -1894,6 +1897,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
......@@ -15,6 +15,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -43,6 +44,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -75,6 +77,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -107,6 +110,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -139,6 +143,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -166,6 +171,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -191,6 +197,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -219,6 +226,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -245,6 +253,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -285,6 +294,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -312,6 +322,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
......@@ -1789,6 +1789,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......@@ -3027,6 +3028,7 @@
"script": "//third_party/WebKit/Tools/Scripts/merge-layout-test-results"
},
"name": "webkit_layout_tests",
"only_retry_failed_tests": true,
"results_handler": "layout tests",
"swarming": {
"can_use_on_swarming_builders": true,
......
......@@ -558,6 +558,7 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'shards': 12,
......@@ -839,6 +840,7 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'shards': 12,
......@@ -1112,6 +1114,7 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
'swarming': {
'dimension_sets': [
......@@ -1791,6 +1794,7 @@
],
'script': '//third_party/WebKit/Tools/Scripts/merge-layout-test-results',
},
'only_retry_failed_tests': True,
'results_handler': 'layout tests',
},
},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment