Commit b9a6b787 authored by dalecurtis's avatar dalecurtis Committed by Commit bot

Report AudioParameters::Format in media-internals. Fix effects.

This allows clients to tell when fallback to fake device has
occurred, which prevents silent no-audio failure situations.

The new key, "device_type" can be seen on all controllers and
streams created.

BUG=455371
TEST=chrome://media-internals

Review URL: https://codereview.chromium.org/890573003

Cr-Commit-Position: refs/heads/master@{#315123}
parent a5b2fc98
......@@ -42,6 +42,7 @@ std::string EffectsToString(int effects) {
{ media::AudioParameters::ECHO_CANCELLER, "ECHO_CANCELLER" },
{ media::AudioParameters::DUCKING, "DUCKING" },
{ media::AudioParameters::KEYBOARD_MIC, "KEYBOARD_MIC" },
{ media::AudioParameters::HOTWORD, "HOTWORD" },
};
std::string ret;
......@@ -63,6 +64,22 @@ std::string EffectsToString(int effects) {
return ret;
}
std::string FormatToString(media::AudioParameters::Format format) {
switch (format) {
case media::AudioParameters::AUDIO_PCM_LINEAR:
return "pcm_linear";
case media::AudioParameters::AUDIO_PCM_LOW_LATENCY:
return "pcm_low_latency";
case media::AudioParameters::AUDIO_FAKE:
return "fake";
case media::AudioParameters::AUDIO_LAST_FORMAT:
break;
}
NOTREACHED();
return "unknown";
}
const char kAudioLogStatusKey[] = "status";
const char kAudioLogUpdateFunction[] = "media.updateAudioComponent";
......@@ -117,6 +134,7 @@ void AudioLogImpl::OnCreated(int component_id,
dict.SetString(kAudioLogStatusKey, "created");
dict.SetString("device_id", device_id);
dict.SetString("device_type", FormatToString(params.format()));
dict.SetInteger("frames_per_buffer", params.frames_per_buffer());
dict.SetInteger("sample_rate", params.sample_rate());
dict.SetInteger("channels", params.channels());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment