Commit cc60c182 authored by hyuk22's avatar hyuk22 Committed by Commit Bot

Use base::ContainsValue() instead of std::find() in ui/

This patch simplifies conditions around the code in ui/

It is much easier to write & read:
  EXPECT_NE(my_vector.cend(), std::find(my_vector.cbegin(),
 my_vector.cend(), my_search_value))
than:
  EXPECT_TRUE(base::ContainsValue(my_vector, my_search_value))

Bug: 561800

Change-Id: I268d33ee877a8cdfa7f6691467aedd59448d63ac
Reviewed-on: https://chromium-review.googlesource.com/c/1282807
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603014}
parent efa9bbcf
......@@ -445,6 +445,7 @@ Jun Fang <jun_fang@foxitsoftware.com>
Jun Jiang <jun.a.jiang@intel.com>
Junchao Han <junchao.han@intel.com>
Junghoon Lee <sjh836@gmail.com>
Junghyuk Yoo <wjdgurdl272@gmail.com>
JungJik Lee <jungjik.lee@samsung.com>
Jungkee Song <jungkee.song@samsung.com>
Junmin Zhu <junmin.zhu@intel.com>
......
......@@ -14,6 +14,7 @@
#include "base/macros.h"
#include "base/rand_util.h"
#include "base/run_loop.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
......@@ -3665,8 +3666,8 @@ TEST_F(ViewTest, GetViewByID) {
View::Views views;
v1.GetViewsInGroup(kGroup, &views);
EXPECT_EQ(2U, views.size());
EXPECT_NE(views.cend(), std::find(views.cbegin(), views.cend(), &v3));
EXPECT_NE(views.cend(), std::find(views.cbegin(), views.cend(), &v4));
EXPECT_TRUE(base::ContainsValue(views, &v3));
EXPECT_TRUE(base::ContainsValue(views, &v4));
}
TEST_F(ViewTest, AddExistingChild) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment