Commit cf8bb0d3 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

android/orderfile: Re-enable linker-warnings-as-errors.

We're on a very different toolchain nowadays; maybe this works now.

Bug: 485542
Change-Id: I5adfd8758853f18c1825d80e2b183ac1da1136f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721079
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarEgor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681784}
parent 97e4f205
...@@ -286,11 +286,8 @@ config("compiler") { ...@@ -286,11 +286,8 @@ config("compiler") {
# Linker warnings. # Linker warnings.
if (fatal_linker_warnings && !(is_chromeos && current_cpu == "arm") && if (fatal_linker_warnings && !(is_chromeos && current_cpu == "arm") &&
!(is_android && use_order_profiling) && !is_mac && !is_ios && !is_mac && !is_ios && current_os != "aix") {
current_os != "aix") {
# TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
# TODO(lizeb,pasko): Fix link errors when linking with order_profiling=1
# crbug.com/485542
ldflags += [ "-Wl,--fatal-warnings" ] ldflags += [ "-Wl,--fatal-warnings" ]
} }
if (fatal_linker_warnings && (is_mac || is_ios)) { if (fatal_linker_warnings && (is_mac || is_ios)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment