Commit d78876f3 authored by Nico Weber's avatar Nico Weber

Work on getting things built with -Wimplicit-fallthrough. This CL was uploaded by git cl split.

R=alancutter@chromium.org

Change-Id: Ic7b6bda1eb48346cb0f2f5f285f458023d8eb798
Reviewed-on: https://chromium-review.googlesource.com/889764Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532350}
parent 1daf04c3
......@@ -527,7 +527,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value,
// but should be PseudoElement like double colon.
if (match_ == kPseudoClass)
match_ = kPseudoElement;
// fallthrough
FALLTHROUGH;
case kPseudoBackdrop:
case kPseudoCue:
case kPseudoPlaceholder:
......@@ -562,7 +562,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value,
pseudo_type_ = kPseudoUnknown;
break;
}
// fallthrough
FALLTHROUGH;
case kPseudoActive:
case kPseudoAny:
case kPseudoAnyLink:
......@@ -836,6 +836,7 @@ String CSSSelector::SelectorText() const {
break;
case kSubSelector:
NOTREACHED();
break;
case kShadowPseudo:
case kShadowSlot:
result = builder.ToString() + result;
......
......@@ -35,7 +35,7 @@ RemoteFontFaceSource::DisplayPeriod ComputePeriod(
case kFontDisplayAuto:
if (is_intervention_triggered)
return RemoteFontFaceSource::kSwapPeriod;
// Fall through.
FALLTHROUGH;
case kFontDisplayBlock:
switch (phase) {
case RemoteFontFaceSource::kNoLimitExceeded:
......
......@@ -134,6 +134,7 @@ static void ExtractSelectorValues(const CSSSelector* selector,
default:
break;
}
break;
default:
break;
}
......
......@@ -338,7 +338,7 @@ SelectorChecker::MatchStatus SelectorChecker::MatchForRelation(
case CSSSelector::kShadowDeepAsDescendant:
Deprecation::CountDeprecation(context.element->GetDocument(),
WebFeature::kCSSDeepCombinator);
// fall through
FALLTHROUGH;
case CSSSelector::kDescendant:
if (context.selector->RelationIsAffectedByPseudoContent()) {
for (Element* element = context.element; element;
......@@ -918,7 +918,7 @@ bool SelectorChecker::CheckPseudoClass(const SelectorCheckingContext& context,
case CSSSelector::kPseudoWebkitAnyLink:
UseCounter::Count(context.element->GetDocument(),
WebFeature::kCSSSelectorPseudoWebkitAnyLink);
// Fall through
FALLTHROUGH;
case CSSSelector::kPseudoLink:
return element.IsLink();
case CSSSelector::kPseudoVisited:
......
......@@ -39,7 +39,7 @@ void CompareTokens(const CSSParserToken& expected,
break;
case kNumberToken:
ASSERT_EQ(expected.GetNumericSign(), actual.GetNumericSign());
// fallthrough
FALLTHROUGH;
case kPercentageToken:
ASSERT_EQ(expected.GetNumericValueType(), actual.GetNumericValueType());
ASSERT_DOUBLE_EQ(expected.NumericValue(), actual.NumericValue());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment