Commit d78876f3 authored by Nico Weber's avatar Nico Weber

Work on getting things built with -Wimplicit-fallthrough. This CL was uploaded by git cl split.

R=alancutter@chromium.org

Change-Id: Ic7b6bda1eb48346cb0f2f5f285f458023d8eb798
Reviewed-on: https://chromium-review.googlesource.com/889764Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532350}
parent 1daf04c3
...@@ -527,7 +527,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value, ...@@ -527,7 +527,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value,
// but should be PseudoElement like double colon. // but should be PseudoElement like double colon.
if (match_ == kPseudoClass) if (match_ == kPseudoClass)
match_ = kPseudoElement; match_ = kPseudoElement;
// fallthrough FALLTHROUGH;
case kPseudoBackdrop: case kPseudoBackdrop:
case kPseudoCue: case kPseudoCue:
case kPseudoPlaceholder: case kPseudoPlaceholder:
...@@ -562,7 +562,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value, ...@@ -562,7 +562,7 @@ void CSSSelector::UpdatePseudoType(const AtomicString& value,
pseudo_type_ = kPseudoUnknown; pseudo_type_ = kPseudoUnknown;
break; break;
} }
// fallthrough FALLTHROUGH;
case kPseudoActive: case kPseudoActive:
case kPseudoAny: case kPseudoAny:
case kPseudoAnyLink: case kPseudoAnyLink:
...@@ -836,6 +836,7 @@ String CSSSelector::SelectorText() const { ...@@ -836,6 +836,7 @@ String CSSSelector::SelectorText() const {
break; break;
case kSubSelector: case kSubSelector:
NOTREACHED(); NOTREACHED();
break;
case kShadowPseudo: case kShadowPseudo:
case kShadowSlot: case kShadowSlot:
result = builder.ToString() + result; result = builder.ToString() + result;
......
...@@ -35,7 +35,7 @@ RemoteFontFaceSource::DisplayPeriod ComputePeriod( ...@@ -35,7 +35,7 @@ RemoteFontFaceSource::DisplayPeriod ComputePeriod(
case kFontDisplayAuto: case kFontDisplayAuto:
if (is_intervention_triggered) if (is_intervention_triggered)
return RemoteFontFaceSource::kSwapPeriod; return RemoteFontFaceSource::kSwapPeriod;
// Fall through. FALLTHROUGH;
case kFontDisplayBlock: case kFontDisplayBlock:
switch (phase) { switch (phase) {
case RemoteFontFaceSource::kNoLimitExceeded: case RemoteFontFaceSource::kNoLimitExceeded:
......
...@@ -134,6 +134,7 @@ static void ExtractSelectorValues(const CSSSelector* selector, ...@@ -134,6 +134,7 @@ static void ExtractSelectorValues(const CSSSelector* selector,
default: default:
break; break;
} }
break;
default: default:
break; break;
} }
......
...@@ -338,7 +338,7 @@ SelectorChecker::MatchStatus SelectorChecker::MatchForRelation( ...@@ -338,7 +338,7 @@ SelectorChecker::MatchStatus SelectorChecker::MatchForRelation(
case CSSSelector::kShadowDeepAsDescendant: case CSSSelector::kShadowDeepAsDescendant:
Deprecation::CountDeprecation(context.element->GetDocument(), Deprecation::CountDeprecation(context.element->GetDocument(),
WebFeature::kCSSDeepCombinator); WebFeature::kCSSDeepCombinator);
// fall through FALLTHROUGH;
case CSSSelector::kDescendant: case CSSSelector::kDescendant:
if (context.selector->RelationIsAffectedByPseudoContent()) { if (context.selector->RelationIsAffectedByPseudoContent()) {
for (Element* element = context.element; element; for (Element* element = context.element; element;
...@@ -918,7 +918,7 @@ bool SelectorChecker::CheckPseudoClass(const SelectorCheckingContext& context, ...@@ -918,7 +918,7 @@ bool SelectorChecker::CheckPseudoClass(const SelectorCheckingContext& context,
case CSSSelector::kPseudoWebkitAnyLink: case CSSSelector::kPseudoWebkitAnyLink:
UseCounter::Count(context.element->GetDocument(), UseCounter::Count(context.element->GetDocument(),
WebFeature::kCSSSelectorPseudoWebkitAnyLink); WebFeature::kCSSSelectorPseudoWebkitAnyLink);
// Fall through FALLTHROUGH;
case CSSSelector::kPseudoLink: case CSSSelector::kPseudoLink:
return element.IsLink(); return element.IsLink();
case CSSSelector::kPseudoVisited: case CSSSelector::kPseudoVisited:
......
...@@ -39,7 +39,7 @@ void CompareTokens(const CSSParserToken& expected, ...@@ -39,7 +39,7 @@ void CompareTokens(const CSSParserToken& expected,
break; break;
case kNumberToken: case kNumberToken:
ASSERT_EQ(expected.GetNumericSign(), actual.GetNumericSign()); ASSERT_EQ(expected.GetNumericSign(), actual.GetNumericSign());
// fallthrough FALLTHROUGH;
case kPercentageToken: case kPercentageToken:
ASSERT_EQ(expected.GetNumericValueType(), actual.GetNumericValueType()); ASSERT_EQ(expected.GetNumericValueType(), actual.GetNumericValueType());
ASSERT_DOUBLE_EQ(expected.NumericValue(), actual.NumericValue()); ASSERT_DOUBLE_EQ(expected.NumericValue(), actual.NumericValue());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment