Commit dc08650c authored by Nic Hollingum's avatar Nic Hollingum Committed by Chromium LUCI CQ

Revert "Remove redundant call to determine crostini app id"

This reverts commit c9c1768b.

Reason for revert:  b/175932227

Original change's description:
> Remove redundant call to determine crostini app id
>
> This is done by AppServiceAppWindowCrostiniTracker::GetShelfAppId before
> this point always, and the subsequent call will always return the same
> thing.
>
> The claim in the comment is probably legacy, as empty-app-id windows
> will be filtered out by
> AppServiceAppWindowLauncherController::OnWindowVisibilityChanged.
>
> Bug: b/172979315
> Change-Id: I38121c68cb48c9840831b83665fdf7e33285cc44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552327
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Commit-Queue: Nic Hollingum <hollingum@google.com>
> Cr-Commit-Position: refs/heads/master@{#830097}

TBR=hollingum@google.com,nancylingwang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/172979315
Change-Id: I6c064cdb82d35d99f383207cd98975271ddf5b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642845Reviewed-by: default avatarNic Hollingum <hollingum@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#846399}
parent 22d9cbed
...@@ -101,6 +101,13 @@ void AppServiceAppWindowCrostiniTracker::OnWindowVisibilityChanged( ...@@ -101,6 +101,13 @@ void AppServiceAppWindowCrostiniTracker::OnWindowVisibilityChanged(
Profile* primary_account_profile = Profile* primary_account_profile =
chromeos::ProfileHelper::Get()->GetProfileByAccountId(primary_account_id); chromeos::ProfileHelper::Get()->GetProfileByAccountId(primary_account_id);
// Windows without an application id set will get filtered out here.
const std::string& crostini_shelf_app_id = crostini::GetCrostiniShelfAppId(
primary_account_profile, exo::GetShellApplicationId(window),
exo::GetShellStartupId(window));
if (crostini_shelf_app_id.empty())
return;
auto* registry_service = auto* registry_service =
guest_os::GuestOsRegistryServiceFactory::GetForProfile( guest_os::GuestOsRegistryServiceFactory::GetForProfile(
primary_account_profile); primary_account_profile);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment