Commit defa3554 authored by John Chen's avatar John Chen Committed by Commit Bot

[ChromeDriver] Clean up WebView test filter

Now that the waterfall has been updated to use the latest WebView,
remove test filter entries that are no longer needed.

Bug: chromedriver:1295, chromedriver:1941
Change-Id: I0f35c3ad62a0b365ac1d204157c2624546f8d379
Reviewed-on: https://chromium-review.googlesource.com/1000542Reviewed-by: default avatarJonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549252}
parent 024713b6
...@@ -250,11 +250,7 @@ _ANDROID_NEGATIVE_FILTER['chromium'] = ( ...@@ -250,11 +250,7 @@ _ANDROID_NEGATIVE_FILTER['chromium'] = (
) )
_ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = ( _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = (
_ANDROID_NEGATIVE_FILTER['chrome_stable'] + [ _ANDROID_NEGATIVE_FILTER['chrome_stable'] + [
# Tests in HeadlessInvalidCertificateTest class can't be run
# on chromedriver_webview_shell
'HeadlessInvalidCertificateTest.*',
'ChromeLoggingCapabilityTest.testPerformanceLogger', 'ChromeLoggingCapabilityTest.testPerformanceLogger',
'ChromeDriverTest.testShadowDom*',
# WebView doesn't support emulating network conditions. # WebView doesn't support emulating network conditions.
'ChromeDriverTest.testEmulateNetworkConditions', 'ChromeDriverTest.testEmulateNetworkConditions',
'ChromeDriverTest.testEmulateNetworkConditionsNameSpeed', 'ChromeDriverTest.testEmulateNetworkConditionsNameSpeed',
...@@ -270,10 +266,6 @@ _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = ( ...@@ -270,10 +266,6 @@ _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = (
'ChromeDriverTest.testSwitchToWindow', 'ChromeDriverTest.testSwitchToWindow',
'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly', 'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly',
'ChromeDriverTest.testGetLogOnClosedWindow', 'ChromeDriverTest.testGetLogOnClosedWindow',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1295
# TODO(gmanikpure): re-enable this test when we stop supporting
# WebView on KitKat.
'ChromeDriverTest.testGetUrlOnInvalidUrl',
# The WebView shell that we test against (on KitKat) does not perform # The WebView shell that we test against (on KitKat) does not perform
# cross-process navigations. # cross-process navigations.
# TODO(samuong): reenable when it does. # TODO(samuong): reenable when it does.
...@@ -289,18 +281,6 @@ _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = ( ...@@ -289,18 +281,6 @@ _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = (
'ChromeDriverTest.testGetLogOnWindowWithAlert', 'ChromeDriverTest.testGetLogOnWindowWithAlert',
'ChromeDriverTest.testSendTextToAlert', 'ChromeDriverTest.testSendTextToAlert',
'ChromeDriverTest.testUnexpectedAlertOpenExceptionMessage', 'ChromeDriverTest.testUnexpectedAlertOpenExceptionMessage',
# The WebView shell that we test against (on Kitkat) does not yet
# support Network.setCookie & deleteCookies DevTools command.
# TODO(gmanikpure): reenable when it does.
'ChromeDriverLogTest.testDisablingDriverLogsSuppressesChromeDriverLog',
'ChromeDriverTest.testCookiePath',
'ChromeDriverTest.testDeleteCookie',
'ChromeDriverTest.testGetHttpOnlyCookie',
'ChromeDriverTest.testGetNamedCookie',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1941
'ChromeDriverTest.testTouchDownMoveUpElement',
'ChromeDriverTest.testTouchFlickElement',
'ChromeDriverTest.testTouchSingleTapElement',
# https://bugs.chromium.org/p/chromium/issues/detail?id=746266 # https://bugs.chromium.org/p/chromium/issues/detail?id=746266
'ChromeDriverSiteIsolation.testCanClickOOPIF', 'ChromeDriverSiteIsolation.testCanClickOOPIF',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2332 # https://bugs.chromium.org/p/chromedriver/issues/detail?id=2332
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment