Commit e34f08fa authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Revert "Fix conditions for can_unwind_with_cfi_table with frame pointers"

This reverts commit 5e4c7d7b.

Reason for revert: 
Speculative revert for failing base_unittests on Android,
CFIBacktraceAndroidTest.TestUnwinding.

See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579

Original change's description:
> Fix conditions for can_unwind_with_cfi_table with frame pointers
> 
> CFI table unwinder is not appilcable for builds with frame pointer
> enabled. Make sure can_unwind_with_cfi_table is set to false.
> No need to check for use_thin_lto.
> 
> BUG=469376
> 
> Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
> Reviewed-on: https://chromium-review.googlesource.com/992890
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548634}

TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org

Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 469376,826718
Reviewed-on: https://chromium-review.googlesource.com/999635Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548765}
parent f72d2fbf
......@@ -143,8 +143,11 @@ assert(!can_unwind_with_frame_pointers || enable_frame_pointers)
# Unwinding with CFI table is only possible on static library builds and
# requried only when frame pointers are not enabled.
can_unwind_with_cfi_table = is_android && !is_component_build &&
!enable_frame_pointers && current_cpu == "arm"
# Builds with use_thin_lto use link registers to store offsets, and this is
# not supported yet.
can_unwind_with_cfi_table =
is_android && !is_component_build && !can_unwind_with_frame_pointers &&
current_cpu == "arm" && !use_thin_lto
declare_args() {
# Whether or not the official builds should be built with full WPO. Enabled by
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment