bindings: Don't use V8CallBoolean for [Replaceable] attributes.

Bug: 670615
Change-Id: Ic386bad40225688c259613fde7f8d81de00044b5
Reviewed-on: https://chromium-review.googlesource.com/c/1288678
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602348}

third_party/blink/renderer/bindings/scripts/v8_attributes.py

@@ -434,9 +434,13 @@ def setter_context(interface, attribute, interfaces, context):
         return
 
     if ('Replaceable' in attribute.extended_attributes):
+        # Create the property, and early-return if an exception is thrown.
+        # Subsequent cleanup code may not be prepared to handle a pending
+        # exception.
         context['cpp_setter'] = (
-            'V8CallBoolean(info.Holder()->CreateDataProperty(' +
-            'info.GetIsolate()->GetCurrentContext(), propertyName, v8Value))')
+            'if (info.Holder()->CreateDataProperty(' +
+            'info.GetIsolate()->GetCurrentContext(), propertyName, v8Value).IsNothing())' +
+            '\n  return')
         return
 
     extended_attributes = attribute.extended_attributes

third_party/blink/renderer/bindings/templates/attributes.cc.tmpl

@@ -440,7 +440,7 @@ v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
   {% if attribute.is_explicit_nullable %}
   bool isNull = IsUndefinedOrNull(v8Value);
   {% endif %}
-  {{attribute.cpp_setter}};
+  {{attribute.cpp_setter | indent(2)}};
 
   {% if attribute.cached_attribute_validation_method %}
   // [CachedAttribute]

third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc

@@ -3686,7 +3686,8 @@ static void replaceableReadonlyLongAttributeAttributeSetter(v8::Local<v8::Value>
   // Prepare the value to be set.
 
   v8::Local<v8::String> propertyName = V8AtomicString(isolate, "replaceableReadonlyLongAttribute");
-  V8CallBoolean(info.Holder()->CreateDataProperty(info.GetIsolate()->GetCurrentContext(), propertyName, v8Value));
+  if (info.Holder()->CreateDataProperty(info.GetIsolate()->GetCurrentContext(), propertyName, v8Value).IsNothing())
+    return;
 }
 
 static void locationPutForwardsAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info) {