Commit eaf365a0 authored by gburanov's avatar gburanov Committed by Commit bot

use 'branding_path_component' to simplify branding in chrome main directory...

use 'branding_path_component' to simplify branding in chrome main directory (and crash service) - part 2

Also in context of this review crash service is also using 'branding_path_component'

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001
for details

BUG=

Review URL: https://codereview.chromium.org/1114453002

Cr-Commit-Position: refs/heads/master@{#327388}
parent 654644c8
...@@ -76,15 +76,8 @@ ...@@ -76,15 +76,8 @@
['OS=="linux"', { ['OS=="linux"', {
'conditions': [ 'conditions': [
['chromeos==1', { ['chromeos==1', {
'conditions': [ 'platform_locale_settings_grd':
['branding=="Chrome"', { 'app/resources/locale_settings_<(branding_path_component)os.grd',
'platform_locale_settings_grd':
'app/resources/locale_settings_google_chromeos.grd',
}, { # branding!=Chrome
'platform_locale_settings_grd':
'app/resources/locale_settings_chromiumos.grd',
}],
]
}, { # chromeos==0 }, { # chromeos==0
'platform_locale_settings_grd': 'platform_locale_settings_grd':
'app/resources/locale_settings_linux.grd', 'app/resources/locale_settings_linux.grd',
......
...@@ -101,14 +101,8 @@ ...@@ -101,14 +101,8 @@
}, },
], ],
'variables': { 'variables': {
'conditions': [
['branding=="Chrome"', {
'theme_dir_name': 'google_chrome',
}, { # else: 'branding!="Chrome"
'theme_dir_name': 'chromium',
}],
],
'libpeer_target_type%': 'static_library', 'libpeer_target_type%': 'static_library',
'theme_dir_name': '<(branding_path_component)',
}, },
'postbuilds': [ 'postbuilds': [
{ {
......
...@@ -13,18 +13,8 @@ ...@@ -13,18 +13,8 @@
{ {
'target_name': 'caps_resources', 'target_name': 'caps_resources',
'type': 'none', 'type': 'none',
'conditions': [
['branding == "Chrome"', {
'variables': {
'branding_path': '../../../app/theme/google_chrome/BRANDING',
},
}, { # else branding!="Chrome"
'variables': {
'branding_path': '../../../app/theme/chromium/BRANDING',
},
}],
],
'variables': { 'variables': {
'branding_path': '../../../app/theme/<(branding_path_component)/BRANDING',
'output_dir': 'caps', 'output_dir': 'caps',
'template_input_path': '../../../app/chrome_version.rc.version', 'template_input_path': '../../../app/chrome_version.rc.version',
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment