Commit ef48b297 authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

Revert "[ios] Speed up egtest failures by skipping _recordFailure."

This reverts commit eda4c3ea.

Reason for revert: This change is masking some exception failures.

Original change's description:
> [ios] Speed up egtest failures by skipping _recordFailure.
> 
> _recordFailure internally spends a very long time symbolicating
> on iOS13. Skipping this seems to be safe.
> 
> Bug:991338
> 
> Change-Id: I74c2872cd82de0840a6bcdd0f799703b5eb9bdb0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725137
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684557}

TBR=rohitrao@chromium.org,justincohen@chromium.org,monufriienko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991338
Change-Id: I66223c64e6236dbea9feb8ac74e7c29b832e2eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866990Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707061}
parent 25350818
......@@ -110,7 +110,8 @@ void TapOnWebElementWithID(const std::string& elementID) {
}
// Tests the observer correctly identifies when the keyboard stays on screen.
- (void)testKeyboardDidStayOnScreen {
// TODO(crbug.com/1015550) keyboardDidStayOnScreen is not called on iOS13.
- (void)DISABLED_testKeyboardDidStayOnScreen {
// Opening the keyboard from a webview blocks EarlGrey's synchronization.
ScopedSynchronizationDisabler disabler;
// Brings up the keyboard by tapping on one of the form's field.
......
......@@ -108,12 +108,6 @@ UIDeviceOrientation GetCurrentDeviceOrientation() {
} // namespace
// Category for overriding private methods on XCTestCase. See crbug.com/991338
// for more information.
@interface XCTestCase (Private)
- (void)_recordFailure:(id)arg1;
@end
#if defined(CHROME_EARL_GREY_2)
GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface)
#endif
......@@ -194,16 +188,6 @@ GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeTestCaseAppInterface)
}
}
- (void)_recordFailure:(id)arg1 {
if (@available(iOS 13, *)) {
// _recordFailure internally spends a very long time symbolicating
// on iOS13. Skipping this seems to be safe. See crbug.com/991338
// for more information.
} else {
[super _recordFailure:arg1];
}
}
#if defined(CHROME_EARL_GREY_1)
+ (void)setUp {
[super setUp];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment