Commit f1d04107 authored by Jesse McKenna's avatar Jesse McKenna Committed by Commit Bot

Small cleanup to profile_statistics_unittest.cc

This change makes the following small cleanup changes:
* remove unused variable |quit_closure_|
* use default initialization rather than member-list initialization
  for int member variable
* remove constructor no longer needed after the above change
* replace empty destructor body with "= default"

Change-Id: Idb14db66dbc2131fe8bc3fffbdedce265e8b513a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532537Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#826808}
parent f37588ad
...@@ -60,8 +60,6 @@ bookmarks::BookmarkModel* CreateBookmarkModelWithoutLoad(Profile* profile) { ...@@ -60,8 +60,6 @@ bookmarks::BookmarkModel* CreateBookmarkModelWithoutLoad(Profile* profile) {
class BookmarkStatHelper { class BookmarkStatHelper {
public: public:
BookmarkStatHelper() : num_of_times_called_(0) {}
void StatsCallback(profiles::ProfileCategoryStats stats) { void StatsCallback(profiles::ProfileCategoryStats stats) {
if (stats.back().category == profiles::kProfileStatisticsBookmarks) if (stats.back().category == profiles::kProfileStatisticsBookmarks)
++num_of_times_called_; ++num_of_times_called_;
...@@ -70,15 +68,14 @@ class BookmarkStatHelper { ...@@ -70,15 +68,14 @@ class BookmarkStatHelper {
int GetNumOfTimesCalled() { return num_of_times_called_; } int GetNumOfTimesCalled() { return num_of_times_called_; }
private: private:
base::Closure quit_closure_; int num_of_times_called_ = 0;
int num_of_times_called_;
}; };
} // namespace } // namespace
class ProfileStatisticsTest : public testing::Test { class ProfileStatisticsTest : public testing::Test {
public: public:
ProfileStatisticsTest() : manager_(TestingBrowserProcess::GetGlobal()) {} ProfileStatisticsTest() : manager_(TestingBrowserProcess::GetGlobal()) {}
~ProfileStatisticsTest() override {} ~ProfileStatisticsTest() override = default;
protected: protected:
void SetUp() override { void SetUp() override {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment