Commit f2c629ac authored by Martin Kreichgauer's avatar Martin Kreichgauer Committed by Commit Bot

chrome/installer/mac: fix entitlements in sign_app

In 2c29863d, a change to sign_app.sh.in
changed the value of is_development in the false case from "" to "0".
Because the script tests with the -z/-n flags of the bash test command,
this made is_development effectively always true.

Bug: 897973
Change-Id: Ic1181413237a4d0b966d94bbbf5bcc7bdf29450b
Reviewed-on: https://chromium-review.googlesource.com/c/1297402Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602167}
parent c8a1dc54
......@@ -24,6 +24,9 @@ export -n SHELLOPTS
ME="$(basename "${0}")"
readonly ME
# Note that |is_development| is tested for string length, not value.
is_development=
if [[ ${#} -eq 4 || ${#} -eq 6 ]]; then
app_path="${1}"
codesign_keychain="${2}"
......@@ -41,7 +44,6 @@ else
codesign_id="${3}"
provisioning_profile="${4}"
entitlements_plist="${5}"
is_development=0
fi
script_dir="$(dirname "${0}")"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment