Remove out-dated code for LayoutTableSection visual overflow

The code was needed before we painted collapsed borders using table
row as the display item client.

Bug: 663208
Change-Id: I0ee5033da9405f7a1b4c94ca52b71c88578b3d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566613Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650541}

third_party/blink/renderer/core/layout/layout_table_section.cc

@@ -1394,19 +1394,6 @@ void LayoutTableSection::ComputeVisualOverflowFromDescendants() {
     for (auto* cell = row->FirstCell(); cell; cell = cell->NextCell()) {
       if (cell->HasSelfPaintingLayer())
         continue;
-      // Let the section's self visual overflow cover the cell's whole collapsed
-      // borders. This ensures correct raster invalidation on section border
-      // style change.
-      // TODO(wangxianzhu): When implementing row as DisplayItemClient of
-      // collapsed borders, the following logic should be replaced by
-      // invalidation of rows on section border style change. crbug.com/663208.
-      if (const auto* collapsed_borders = cell->GetCollapsedBorderValues()) {
-        LayoutRect rect = cell->RectForOverflowPropagation(
-            collapsed_borders->LocalVisualRect());
-        rect.MoveBy(cell->Location());
-        AddSelfVisualOverflow(rect);
-      }
-
       if (force_full_paint_ || !cell->HasVisualOverflow())
         continue;
 

third_party/blink/renderer/core/layout/layout_table_section_test.cc

@@ -301,11 +301,8 @@ TEST_F(LayoutTableSectionTest, VisualOverflowWithCollapsedBorders) {
 
   auto* section = GetSectionByElementId("section");
 
-  // The section's self visual overflow covers the collapsed borders.
-  LayoutRect expected_self_visual_overflow = section->BorderBoxRect();
-  expected_self_visual_overflow.ExpandEdges(LayoutUnit(1), LayoutUnit(8),
-                                            LayoutUnit(0), LayoutUnit(0));
-  EXPECT_EQ(expected_self_visual_overflow, section->SelfVisualOverflowRect());
+  // The section's self visual overflow doesn't cover the collapsed borders.
+  EXPECT_EQ(section->BorderBoxRect(), section->SelfVisualOverflowRect());
 
   // The section's visual overflow covers self visual overflow and visual
   // overflows rows.

third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/paint/invalidation/table/invisible-col-visible-td-expected.txt

@@ -8,7 +8,7 @@
       "paintInvalidations": [
         {
           "object": "LayoutTableSection TBODY",
-          "rect": [8, 8, 200, 200],
+          "rect": [9, 9, 198, 198],
           "reason": "style change"
         }
       ]

third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/paint/invalidation/table/invisible-tbody-visible-td-expected.txt

@@ -8,7 +8,7 @@
       "paintInvalidations": [
         {
           "object": "LayoutTableSection TBODY id='tbody'",
-          "rect": [8, 8, 200, 200],
+          "rect": [9, 9, 198, 198],
           "reason": "background"
         }
       ]

third_party/blink/web_tests/paint/invalidation/table/invisible-col-visible-td-expected.txt

@@ -19,7 +19,7 @@
       "paintInvalidations": [
         {
           "object": "LayoutTableSection TBODY",
-          "rect": [8, 8, 200, 200],
+          "rect": [9, 9, 198, 198],
           "reason": "style change"
         }
       ]

third_party/blink/web_tests/paint/invalidation/table/invisible-tbody-visible-td-expected.txt

@@ -19,7 +19,7 @@
       "paintInvalidations": [
         {
           "object": "LayoutTableSection TBODY id='tbody'",
-          "rect": [8, 8, 200, 200],
+          "rect": [9, 9, 198, 198],
           "reason": "background"
         }
       ]