Skip to content

GitLab

T
tangled
Commit fb02d21d authored by Hans Wennborg's avatar Hans Wennborg
Browse files
Options

Revert "Run notification_helper_unittests on Chromium buildbots" 

This reverts commit b0dc3696.

Reason for revert:
The best breaks all Windows buildbots on the chromium.clang waterfall,
and I guess others might be broken too.

Either these need to be added to the blacklist for this test, or
ideally there would be some mechanism to express this test needs to
run on Win10 hosts.

Original change's description:
> Run notification_helper_unittests on Chromium buildbots
> 
> Since this unit test requires WinRT which only exists on Windows 8 or above,
> we don't run it on Windows 7 bots.
> 
> Bug: 734095
> Change-Id: I6889efb1e9425fe3cc4ae37ae6b0f0d54e7c4f5a
> Reviewed-on: https://chromium-review.googlesource.com/915016
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536906}

TBR=dpranke@chromium.org,chengx@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734095, 813553
Change-Id: I9ae4611aedb58d1ecf58ba25c2b4f387ae40a59b
Reviewed-on: https://chromium-review.googlesource.com/923740Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537654}
parent 4d3b7078
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 194 deletions
testing/buildbot/chromium.clang.json
View file @ fb02d21d
......@@ -955,12 +955,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -1227,12 +1221,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -1486,12 +1474,6 @@
},
"test": "native_theme_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -1770,12 +1752,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -2078,12 +2054,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -2386,12 +2356,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -2694,12 +2658,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3002,12 +2960,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3310,12 +3262,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3618,12 +3564,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3926,12 +3866,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -4228,12 +4162,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -4536,12 +4464,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -7749,12 +7671,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -8063,12 +7979,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -8371,12 +8281,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -8679,12 +8583,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -8987,12 +8885,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -9295,12 +9187,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -9603,12 +9489,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -9911,12 +9791,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -10249,12 +10123,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -10563,12 +10431,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......
testing/buildbot/chromium.fyi.json
View file @ fb02d21d
......@@ -2964,12 +2964,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3275,12 +3269,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3547,12 +3535,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3806,12 +3788,6 @@
},
"test": "native_theme_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -7886,12 +7862,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -9241,12 +9211,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": false
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": false
......
testing/buildbot/chromium.win.json
View file @ fb02d21d
......@@ -988,12 +988,6 @@
},
"test": "net_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "notification_helper_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
......
testing/buildbot/gn_isolate_map.pyl
View file @ fb02d21d
......@@ -862,10 +862,6 @@
"label": "//chrome/installer/mini_installer:next_version_mini_installer",
"type": "additional_compile_target",
},
"notification_helper_unittests": {
"label": "//notification_helper:notification_helper_unittests",
"type": "raw",
},
"ocmock_support_unittests": {
"label": "//ios/testing:ocmock_support_unittests",
"type": "raw",
......
testing/buildbot/test_suite_exceptions.pyl
View file @ fb02d21d
......@@ -2656,15 +2656,6 @@
},
},
},
'notification_helper_unittests': {
'remove_from': [
# On chromium.win, this unit test requires WinRT, which only exists on Windows 8 or above.
'Win 7 Tests x64 (1)',
'Win7 (32) Tests',
'Win7 Tests (1)',
'Win7 Tests (dbg)(1)',
],
},
'printing_unittests': {
'remove_from': [
# chromium.chromiumos
......
testing/buildbot/test_suites.pyl
View file @ fb02d21d
......@@ -1711,7 +1711,6 @@
],
},
},
'notification_helper_unittests': {},
'sbox_integration_tests': {
'swarming': {
'dimension_sets': [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment