- 04 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48be9ec54eea..df482aad3e7e git log 48be9ec54eea..df482aad3e7e --date=short --no-merges --format='%ad %ae %s' 2019-11-04 seanabraham@chromium.org chromeos_config: make gale noncritical Created with: gclient setdep -r src/third_party/chromite@df482aad3e7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I616bd5825e0619814e041c5371955c493d6aad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712193}
-
Henry Jian authored
This is a reland of commit 274ea563 Previously, the original commit was reverted to land another CL and push the shell apk immediately. There was nothing wrong with the original CL. Since the other CL was landed and pushed, we can now reland this CL. Original change's description: > [Android WebAPK] Create resources for web shortcuts. > > Resources used need to be pre-declared in the shell. > > Since we don't know how many shortcuts are needed for a web app until > the creation request, we create 4 copies of the needed resources to > declare a shortcut, since that is the maximum number of shortcuts > allowed on Android. > > The following resources are needed (per shortcut): > - name > - short_name > - icon (placeholder taken from > https://material.io/resources/icons/?icon=filter_1&style=baseline) > The shortcuts.xml is also partially generated to use the resources, so > that building the shell apk doesn't fail. They are all disabled by > default, and will need to be re-enabled on the server-side. > Bug: 1010471 > Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709189} Bug: 1010471 Change-Id: I72d7bb00e7bd80063e9eb5f87f61467ddc7a6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895864 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712192}
-
Elly Fong-Jones authored
As of 10.15, an app must be registered with LaunchServices before the corresponding bundle ID can become a protocol scheme handler. This happens as part of app startup normally, but in tests where there is no app, it needs to be done manually. Unfortunately these tests do not have a bundle to register, so this change has them try to use the main browser bundle when registering. This is a less evil version of https://chromium-review.googlesource.com/c/chromium/src/+/1890960 Bug: 998740 Change-Id: I96b2d21b1966c304dba3d61e4539308d96221d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893582Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712191}
-
Tim Song authored
Currently, only the quick settings bubble is updating its bounds when the display configuration changes (e.g. screen rotation). We also need to update the bounds of the message center as well. TEST=manually on tablet device BUG=1019506 Change-Id: I12e9d8f0ec92c5105f835b83a345e73f950baab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894319Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712190}
-
Elly Fong-Jones authored
We never did this cleanup after shipping MacViews. This change removes all the remaining uses of it (blessedly only in tests) and removes the namespace altogether. Bug: 845389 Change-Id: Icb52064f8ad7a8c66030c941ba1cdf298a1ae73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895654 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712189}
-
Kevin McNee authored
This tests that an extension background page is able to declare variables whose names are the same as guest view elements without the declarations being considered syntax errors. Bug: 1014385 Change-Id: I5ca92d739fe04fece2078f53e9f5eca4f73b040f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864407Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#712188}
-
Gil Dekel authored
This CL fixes a false assumption that both the horizontal and vertical sampling factors are powers of two in jpeg_image_decoder.cc when attempting to calculate the coded size of a jpeg in JPEGImageDecoder::MakeMetadataForDecodeAcceleration. Bug: 1016214 Change-Id: I687e5b9cd428abe507e22ba9d753a17b255436e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872639 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#712187}
-
Alex Cooper authored
Updates strings in keeping with UX guidance during WebXr launch review in 79 and also improves string "buildability" by making the bulleted list easier to concatenate at run time. Fixed: 1019393,1017467 Change-Id: I75bcaa1e8d6f92fd113089521fe177f6d3e48c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895395 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#712186}
-
Simeon Anfinrud authored
This target packages output artifacts into a format that the Cast internal build infrastructure expects. Bug: Internal b/143701141 Test: build atv and udon with internal patch Change-Id: I38bab1bdffbb2cb78ae503f554def458f296ab41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894831Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712185}
-
Alison Maher authored
Add support for the new system color names, Canvas and CanvasText. Canvas maps to the Window system color, and CanvasText maps to WindowText. Spec: https://drafts.csswg.org/css-color-4/#css-system-colors Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-apVTp8jBi0 Bug: 1015968 Change-Id: I0047e6b6d6c87f13f556d5ad147d9c4be421a592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864378 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712184}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5f25e481c49d..5dba5c7ba486 git log 5f25e481c49d..5dba5c7ba486 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 lalitm@google.com Merge "trace_processor: add benchmark for table iterator" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Extract HeapGraph parsing into module" 2019-11-04 taylori@google.com Merge "perfetto-ui: Condense track size" 2019-11-04 lalitm@google.com Merge "trace_processor: add support for like constraint" 2019-11-04 lalitm@google.com Merge "trace_processor: add benchmarks for filtering parent col in child" Created with: gclient setdep -r src/third_party/perfetto@5dba5c7ba486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icc8e425892d0ed149ca794e081135b868f6ce562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712183}
-
Koji Ishii authored
Following bot results are included. 176 177 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iacab391e8f61f7bdd3215d709e2b8a6ddf8b0186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897866Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712182}
-
Ahmed Mehfooz authored
Bug: 1013680 Change-Id: Ic3e5ef9b61f01af716a11cf3c5de5c73f1a72e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884753Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712181}
-
Luke Zielinski authored
WPT Metadata builder bugfix - don't try to split the path for a test if the manifest returns None for that test name. Also added a unit test for this. TBR=robertma@chromium.org Change-Id: I45f2a1f2ff9380446e28d599337d22cf89830fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897952Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712180}
-
Amin Hassani authored
Chrome OS does not use end of life status anymore. It has been replaced with end of life date. Bug: 1005511 Test: cq passes Change-Id: I0bbd438852a9243016e5e06881625da0a5149282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891467 Commit-Queue: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#712179}
-
Bruce Dawson authored
While working on some installer changes I realized that misspelled patterns in chrome.release are silently ignored, which makes installer errors harder to find. This change adds optional diagnostics (verbose only) for patterns that don't match any files, and it cleans up the errors found by this. eventlog_provider.dll was not listed as a dependency and was therefore not reliably placed in chrome.7z. ffmpeg.dll, icudt.dll, and locales\*.dll no longer ship but were still listed in chrome.release. chrome_child.dll is missing but is retained for now so that we can go back to multi-dll builds if we want to. The default_apps and Chrome-branded logos were not in the GOOGLE_CHROME section. The only other warnings I have seen are from files that are configuration specific. We should also consider tagging which patterns are optional so that we can fail on unexpected missing files, although there may be too many files that are optional given config variations. While cleaning up the Python script I made some print-commands Python 3 compatible and changed how the archive command was printed so that back-slashes wouldn't be doubled-up. Bug: 920704, 445616 Change-Id: I96928ea1e1f18a4c52664cf19d0ccca0a10de1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894434Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8abbd40c2a27..b2cba7759c45 Created with: gclient setdep -r src-internal@b2cba7759c45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idd6eae1b7dad374a0008af9b270b920f5493a62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897849Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 349f218f. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9d52531cd19628e7482a958152748c3337762dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897777Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712176}
-
Nate Fischer authored
No change to production logic. This fixes a bug in aw_metrics_service_client_unittest.cc. SetInSample() should have changed IsInSample()'s return value, but it didn't. This fixes that. Tests are still passing with and without this change. Fixed: 1020780 Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: Id2061d6cf80129cfa1dfb29a869e185615526fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895900 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712175}
-
Sasha McIntosh authored
Add field trial testing for android webview tot the finch experiment DecodeWebPToYUV. Bug: 966008 Change-Id: I0939b730e5736b5bc9a6b6a194ee13aa3e8925d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895513Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#712174}
-
Daniel McArdle authored
Bug: 1016184 Change-Id: I794d668dbfe12cc713e435ddc086490787627afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894462Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#712173}
-
Ahmed Fakhry authored
The Files app, as well as other apps, if they're evicted due to being occluded by other windows, will show as empty for a second or more in overview until reloaded. This CL makes them behave the same way as browser windows, that is they show stale contents until reloaded. BUG=986085 TEST=Manually: follow steps on bug, and note the issue no longer shows. TEST=Added new: browser_tests --gtest_filter=AppWindowBrowserTest.ShouldShowStaleContentOnEviction Change-Id: Ie5ad2f07be3eae8627f16d9ddd3977d22f9085a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894095Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712172}
-
Alison Maher authored
On child-initiated re-layouts, SVG elements with percentage dimensions overflow auto-sized parents when LayoutNG is enabled. The reason being that ObjectIsRelayoutBoundary() treats all SVGs as layout roots upon re-layout, even when the width and height are not fixed. With LayoutNG enabled, this becomes a problem because BoxLayoutExtraInput does not get set when LayoutSVGRoot is a layout root, leading to a miscalculation in sizing. One option would be to set BoxLayoutExtraInput for LayoutSVGRoots when they are layout roots. However, in order to keep SVG behavior consistent with other objects, this change fixes the above issue by preventing layout root optimization altogether for SVG elements that do not have a fixed height and width. web_tests/paint/invalidation/svg/color-stop-properties.html was updated to use "width:100vw" and "height:100vh" instead of "width:100%" and "height:100%". With the new changes to ObjectIsRelayoutBoundary, an svg root with a percentage height and width will cause extra invalidation steps. Updating the width and height of the svg element in this test to an equivalent fixed height and width avoids extra invalidation steps and disruption to the test expectations. Bug: 1016759 Change-Id: Id0ccdafb20e5ce3a1b58be3577ca74dccc0c20c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881691Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712171}
-
Peter E Conn authored
With this CL, the split between Verifier and VerifierDelegate is more strict. The Verifier keeps the current verification state and triggers verification when necessary and the VerifierDelegate deals with everything else (specifically whether we should perform full verification or just check the cache, and what scope the verification is relevant for). Bug: 1018672 Change-Id: I92608eb4a7dfb8aa526679d0bb678847c63f4f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893852 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712170}
-
Xianzhu Wang authored
- Tighten config matching: the specified flags must start with all config flags to match. This avoids ambiguity when matching specified flags ["--aa", "--bb"] to 2 configs { "name": "a", "args": ["--aa"] }, { "name": "b", "args": ["--bb"] }, Now the first config will be matched, instead of exception raised. - Allow multiple flags in additional-driver-flag.setting. Bug: 1019501 Change-Id: I8018a14ac9562e7482e3a776730a2d6195f4355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897341 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#712169}
-
Toni Barzic authored
When on screen keyboard state changes, AppListView was calling SetState to ensure the current bounds match the current state. This does more work than necessary - for example closes the active folder if it exists, and it should be avoided if possible. This changes the logic to reset the state only if the target bounds change. BUG=1020754 Change-Id: I8a393b5d88a37cee8f5369c68492304589c45274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896304Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712168}
-
Nazerke authored
This module does not have actual tests yet. Notable changes: - add ios_showcase_g2tests_module module - add ios_showcase_eg2tests_module to ios/chrome/test/earl_grey2:all_tests target This CL follows the same pattern as https://crrev.com/c/1628171 Bug: 866147 Change-Id: I88a311ec1c2e26078977c59345323152a7ea7adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892956Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#712167}
-
François Doray authored
I wrote comments for myself while investigating a session restore bugs. This CL adds these comments to TOT so other developers can benefit from them. This should be a no-op CL. Change-Id: If7a9021f71b9ae1c0e57eba6e589255f69e0e99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894463 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712166}
-
Andy Paicu authored
Previously the test was disabled on non-mac but since it's causing flaky failures on mac as well, disabling it on all platforms. Example failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29 TBR=lazyboy@chromium.org Bug: 833854 Change-Id: I0c41df918550a66b46d53b3d7589c7959f56636b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897926Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712165}
-
Patrick Monette authored
Bug: 974015 Change-Id: Iba87325736c1e40f9e7056aff08dbda7ae0bf40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896061 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#712164}
-
Mingjing Zhang authored
Time::Midnight() currently defines midnight as 00:00:00am for all timezones. However, for certain regions where Daylight Saving Time ends at midnight, 00:00am is skipped and the DST-ending day starts at 1:00am. This CL adds a new behavior to Time::Midnight() such that if 00:00am is not a legal time in the local timezone, then default midnight to 1:00am instead. Bug: 1019434 Change-Id: Ife3b6480bb86f4318150287569b5846bc8ad97a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890815 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712163}
-
Ahmed Fakhry authored
The wallpaper paint code of the centered layout used to just draw the image with its original size centered in the display area. DeskMiniView which uses WallpaperBaseView to draw the wallpaper in its small bounds needs to apply a scale to that original size of the wallpaper image, to scale it down by the same factor it scales down the desk. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=992339#c6 BUG=992339 TEST=Manually, Pick a wallpaper image from the local file system, and make its layout centered. Change-Id: I28e253c8ba48b12a25c83576e41037d1ad24783f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896245Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712162}
-
Sam Maier authored
Change-Id: Ib538c60f5e1fa2e81432bc0992a482aced6eb7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897847 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#712161}
-
Eric Stevenson authored
Bug: 993421 Change-Id: I805a539f3a40d6c421b72013e9ce53f32dc5069b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897340 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#712160}
-
Daniel Vogelheim authored
This adds a second CSP-triggered check when navigating to javascript:-URLs. Newer Trusted Type spec versions treat this similar to an assignment to a <script> tag and run the TT default policy on it. The implementation is a bit more complicated, because this is a TT check that does not normally occur during JS execution. This updates the TT implementation to the latest spec version. R=mkwst Bug: 1002555 Change-Id: I4b815c74c5b9e3e4a11c7cc35c8668d32d2ae7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865313 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712159}
-
Sigurd Schneider authored
This CL enables a layout test with updated expectations after landing crrev.com/c/1891417. Bug: chromium:1004203 Change-Id: I27d6bc861c41f4d931e4a7a9c216f8c763bf1ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895343 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#712158}
-
Rune Lillesveen authored
With flat tree style recalc enabled, we need to update the new flat tree ancestors with ChildNeedsStyleRecalc() when the slot assignment changes. SetNeedsStyleRecalc() will only do that if the node was clean. Otherwise it assumes the child-dirty bits are already marked. If we are already dirty, call MarkAncestorsWithChildNeedsStyleRecalc() to update the child-dirty chain on FlatTreeParentChanged(). Also, added an early return for disconnected elements. Bug: 972752 Change-Id: I5bc76ee70eb310f2d2bc1765dcfcd15e4883f0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893060Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712157}
-
Sadrul Habib Chowdhury authored
Measure the peak gpu-memory usage during scrolls. Report it in the rendering benchmark too. BUG=908462 Change-Id: Iecbadca9d96e74998ae4820c112443ed7b4d2588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864320 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712156}
-
Fredrik Söderquist authored
Per: https://svgwg.org/svg2-draft/types.html#__svg__SVGLength__valueAsString Bug: 928015 Change-Id: I2dd2cd707fb01d18f2ca01d0f3488cce3d06fd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1451927 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#712155}
-
Eric Stevenson authored
Helpful for debugging issues via. -whyareyounotinlining. Bug: 993421 Change-Id: Ie57afc9132b37f18e2200ab68d469f04d2637c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869674 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712154}
-