- 19 Nov, 2018 35 commits
-
-
Luciano Pacheco authored
Quick view: Style audio and video to have cursor pointer on their buttons Bug: 848216 Change-Id: I181cd2d3da2721d8c5bce837f0721435d4850297 Reviewed-on: https://chromium-review.googlesource.com/c/1341730Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e22505b4f07f..01979132133e git log e22505b4f07f..01979132133e --date=short --no-merges --format='%ad %ae %s' 2018-11-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@01979132133e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@chromium.org Change-Id: I7da676ba699bf377d65441bcfe82f95ff167f31b Reviewed-on: https://chromium-review.googlesource.com/c/1341561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609189}
-
Joel Hockey authored
Setting |overflow: none| in .progress-frame fixes it to display long filenames and the open/close controls within the visible space and intended. Bug: 825289 Change-Id: Id5027bf73961063f8568083d744264e9021aeb1a Reviewed-on: https://chromium-review.googlesource.com/c/1341728Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609188}
-
Noel Gordon authored
Bug: 905930 Change-Id: Ice0fb6efbfdaa7f52463cb9876d50b85b9900989 Reviewed-on: https://chromium-review.googlesource.com/c/1341298Reviewed-by:
-
tby authored
Add UMA logging for the error status of the ALS, the brightness monitor, and the validity of the user's personal curve at initialisation. Bug: 881215 Change-Id: I63f5e9da17cf9ee5e67ce67a2b7646751bbd808e Reviewed-on: https://chromium-review.googlesource.com/c/1319310 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609186}
-
Joel Hockey authored
In FilesApp, we set |overflow: auto| on .cr-dialog-container to allow scrolling on dialogs such as the chrome web store dialog which requires scrolling to work on small screens. The pulse event when a user clicks on .cr-dialog-container causes the frame (dialog box) to increase in size by 2% for 180ms. This is causing scrollbars to flash on during that time which is not desirable. By setting the pulse to increase the entire .cr-dialog-container rather than just the frame, we get the same intended visual effect, but without scrollbar flicker. Bug: 883671 Change-Id: I3fb75bef14059bc92b8baa2367290a16b0b0e08f Reviewed-on: https://chromium-review.googlesource.com/c/1341432Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609185}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7eaaf1ff7e99..42fbb1521607 Created with: gclient setdep -r src-internal@42fbb1521607 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibe06f4f238dc2214f5630ceaf234acf5ff4253bc Reviewed-on: https://chromium-review.googlesource.com/c/1341560Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609184}
-
Manu Cornet authored
A few changes here: * Specify padding on both ends of the whole tray separately (instead of using space around some tray items to build it up) * Override the size function for the battery to better match its actual visual footprint. * Specify padding between items with one single number, used at the layout level. This all allows for simpler code while better matching the specs. Bug: 901989 Change-Id: Ia75dcfc7b355b114e6492c26ee4ce6372af92f71 Reviewed-on: https://chromium-review.googlesource.com/c/1328042 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609183}
-
Luciano Pacheco authored
Change RootPath for Downloads volume when MyFilesVolume is enabled, add /Downloads to RootPath, so tests navigate to MyFiles/Downloads sub-folder by default. This allows to run the tests run with the same code with and without MyFilesVolumeFlag. Change the Downloads localized label when MyFilesVolume is enabled to use MyFiles translation, this fixes the label displayed in the breadcrumbs and in the directory tree. Change the ordering of the directory tree from EntryListItem which is used for MyFiles to sort native folders above Linux and Play files volumes. Add iconOverrides to directory tree to allow customization of folders icons based on RootyType and the fullPath, to customize Downloads folder icon when MyFilesVolume is enabled, since Downloads is just a plain folder inside MyFiles volume. Enable a few more tests to run with MyFilesVolume flag enabled that covers the breadcrumbs and the sorting changes. Bug: 873539 Change-Id: Ic46e00404f9295175f97cfd9a91686419636d3af Reviewed-on: https://chromium-review.googlesource.com/c/1338594 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609182}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40c3ad6ce9c4..7eaaf1ff7e99 Created with: gclient setdep -r src-internal@7eaaf1ff7e99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I194f7a4c3e258a44f57acc2ec224a032603f328b Reviewed-on: https://chromium-review.googlesource.com/c/1341557Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I08d71109acb7d75b49b82b36a6a8df0668346c72 Reviewed-on: https://chromium-review.googlesource.com/c/1341558Reviewed-by:
-
Stuart Langley authored
I did a bit of a code search and could not find this being used anymore, so removing it as per the suggested bug. - Added an assert just in case it was being used and my code search skills were not good enough, so we can roll it back. - Closure compile the unit tests while I am at it. Bug: 700272 Change-Id: I5523bbff983fbad3be886319d17278e4673915e3 Reviewed-on: https://chromium-review.googlesource.com/c/1341433Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609179}
-
Sam McNally authored
Bug: 893081 Change-Id: I0d5e38e3bdb7666252e8dc4d943f40af831fdbcb Reviewed-on: https://chromium-review.googlesource.com/c/1341443Reviewed-by:
-
Kent Tamura authored
This is a follow-up CL of http://crrev.com/c/1335069. Bug: 687843 Change-Id: I873dba8174a99c031e34f3e1f32672c6d275aea4 Reviewed-on: https://chromium-review.googlesource.com/c/1337143 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609177}
-
Giovanni Ortuño Urquidi authored
calamity is the original author of BookmarkAppHelper and is working on its replacement. Change-Id: I59ff43a2f0ed250cd597b8ebf238ea73a74676ca Reviewed-on: https://chromium-review.googlesource.com/c/1341669Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609176}
-
John Z Wu authored
Add a return value to indicate if suggestion was allowed. Also fix associated test. Bug: 898990 Change-Id: I22f00cef28dc5a82d431cc49191e956e47cd5e40 Reviewed-on: https://chromium-review.googlesource.com/c/1341148Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#609175}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ieef0d3ae87ccaffd92c6bcd37fac45e73208bac2 Reviewed-on: https://chromium-review.googlesource.com/c/1341649Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609174}
-
Alexey Baskakov authored
Bug: 875698 Change-Id: I6f5b88901728799d81ae493b3dd1bcae0530bc54 Reviewed-on: https://chromium-review.googlesource.com/c/1341286Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#609173}
-
Luciano Pacheco authored
Reduce metadata box width from 320px to 250px when the window is narrow (less than 720px). Reduce quick view main content left/right padding when window is less than 720px wide, from 32px to 4px. Change audio art work to be 100% width and height so it resizes with the window in the same way as video quick-view. These three changes allows for a proper display of audio tag controls when the window is narrow. See screenshot in the linked bug. Change some CSS order, 0.2s to 200ms and -webkit prefix to comply with presubmit. in behaviour. Also checked with video, img and pdf quick views. Test: Checked manually the visual with a window 480px wide, no change Bug: 641629 Change-Id: I4af2c8ea83f9167c6c398c0002ee2df8ec6a5531 Reviewed-on: https://chromium-review.googlesource.com/c/1341439Reviewed-by:
-
Anand K. Mistry authored
The FSP implementation doesn't handle the difference between "not implemented" and "error". Zip archiver doesn't provide any custom actions, but FSP interprets this as an error and that bubbles back to the Files App. BUG=679634 Change-Id: I5b52c64b0d01bd700ea4509d046630396afa756c Reviewed-on: https://chromium-review.googlesource.com/c/1341435Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609171}
-
Alexey Baskakov authored
In WebAppDataRetriver. Bug: 901226 Change-Id: I4db47a0e51c6f6aa89fbfe0fa502e08aeb4036aa Reviewed-on: https://chromium-review.googlesource.com/c/1341285 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Amos Lim authored
SyntaxErrorInOwnersFile: /home/amoseui/Workspace/chromium/src/third_party/WebKit/LayoutTests/OWNERS:4 syntax error: //third_party/WebKit/Tools/OWNERS does not refer to an existing file. third_party/WebKit/Tools/OWNERS was removed in https://crrev.com/c/1338583 Replace third_party/WebKit/Tools/OWERS with third_party/blink/tools/OWNERS as it was included in third_party/WebKit/Tools/OWERS. NOTRY=true NOPRESUBMIT=true Bug: 829697 Change-Id: I3ac65d16964b8dbbbaad9228d37dec88c0577f80 Reviewed-on: https://chromium-review.googlesource.com/c/1341440 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609169}
-
Christopher Lam authored
This rolls uglify-es to a version that has async/await support. Bug: 905927 Change-Id: I76ff7048a42c5915534bdcd43549460a713ea886 Reviewed-on: https://chromium-review.googlesource.com/c/1339085 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#609168}
-
Anand K. Mistry authored
Also replace some waitForFileListChange + explicit files list assert with waitForFiles. This simplifies some tests. BUG=864844 Change-Id: If859f073e25b122dcd3e9eaf536871e5c31b60f2 Reviewed-on: https://chromium-review.googlesource.com/c/1341431Reviewed-by:
-
John Z Wu authored
Bug: 905546 Change-Id: I5063a1827c94da4a8ef8765d35b090608579d648 Reviewed-on: https://chromium-review.googlesource.com/c/1340587Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87aef01b8c18..40c3ad6ce9c4 Created with: gclient setdep -r src-internal@40c3ad6ce9c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic2abaae1842f77e620e0132114400577b24b280e Reviewed-on: https://chromium-review.googlesource.com/c/1341555Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/def9bcecd994..e22505b4f07f git log def9bcecd994..e22505b4f07f --date=short --no-merges --format='%ad %ae %s' 2018-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 778bf09deea4..1c6b26a70f93 (1 commits) Created with: gclient setdep -r src/third_party/skia@e22505b4f07f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@chromium.org Change-Id: I73ca5e284026a3d1de00c7dc9a35cb3f86f35099 Reviewed-on: https://chromium-review.googlesource.com/c/1341551Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c6b26a70f93..fde74c078f77 git log 1c6b26a70f93..fde74c078f77 --date=short --no-merges --format='%ad %ae %s' 2018-11-18 jmadill@chromium.org Vulkan: Apply point size clamping workaround in NV. Created with: gclient setdep -r src/third_party/angle@fde74c078f77 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If59343f229fd9daf097113e7d6faa2c88f713132 Reviewed-on: https://chromium-review.googlesource.com/c/1341553Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0716e836d21..87aef01b8c18 Created with: gclient setdep -r src-internal@87aef01b8c18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8c92f6fab1ce6bf4e1ad50b69ec8cf30d56f9d4f Reviewed-on: https://chromium-review.googlesource.com/c/1341552Reviewed-by:
-
Kent Tamura authored
These directories contain no meaningful files any longer. Bug: 829697 Change-Id: I8ba9f176e25704aa43fa5d08da4fb19809681d1a Reviewed-on: https://chromium-review.googlesource.com/c/1338583Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609161}
-
Fergus Dall authored
Currently we just set the maximum size the disk image can have to 90% of the free space available when crostini is initially installed. There has been talk of finding ways to allow this cap to be increased after installation or overcommitting free disk space to avoid leaving the user with an excessively small disk image. This CL adds a metric recording how large the caps we impose are in practice, which should give us more information about how significant this issue is. Bug: 858815 Change-Id: I2e2d01387a6969114308e21f32b147484c2ed8b1 Reviewed-on: https://chromium-review.googlesource.com/c/1337211 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#609160}
-
Joel Hockey authored
Use label 'Set as wallpaper' rather than 'Set wallpaper'. Bug: 902852 Change-Id: Idcd9e6a669c9de13d9866d2fe0ed59157a8d2155 Reviewed-on: https://chromium-review.googlesource.com/c/1341281Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc3b42193e99..f0716e836d21 Created with: gclient setdep -r src-internal@f0716e836d21 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3b07c09a41fb904dc1563cd404d9c69d61b1debc Reviewed-on: https://chromium-review.googlesource.com/c/1341548Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/778bf09deea4..1c6b26a70f93 git log 778bf09deea4..1c6b26a70f93 --date=short --no-merges --format='%ad %ae %s' 2018-11-18 jmadill@chromium.org Roll Chromium deps. Created with: gclient setdep -r src/third_party/angle@1c6b26a70f93 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2382b3ceb18d9e1b06f4794498785edec23b018c Reviewed-on: https://chromium-review.googlesource.com/c/1341549Reviewed-by:
-
Morten Stenshorne authored
The new LayoutNG test failures are just because LayoutNGBlockFragmentation has no support for column spanners. TBR=kojii@chromium.org Bug: 906385 Change-Id: I7c1dd2be1e46afd7ad6cd9629ccfe98b1b7a5007 Reviewed-on: https://chromium-review.googlesource.com/c/1341528Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#609156}
-
- 18 Nov, 2018 5 commits
-
-
John Z Wu authored
Clients of //ios/web_view would like to understand if a form has a password field in it to distinguish it from other forms. Bug: 905546 Change-Id: I875454eec0339deab63c5fb520ab37aeb6f1fe3c Reviewed-on: https://chromium-review.googlesource.com/c/1341245Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#609155}
-
Stuart Langley authored
This CL introduces the new icons for the Computers grand root and the computers located under it. It re-uses the USB icon for "USB and External Devices". Plumb through the required metadata so we can work out if an entry is a machine root or a external media root, so we can show the different icons. Add a test for this. TODO: Get the USB icon to correctly show in the left hand directory tree. I thought this CL was big enough without including that followup fix. Bug: 884020 Change-Id: I95151444b65f1c0fd680b761fcaa6190105d8fbf Reviewed-on: https://chromium-review.googlesource.com/c/1338581Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65933f30251e..dc3b42193e99 Created with: gclient setdep -r src-internal@dc3b42193e99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic898640a02da9878c9b4f21e1e005918f02232fe Reviewed-on: https://chromium-review.googlesource.com/c/1341496Reviewed-by:
-
Morten Stenshorne authored
We were only using the initial containing block size, which is really just the last-resort fallback according to the spec [1]. This CL introduces clamping the fallback inline size for orthogonal children to the max-block-size of the containing block, as defined in the spec. We still don't pay attention to the fixed size of nearest ancestor scrollport, though. Getting that right will require always passing a constraint space down to all descendants when doing min/max intrinsic size calculation. [1] https://drafts.csswg.org/css-writing-modes-3/#orthogonal-auto Change-Id: I11e4d36a1c31c2bd9b3e9fb0ed65090ba85fa9a0 Reviewed-on: https://chromium-review.googlesource.com/c/1323656 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#609152}
-
Justin Cohen authored
Change-Id: I45d3004df0ff4881329edd8bfb2f72ac6d3aeb24 Reviewed-on: https://chromium-review.googlesource.com/c/1341209 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609151}
-
