GitLab

Fixes gn gen failing on Android when incremental_apk_by_default is true
due to not forwarding additional_apks for monochrome_public_test_ar_apk.

Bug: 863102
Change-Id: If2c168e5e966f3464056131635be84ede8f568e3
Reviewed-on: https://chromium-review.googlesource.com/1135911
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574813}

This patch dismiss a notification when the close button is clicked.

Bug: b/79493568
Test: manual.
Change-Id: I3a17690f9e8f6a3e4178239ff2787618f6500c36
Reviewed-on: https://chromium-review.googlesource.com/1132376Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574812}

DirectoryItem created without a specific NavigationModelItem defaults
to SubDirectoryItem. Change DirectoryItem to check if entry has a
NavigationModelItem to generate the appropriate derived "item" type
from DirectoryItem. In particular, crostini will generate FakeItem.
This fixes issue where crostini wouldn't mount because the trigger
to mount is on FakeItem.

Change FakeItem to have updateSharedStatusIcon as no-op, since it
doesn't have a shared state. This fixes an error where DirectoryItem
calls updateSharedStatusIcon on its sub-items, before FakeItem was
used only as top-level so nobody was calling updateSharedStatusIcon.

Change DirectoryTree to call EntryList to update its sub-directories
since those sub-directories are usually volumes that need to update
themselves.

Add test createFolderNestedDownloads to check that EntryListItem call
to updateSubDirectories doesn't have to be recursive.

Change SubDirectoryItem to add "volume-type-for-testing" in test to
fix tests using this selector when running with My Files enabled if
the item is a volume.

Bug: 857335
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8a579b9c754143d9ba8322aba9014e82a3ac1757
Reviewed-on: https://chromium-review.googlesource.com/1133616
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574811}

AMD's Linux driver crashes when calling glCopyTexImage2D with
GL_PIXEL_UNPACK_BUFFER set to a buffer that hasn't been initialized yet.

Bug: 859998, 850271
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I013892e39c02cfb3abc7079363ea4146915a2ac4
Reviewed-on: https://chromium-review.googlesource.com/1135848Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574810}

This allows the graceful downgrade of the session storage database from
the new servicified database to the pre-servicification database.

R=mek@chromium.org

Bug: 859464,857464
Change-Id: I7049444a9c11b394c704b6a523c51c5b1ce47735
Reviewed-on: https://chromium-review.googlesource.com/1135894Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574809}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc787be40f68..d464e6a80005


Created with:
  gclient setdep -r src-internal@d464e6a80005

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:857193
TBR=mmoss@chromium.org

Change-Id: I19ceae1ab29c387475500c5269913be2f20633fe
Reviewed-on: https://chromium-review.googlesource.com/1135620Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574808}

https://chromium.googlesource.com/angle/angle.git/+log/1617e69e3883..523c5e3122ed


git log 1617e69e3883..523c5e3122ed --date=short --no-merges --format='%ad %ae %s'
2018-07-12 jmadill@chromium.org Vulkan: Suppress PointCoord test on Android.


Created with:
  gclient setdep -r src/third_party/angle@523c5e3122ed

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I7c18581906dd8fec26de2735c6117d58ba3710c9
Reviewed-on: https://chromium-review.googlesource.com/1135221Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574807}

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I915cf5ef2ab6bd23ecbb8fdc31a818f3e4ddbcdc
Reviewed-on: https://chromium-review.googlesource.com/1134436Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574806}

Previously, the tab grid regular tabs panel was being obscured when
the app is backgrounded. This is not correct behavior.
This CL fixes the logic so that the app is only obscured when an
incognito tab is shown (either in tab view or tab grid).

Bug: 852353
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ieb1355601515acd3869a03406b5d9d20ffb61ee3
Reviewed-on: https://chromium-review.googlesource.com/1131917
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574805}

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#
  testType=webkit_layout_tests&
  tests=fast%2Fevents%2Fwheel%2Fwheel-scroll-latching-on-scrollbar.html
shows that this test mostly passes on ToT now.

Bug: 526463
Change-Id: I1f8403bd36799e162dd090aece9f3662d0e0bd13
Reviewed-on: https://chromium-review.googlesource.com/1135431Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574804}

After https://chromium-review.googlesource.com/c/chromium/src/+/1133329
they are no-ops, so no behavior change.

Parts of the CL generated by running

    git grep -l CORE_TEMPLATE_CLASS_EXPORT third_party/blink/renderer/ |
        xargs sed -i 's/CORE_TEMPLATE_CLASS_EXPORT//'

Bug: 859989
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia398e2a4aa511d10577f5ab535c7f54bc3ac47c4
Reviewed-on: https://chromium-review.googlesource.com/1135293
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574803}

Bug: 771597
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I6c56cc352acf0b00bc526dd032d5f9af5bbc2cd2
Reviewed-on: https://chromium-review.googlesource.com/1135873Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#574802}

R=asvitkine@chromium.org

Bug: 863038
Change-Id: I520fac764e1cc1fda499a29a46aff3a663ad9ed1
Reviewed-on: https://chromium-review.googlesource.com/1135963
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574801}

https://test-results.appspot.com/dashboards/
flakiness_dashboard.html#testType=webkit_layout_tests&
tests=http/tests/origin_trials/sample-api-workers.html
shows this has been passsing across all platforms for a long time.

Bug: 711529
Change-Id: I7dc075e73c47c8f70347e8784aad563b01463118
Reviewed-on: https://chromium-review.googlesource.com/1135633Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574800}

1) WebApplicationInfo and web_app.h are unrelated.
2) shell_integration.h is used only in win.

Drive by: Remove some unused includes.

Bug: 860581
Change-Id: Ifd0cec57dd0a54d81487f50fed0de44b487076b6
Reviewed-on: https://chromium-review.googlesource.com/1134639Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574799}

Bug: 758256
Change-Id: Icbd47e057881ec2dc2e2eb1cc733b5dd34326991
Reviewed-on: https://chromium-review.googlesource.com/1130499Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574798}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a2e331aa718..882c91ed97c3


git log 8a2e331aa718..882c91ed97c3 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 jbudorick@chromium.org Revert "gclient: Add support for the branch:revision format."
2018-07-12 ehmaldonado@chromium.org gclient: Add support for the branch:revision format.


Created with:
  gclient setdep -r src/third_party/depot_tools@882c91ed97c3

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:850812,chromium:853032,chromium:850812,chromium:853032
TBR=agable@chromium.org

Change-Id: I0d20f9028843ba043b8adbeee7f10bd0e8ad68f1
Reviewed-on: https://chromium-review.googlesource.com/1135220Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574797}

https://chromium.googlesource.com/catapult.git/+log/66447ba64fcc..8495de1eb482


git log 66447ba64fcc..8495de1eb482 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 dtu@chromium.org [pinpoint] Fix: Use new results path for performance_webview_test_suite.
2018-07-12 dtu@chromium.org [pinpoint] Use old isolate target for jobs before OBBS migration.
2018-07-12 benjhayden@chromium.org Add /api/timeseries2


Created with:
  gclient setdep -r src/third_party/catapult@8495de1eb482

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:862654
TBR=sullivan@chromium.org

Change-Id: Ifb6b94cad8056d5d2b668fe3acde70ea8d00fbeb
Reviewed-on: https://chromium-review.googlesource.com/1135218Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574796}

This removes the layout-tree fixup which kept leading abs-pos & floats
in an inline context in a block context.

This makes an additional 8 tests pass which needed this fix.

The failures in the patch broadly fall into these buckets.
1) Paint invalidation changes. Now that the floats are within the line
   boxes, and the paint invaldation is different. This was likely hiding
   other issues, and we'll need to investigate these.
2) Three crashes which I believe might be fixed by Christian's pending
   min/max fix.
3) One selection and one editing failure.
4) Static position of abs-pos and text alignment failures. (this was
   hiding a larger bug).
5) A few other random failures.

The rebaselines are from new layout-tree dumps, and/or "simple" (i.e.
just name changes) within the paint invalidation dumps.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib5cc99219d31cb11ef18c8f10f7f4e9e0fea8db6
Bug: 734554
Reviewed-on: https://chromium-review.googlesource.com/1132541
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574795}

There is a flashing page when transiting from one cast app to
another cast app or when stopping a cast app. It is caused by redrawing
the webcontent view when destroying the WebContents.

Bug: internal b/79172781 b/79694573

Test: manually tested on Jasper

Change-Id: Ib445301a1f0d2a79cdf5a7dd2652a0666c570f06
Reviewed-on: https://chromium-review.googlesource.com/1132622Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Cr-Commit-Position: refs/heads/master@{#574794}

When we are sized to shrink-to-fit, we can use the cached preferred
logical width when we have one; this patch implements that.

It also changes ComputeInlineSizeForFragment to take a Node, which
simplifies several callers.

While writing this CL, I discovered a missing check for
IsParallelWritingMode in ComputeMinAndMaxContentContribution; that
change is conceptually unrelated to this CL but without it 20 tests
fail.

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id793856d86b12bd46fd7e1bab42541520c7ea031
Reviewed-on: https://chromium-review.googlesource.com/1128195
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574793}

__gCrWeb.fill.setInputElementValue gives the input element focus prior to
setting its value and restores the focus to the previously focused element
afterwards. When a suggestion is selected, the previously focused element
can be <body> which leads to focus events on the body with no useful
form activity information to be sent to the WebStateObservers. This CL adds
a |hasUserGesture| parameter to the FormActivityParams so that the
observers can detect and avoid acting on such events.


Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67f993dd2e7737f3a37f479df4ade1932e94666d
Reviewed-on: https://chromium-review.googlesource.com/1126480
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574792}

Missed some in CL: crrev.com/c/1128325.

Since the UI displays Pages Per Sheet for the N-up setting, and there
was a review comment previously to rename it to pages_per_sheet, so I
am renaming the variable name here.

In printing, 2-up, 3-up, or more generally N-up refers to a page
layout strategy in which multiple pages are composited onto a
single page.

Bug: 775999
Change-Id: Ie605699d64a3ad1fcf2f943378e08065048183e5
Reviewed-on: https://chromium-review.googlesource.com/1135895Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574791}

Tbr: tkent@chromium.org
Bug: 863067
Change-Id: I913685da055480d9cddea105808a16fd7e70facd
Reviewed-on: https://chromium-review.googlesource.com/1135982Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574790}

BUG=857217

Change-Id: I328529cc444ddcadad83eeb4b9aa5ff445844912
Reviewed-on: https://chromium-review.googlesource.com/1125518Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#574789}

Using wpt-import in Chromium ed5e651e.
With Chromium commits locally applied on WPT:
a9045946 "Add a fail-fast for longtask layouttests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21191

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=foolip

No-Export: true
Change-Id: I8cbb857220afec37734ab39cca07d888d7d3c941
Reviewed-on: https://chromium-review.googlesource.com/1135754
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574788}

This is a reland of 3bcc71d8

Now code search should be fine.

Original change's description:
> Add luci-go tool to be fetched via CIPD
>
> Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> need to be updated.
>
> Change analyze to not ignore changes to isolate.
>
> R=tandrii@chromium.org
>
> Bug: 851596
> Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> Reviewed-on: https://chromium-review.googlesource.com/1097623
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569688}

Bug: 851596
Change-Id: Icd227efde182ff844e93dbb692124c1297ab0d7c
Reviewed-on: https://chromium-review.googlesource.com/1135791Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574787}

This is the 2nd CL wiring things up with changes in AutofillClient and BrowserCommands.
There will be one following CL on unit-test and metrics.

Previous CL: 1128569.

For project details, please refer to design doc go/ib-paradise.

This project is to offer users an option to upload chrome local credit
cards to Google Pay server. This bubble UI is the entry point of the entire
flow. It should be anchored to a credit card icon in the location bar and
be shown from it.

Bug: 852904
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5a53f54fda97157cd0d0e7a8fe500728b4733515
Reviewed-on: https://chromium-review.googlesource.com/1134193
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574786}

This includes transition from \n to \0 message separation.

Change-Id: I9bcd5690dc848a6d4206d051443be2082d747824
Reviewed-on: https://chromium-review.googlesource.com/1135939Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574785}

https://pdfium.googlesource.com/pdfium.git/+log/94919f78e1bc..d8df8c35a463


git log 94919f78e1bc..d8df8c35a463 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 hnakashima@chromium.org Fix mark not saved if there are no other changes in the same object.


Created with:
  gclient setdep -r src/third_party/pdfium@d8df8c35a463

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I484bd07bb84691a0abb347821832fae20de8c029
Reviewed-on: https://chromium-review.googlesource.com/1135222Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574784}

Disabling failing tests on Waterfall for Android build bot for Chrome Beta and Stable.

Bug: chromedriver:2503
Change-Id: I75e625d8dd027109c6fd6cd2143d58342c271318
Reviewed-on: https://chromium-review.googlesource.com/1135972Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574783}

The fallback path for the Retina port in blinkpy is adjusted to 10.13
accordingly. And tests are rebaselined.

To keep the CL simple, mac10.12_retina-blink-rel isn't renamed to 10.13
yet. It needs to be renamed later on both src and build sides.

Bug: 863070
Change-Id: Ia1ae7f643e3bffaaa4b8ea133b20b8e8ec06ba5a
Reviewed-on: https://chromium-review.googlesource.com/1135707
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574782}

This patch initializes the rect_ field in SnapContainerData in copy
constructor and move constructor. Fixing a snapping issue in the
composited pages.

We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
test suite so that they are tested with the composited cases.

snap-at-user-scroll-end-manual-automation.js calls
mouseClickInTarget() of pointerevent_common_input.js. That method
invokes programmatic scrolls. The test was written before programmatic
scroll snapping was implemented so it worked at that time. However,
with programmatic scroll snapping implemented, it will always snap
in mouseClickIntarget() and cannot test whether the user scroll snaps.
This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
to avoid invoking programmatic scrolls in the test.

This patch also checks nullptr for layout_box in
ScrollManager::SnapAtGestureScrollEnd() to fix a crash.

Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
Reviewed-on: https://chromium-review.googlesource.com/1132386
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574781}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca73efa2232f..27998f763495


git log ca73efa2232f..27998f763495 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 dgarrett@google.com cbuildbot_launch/InitSdk: Remove DepotToolsEnsureBootstrap.


Created with:
  gclient setdep -r src/third_party/chromite@27998f763495

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2656770fe4d004aa28076691390936561aeb9de0
Reviewed-on: https://chromium-review.googlesource.com/1135616Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574780}

This CL adds MediaStatus and MediaStatusObserver, which are based off of
media_router.mojom.MediaStatus.

Deduplicating the MediaStatus interface from the one in the media_router
namespace will be covered in crbug.com/820277

Bug: 790766
Change-Id: I7a72bb942cb303483d3abb143318269524990f9a
Reviewed-on: https://chromium-review.googlesource.com/1134357
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574779}

Bug: b/110219351
Test: Manual Test
Change-Id: If0499953843c05288eb8d32f3e7927f9901ac8a7
Reviewed-on: https://chromium-review.googlesource.com/1134395Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574778}

FID is becoming a trusted page load metric.

Bug: 862895
Change-Id: Ib434d2f2e203a986c29928909af32427aa0c30c7
Reviewed-on: https://chromium-review.googlesource.com/1134641Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574777}

When S13nServiceWorker is enabled requests/responses directly go
from page to service worker and we don't go through the XSDB check.
As [1] noted, we wouldn't need to check responses because checking
responses would be redundant. This CL make
rossSiteDocumentBlockingServiceWorkerTest.NoNetwork to be skipped
as the test wouldn't be needed when S13nServiceWorker is enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/879348/12/content/browser/loader/cross_site_document_resource_handler.cc#587

Bug: 861644
Change-Id: Id64063995f341733fc8f39c3620c083ab07d0c94
Reviewed-on: https://chromium-review.googlesource.com/1134636
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574776}

This reverts commit 840dc0a7.

Revert "RC: Use Chrome usage time since hidden to decide if tab can be proactively discarded."

This reverts commit 3c279f29.

Revert "RC: Move parts of TabManager::PerformStateTransitions() into helper methods."

This reverts commit 79fba743.

These three CLs stack on top of each other and the first one (
840dc0a7 ,
https://chromium-review.googlesource.com/1133593 ) seems to have
introduced assertion failures and crashes per http://crbug.com/863243 .

Tbr: fdoray@chromium.org
Tbr: sky@chromium.org
Bug: 775644, 863243
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7f02f28de26a8c531e6eebe847120f45b133fd7d
Reviewed-on: https://chromium-review.googlesource.com/1135969Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574775}

This was throwing a runtime error when the unified-consent flag was
enabled.

Bug: 860854
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6e521b813ca160e5434ac066e47f73ecf61b7ba1
Reviewed-on: https://chromium-review.googlesource.com/1134515Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574774}