GitLab

This reverts commit 043b97ce.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Correctly initialize and test SnapContainerData in cc."
> 
> This reverts commit 0fc70abb.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Correctly initialize and test SnapContainerData in cc."
> > 
> > This reverts commit 37061f87.
> > 
> > Reason for revert:
> > The layout tests added by this CL is failing on the CL:
> > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
> > 
> > Original change's description:
> > > Correctly initialize and test SnapContainerData in cc.
> > > 
> > > This patch initializes the rect_ field in SnapContainerData in copy
> > > constructor and move constructor. Fixing a snapping issue in the
> > > composited pages.
> > > 
> > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > > test suite so that they are tested with the composited cases.
> > > 
> > > snap-at-user-scroll-end-manual-automation.js calls
> > > mouseClickInTarget() of pointerevent_common_input.js. That method
> > > invokes programmatic scrolls. The test was written before programmatic
> > > scroll snapping was implemented so it worked at that time. However,
> > > with programmatic scroll snapping implemented, it will always snap
> > > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > > to avoid invoking programmatic scrolls in the test.
> > > 
> > > This patch also checks nullptr for layout_box in
> > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> > > 
> > > Bug: 862406, 862571
> > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > > Reviewed-by: Robert Flack <flackr@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#574781}
> > 
> > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
> > 
> > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Reviewed-on: https://chromium-review.googlesource.com/1136171
> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574825}
> 
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org
> 
> Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136671
> Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574926}

TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org

Change-Id: If9d1e6f73393a7dddc9f8f418606946f070b45be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136612Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574931}

Bug: 853058
Change-Id: I4c816e84ca40c34d723043532c028a13f09e168e
Reviewed-on: https://chromium-review.googlesource.com/1133176
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574930}

BUG=852165
R=mthiesse

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iace7240f1cde3669a319375d0269397d32ea3f22
Reviewed-on: https://chromium-review.googlesource.com/1136576Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574929}

Bug: 846953
Change-Id: I6ee9d0d9557fa981726316994661ac0aad3c9631
Reviewed-on: https://chromium-review.googlesource.com/1135696
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574928}

It turns out that in order to migrate some specific unit tests more smoothly
from URLFetcher to SimpleURLLoader, it is useful to have a method where
indexing of the pending requests list is preserved after a given pending request is handled.

For instance some tests do this:

  request_load_1();
  request_load_2();
  request_load_3();
  (..)
  request_load_n();

  response_request_3();
  response_request_2();
  response_request_n();
  (..)
  response_request_1();

  // do stuff

  request_load_n+1()
  request_load_n+2()
  request_load_n+3()

  response_request_n+2()
  response_request_n+3()
  response_request_n+1()

In the above scenario, it is handy to be able to simulate responses at the original order
requests were made. This CL adds an API that fills this gap.

In practice, this is a preparation for https://crrev.com/c/1114998/.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id9059f3d8f091eabfb21948f074599c180f44128
Reviewed-on: https://chromium-review.googlesource.com/1123236
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574927}

This reverts commit 0fc70abb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Correctly initialize and test SnapContainerData in cc."
> 
> This reverts commit 37061f87.
> 
> Reason for revert:
> The layout tests added by this CL is failing on the CL:
> https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
> 
> Original change's description:
> > Correctly initialize and test SnapContainerData in cc.
> > 
> > This patch initializes the rect_ field in SnapContainerData in copy
> > constructor and move constructor. Fixing a snapping issue in the
> > composited pages.
> > 
> > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > test suite so that they are tested with the composited cases.
> > 
> > snap-at-user-scroll-end-manual-automation.js calls
> > mouseClickInTarget() of pointerevent_common_input.js. That method
> > invokes programmatic scrolls. The test was written before programmatic
> > scroll snapping was implemented so it worked at that time. However,
> > with programmatic scroll snapping implemented, it will always snap
> > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > to avoid invoking programmatic scrolls in the test.
> > 
> > This patch also checks nullptr for layout_box in
> > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> > 
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574781}
> 
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
> 
> Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136171
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574825}

TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org

Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136671Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574926}

I was just doing a cleanup pass on VrShellDelegate, and ended up pulling
on a cleanup thread for VrSupportLevel.

I could split this into multiple changes if necessary, but that sounds
like a waste of time.

Change-Id: I2a5b962b4b7558b64f792c806314a7eb7b2e81ed
Reviewed-on: https://chromium-review.googlesource.com/1135727Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574925}

Duplications metadata and section_sizes from the header of a .size file
inside the data.ndjson file generated by html_report. We don't use this
for anything currently, but we're including it for potential future use.

Bug: 847599
Change-Id: I845dc76e86907db9bc1716fca2fd0233a2598f69
Reviewed-on: https://chromium-review.googlesource.com/1136579Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#574924}

This will be used in an upcoming update to the chrome://conflicts page
to show why a particular module was blocked or caused an incompatibility
warning to be shown.

Bug: 846953
Change-Id: I6e6eab9f4f9805b5fb67a00eb9f5521c006f11ff
Reviewed-on: https://chromium-review.googlesource.com/1135658
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574923}

https://chromium.googlesource.com/angle/angle.git/+log/523c5e3122ed..0cc291365934


git log 523c5e3122ed..0cc291365934 --date=short --no-merges --format='%ad %ae %s'
2018-07-13 lucferron@chromium.org Vulkan: Remove contextVk warnings in syncState


Created with:
  gclient setdep -r src/third_party/angle@0cc291365934

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ib251c243f4aa9f48adea74da35eb0f90fce71480
Reviewed-on: https://chromium-review.googlesource.com/1136393Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574922}

As CL:1132541 removed layout-tree fixup for leading abs-pos &
floats, this patch removes additional support code for
'text-indent'.

Bug: 734554
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1fcb0efda87d1f1abba110b9bbdc36e6d1fd5da0
Reviewed-on: https://chromium-review.googlesource.com/1136268
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574921}

As remote clients trigger setting the primary surface we have to cache the
fallback until the primary is available.

BUG=863083
TEST=none

Change-Id: I3af87f1397bfa4f42f8ab3bb569ef115737f0e91
Reviewed-on: https://chromium-review.googlesource.com/1135524Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574920}

Without this, when building core,
`extern template class CORE_EXTERN_TEMPLATE_EXPORT foo<bar>;`
expands to
`extern template class __declspec(dllexport) foo<bar>;`
in a .h file using CORE_EXTERN_TEMPLATE_EXPORT.

The "extern" means "this template foo is explicitly instantiated with type parameter
bar in a cc file somewhere, so don't bother generating code for it if someone
uses it", while "dllexport" means "we're exporting this template foo with
type parameter bar from the dll we're currently building, so please make sure
to generate code for it". These two contradict each other.

cl emits C4910 and ignores the "extern" -- meaning the code for foo<bar> is
emitted into every translation unit in core including this header.  This
is harmless, but if we were still build with msvc it'd be slower than it needs
to be. (Then again, MSVC says "The extern keyword in the specialization only applies
to member functions defined outside of the body of the class. Functions defined inside
the class declaration are considered inline functions and are always instantiated.",
so maybe it doesn't really have an effect there either since all our templates
have all their functions inline, more or less by necessity.)

clang-cl emits Wdllexport-explicit-instantiation-decl (suppressed by /wd4910)
and ignores the dllexport. There, this patch doesn't change behavior but
the warning is no longer emitted.

(In either case, the cc file then says CORE_TEMPLATE_EXPORT on the instantiation
definition which _does_ export to __declspec(dllexport) and makes sure code for
foo<bar> is generated -- but only in a single cc file.)

So this patch doesn't really change behavior, but it allows us to no longer pass
/wd4910. It also makes CORE_EXTERN_TEMPLATE_EXPORT's behavior match
base/export_template.h and is a step towards maybe using that directly.

See bug comment 0 for more details.

Also remove a few CORE_EXPORTs on template classes. See the CL description of
ttps://chromium-review.googlesource.com/1133329 for why they make no sense,
and if they're there then the EXPORT gets inherited from the template class
to the specialization, triggering the warning again.

Bug: 859989
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1832bdf3d618a72be9b4d78cb435303ca1517677
Reviewed-on: https://chromium-review.googlesource.com/1135937Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574919}

Follow-up to https://crrev.com/c/1134884 now that all jinja_template
targets have proper includes.

Bug: 843562
Change-Id: Ibff629fe42644a21a4c9b1fe94a0e5e822168936
Reviewed-on: https://chromium-review.googlesource.com/1135711
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574918}

The tests were disabled when determined to be flaky (see CLs in the bug below).
The longtask-in-sibling-iframe.html test seems to pass all the time, and the
other is marked as Pass Timeout instead of Skip.

Bug: 796668
Change-Id: I4d297a0ad1dd5bfac6a6f5d1e0eb0aeb03b65935
Reviewed-on: https://chromium-review.googlesource.com/1135913Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574917}

_BulkObjectFileAnalyzerSlave.Run() is a message loop to process
AnalyzePaths() and AnalyzeStringLiterals() executions across threads.
However, jobs are created using lambdas that capture local variables
by closure. This is fragile, since if the local variables are quickly
updated, then the race condition would mutate queued jobs.

This bug is manifested by calling nm.py main() directly on multiple .o
files, using '--multiprocess' switch. This triggers the race condition,
causing only last .o file to be processed

In regular Supersize usage, there is likely sufficient delay so that
the bug is unlikely to happen -- but if it does, then we'd have
something that would be hard to debug!

The solution is to handle messages in a separate function, to isolate
contexts for local variables and closures. We chose this over
functools.partial() for simplicity (no need to chase down individual
cases).

Change-Id: Ie985807a0f19cbb4d11e1236f805da2e0a25b26b
Reviewed-on: https://chromium-review.googlesource.com/1135699
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574916}

BUG=
R=tiborg

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I145aba4f83b9e15b7de055380f45c6ea1ca89c85
Reviewed-on: https://chromium-review.googlesource.com/1135646Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574915}

Bug: 830892
Change-Id: I665849d42d4af63171a972eaa10d9670b23f8899
Reviewed-on: https://chromium-review.googlesource.com/1134220
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574914}

There is a bug that Password Manager might silently update credentials
on successful submit of PSL matched form which doesn't have username.
That's bad, because pretty often that's not right thing. The submitted
form can be SMS verification for example.

This CL simplifies PasswordManager::ShouldPromptUserToSavePassword and
makes it returns true in case of password update as result the update
bubble is always shown when on password update.

Bug: 856543
Change-Id: I7579610e084c456ce22ca568c4f8a63284e63a5a
Reviewed-on: https://chromium-review.googlesource.com/1122134
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574913}

https://skia.googlesource.com/skia.git/+log/ebd37e2af478..4a17501f5bbd


git log ebd37e2af478..4a17501f5bbd --date=short --no-merges --format='%ad %ae %s'
2018-07-13 robertphillips@google.com Revert "update SkColor4f::FromColor() to preserve transfer function"
2018-07-13 robertphillips@google.com Revert "update SkToSRGBColorFilter color management"


Created with:
  gclient setdep -r src/third_party/skia@4a17501f5bbd

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I66ae41fdc6978ad11d50932f0a256ddbc2ba88f2
Reviewed-on: https://chromium-review.googlesource.com/1136392Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574912}

Disabling test ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement
for Android. Test is currently failing for Chrome Beta and Stable.

Bug: chromedriver:2376
Change-Id: Ia5677522deffb7cfa37efe3fdde71634cb686d4f
Reviewed-on: https://chromium-review.googlesource.com/1136219
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574911}

Freeze the iOS kernel version in the user-agent string to be "15E148"
for iOS 11.3 and later for consistency with Safari and to reduce the
fingerprinting surface.

Likewise, reduce OS version granularity from three numbers to two
numbers for iOS 11.3 and later.

BUG=860229

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0165ba4ae9dfd51308e26ebecba1a5dfba3df398
Reviewed-on: https://chromium-review.googlesource.com/1126105
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574910}

The destructor was calling RemoveControllee which calls into observers
which can do arbitrary work. This CL instead calls the observers
asynchronously after the provider host destructor finishes.

This isn't strictly to fix the linked bug but it may help, and will
allow a future patch which destroys object hosts explicitly without
worry that the observer functions were depending on them.

This required several other changes because observers destroying
the caller is a common pattern throughout the code.

Bug: 854993
Change-Id: I051f82a2ae01b36256cd8b6457347135d2863b6b
Reviewed-on: https://chromium-review.googlesource.com/1136163
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574909}

I'm removing the two renavigation metrics for ad frames both because they're not
needed anymore, and because the ad-to-ad metric was buggy, and would always
report that the navigation was to an ad for SubresourceFilter frames such as
those created via ad scripts initially.

Change-Id: I6114b239ed4251cb136e93ff55d724971d46705c
Reviewed-on: https://chromium-review.googlesource.com/1135294
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574908}

Previous versions of functions made private and named
assignFromString and replaceFromString,respectively.
assign wraps assignFromString.
replace wraps replaceFromString.

Bug: 739170
Change-Id: I3fd39a44fed1482f7e07524815297b9eec322b60
Reviewed-on: https://chromium-review.googlesource.com/1134987
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574907}

This animation was added as a way of making the movement that happens
when omnibox suggestions are shown less jarring/annoying. It actually
had the opposite effect. ¯\_(ツ)_/¯

This change is in preparation for a follow-on CL which will remove the
movement entirely.

Bug: 853355
Change-Id: I7ae000f67fd09f3dde7a1583568696c700d19622
Reviewed-on: https://chromium-review.googlesource.com/1135774Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574906}

Using wpt-import in Chromium 2e4de532.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21196

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I5545a034c395afb0b64023acddf7354b1aafc7e4
Reviewed-on: https://chromium-review.googlesource.com/1136372
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574905}

... instead of our own copy. Post-mortem clean up.

BUG=844973

Change-Id: I0e4a69b94c0fd4d3a4fd55ecf43b80435a2e0dc5
Reviewed-on: https://chromium-review.googlesource.com/1136511Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#574904}

We can just directly use the base::Optional value here.

Bug: 791086
Change-Id: I3be79503ea2af4e68cbd751c1391ba651739fa34
Reviewed-on: https://chromium-review.googlesource.com/1135118Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574903}

IdentityManager is the recommended API to access the
Google account used by the user and SigninManager is
deprecated.

Bug: 797929
Change-Id: Ia182b65b4bd764821bd7cb46524b6400b5c35828
Reviewed-on: https://chromium-review.googlesource.com/1128809
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574902}

This reverts commit 356993f4.

Reason for revert: Test timeouts should be fixed by crrev/c/1136033.

Original change's description:
> Revert "Increase the UI paint timeout to 5 seconds."
> 
> This reverts commit 51181f47.
> 
> Reason for revert:
> Speculatively revert for resolving the bot failure on the CI: 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041
> 
> Original change's description:
> > Increase the UI paint timeout to 5 seconds.
> > 
> > This fixes the first browser window appearing blank for a moment. In
> > general, it's better to block than to show the UI in an inconsistent
> > state. Web content should *not* wait this long.
> > 
> > Bug: 849762
> > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73
> > Reviewed-on: https://chromium-review.googlesource.com/1135119
> > Commit-Queue: Sidney San Martín <sdy@chromium.org>
> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> > Reviewed-by: ccameron <ccameron@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574731}
> 
> TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org
> 
> Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 849762
> Reviewed-on: https://chromium-review.googlesource.com/1136131
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574823}

TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org,tzik@chromium.org

Change-Id: Ibfd8e40c1795e0d0f04e7373c66a6b85c9b0c8fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849762
Reviewed-on: https://chromium-review.googlesource.com/1136551Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574901}

Tests that use the fake or in-process context factory won't actually
produce the CALayerParams structure that un-blocks the
CATransactionCoordinator.

When the CATransactionCoordinator's timeout was increased to 5 seconds,
this started causing test timeouts. Disabling it for these tests should
improve the test running time substantially.

Bug: 849762
Change-Id: I05bb2fa07611d6a5b3e65cc2417a6af2111f2dd4
Reviewed-on: https://chromium-review.googlesource.com/1136033
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574900}

This CL changes the position of the FindBar to follow the design of
UI Refresh.

Bug: 805508
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5938fa23fac401f65d1324f06f73087388f66a80
Reviewed-on: https://chromium-review.googlesource.com/1134767Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574899}

This CL changes the layout of the tabCountLabel in the TabGrid button
to position it with autolayout, to prevent the app from freezing when
rotating.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I104b6c17c336e27301e2c991f0524f2fbf9062c9
Reviewed-on: https://chromium-review.googlesource.com/1136446Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574898}

Currently in its own target, and simply dumps the output to a file without
checking

Bug: 863174
Test: out/Default/ntp_render_browsertests
Change-Id: I61ca7714005c3b1d40f354d9f2ca519750843108
Reviewed-on: https://chromium-review.googlesource.com/1135756Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574897}

Change DirectoryTree.updateTreeByEntry_ to call updateItemByEntry on
its sub-items, to fix folder updates within EntryListItem/My Files.

Add MY_FILES_ROOT_LABEL to static translation strings.js for UI tests.

Also change getBreadcrumbsPath result to accept the expectedPath with
or without My Files prefix so tests can pass with/without My Files.

Bug: 857335
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I76b85c75374190403ed1301f4021b5ec725d9d00
Reviewed-on: https://chromium-review.googlesource.com/1136340
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574896}

- The UnifiedConsentService waits until the sync engine is intialized to
make changes to the sync-everything state.
- When the engine is initialized, UnifiedConsentService tries to make
sync-everything match the unfied-consent-given pref.

This change makes sure that the user is in the correct state after
going through the consent bump. (The consent bump is shown before
the sync engine is initialized.)

Before this CL, the sync-everything pref was set to false at startup as
part of the migration. When the user didn't opt into unified-consent
after going through the consent bump, all sync data type toggles would
be off because the sync-everything pref was set to false before the engine
was initialized.

Bug: 819909
Change-Id: I13f56e69197d3469fab1a3259eb6c5cbeb7ffbdf
Reviewed-on: https://chromium-review.googlesource.com/1136442
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574895}

Rename PdfiumPage::ScopedLoadCounter to more appropriate
name PdfiumPage::ScopedUnloadPreventer.

Change-Id: Idd8b7d2b57dbbeac0826ade010b29420956c9062
Reviewed-on: https://chromium-review.googlesource.com/1100834
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574894}

This is in preparation of adding a new echo cancellation type constraint value.

It also clarifies the existing situation.

Bug: TBD
Change-Id: Iae3db2451aea302dd758cc0880649193274afedc
Reviewed-on: https://chromium-review.googlesource.com/1133259Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574893}

Adding chevron with animation to collapse and expand the 2 sections
in the Sync and Google services settings.
To support collapsable section, SettingsCollapsibleItem and
SettingsCollapsibleCell classes are added.

Screenshot:
https://drive.google.com/open?id=1Q82j3xiB7ZYihyyCiS_xalh2AFcCzKTs

Mocks:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3ae6bac383_31_43

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9f75fa1105faaf5e81133a1250a800aa5bfa2136
Reviewed-on: https://chromium-review.googlesource.com/1128758
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574892}