- 14 Aug, 2020 40 commits
-
-
sczs authored
Bug: 1085419 Change-Id: I545fec75952e76b449179f3ec7e676df16db6bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354602Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798188}
-
Samuel Huang authored
This CL adds the script and the target needed to extract Lacros binary / resource size histogram JSON files, which are needed for size monitoring on Chrome Performance Dashboard. Following the methodology of how Android Chrome creates resource size histograms (in //build/android), the key parts are: * Target "resource_sizes_lacros_chrome" to create wrapper script in $OUT_DIR/bin for the main script. This will be called by build bots (hook to be added in follow-up). * lacros_resource_sizes.py to read Lacros build artifact sizes, and to export the result to histogram JSON files. lacros_resource_sizes.py is specialized for Lacros to simplify code. The script accounts for each file in the ZIP file created by the chromeos-amd64-generic-lacros-rel builder, but files can be aggregated by a list and/or by directories. Changes in ZIP file content will require updates to lacros_resource_sizes.py for proper size accounting. Bug: 1106626 Change-Id: I9e42eeb2d54105b47fe37730ba098256bd67de54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346910Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798187}
-
Hazim Mohamed authored
Change NativeFS Drag & Drop from a 'test' runtime enabled feature to an 'experimental' runtime enabled feature. This will enable NativeFS drag and drop by default if enable-experimental-web-platform-features flag is set. Bug: 1080811 Change-Id: Ie3fcc4a28f22a3287cf64607b90e44a0f7767607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356188Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#798186}
-
Jesse Schettler authored
Scanning is no longer going to be a part of the print management app, so remove its code from that app and create a new scanning web app. The empty app can be opened from chrome://scanning and is hidden behind a feature flag that is disabled by default. A subsequent CL will convert the app to a system web app (SWA). Bug: 1059779 Change-Id: I6d64886ea6e32be85cb265f03af173a0262fdc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346922 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798185}
-
James Vecore authored
This CL mocks the IsProfileActive method on the |MockNearbyProcessManager| so we don't need to depended on calling singleton methods in tests and tear down. Change-Id: If690f77baee8ae7e106be2b9ca3a618a058437d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354990 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#798184}
-
Peter Boström authored
This removes UpdateAccelerators() as calls to View::ResetAccelerators() remove dialog buttons' VKEY_RETURN default handlers as well. Removing UpdateAccelerators() works as DialogModelField accelerators are const on construction so they never need to be updated. Bug: 1106422 Change-Id: I1d39cc3d72c6ab043381f8a5c858b1b2ed828558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355290 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6f6dc9f3..b5bfc190 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03ff9e5060573a97e2d332eabe865096d2dcb3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356184Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798182}
-
Thomas Lukaszewicz authored
WebAppFrameToolbarView now invalidates its layout when in fullscreen on Mac, necessary since the frame needs to layout toolbar buttons and remains visible in Mac's fullscreen mode. Fixed a related FindBar bug incorrectly anchoring to the web app frame when the frame was not visible. Bug: 1063304 Change-Id: Ic6ae3ffbeaa32bd548bcf010f3218455073d7afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176603 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798181}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I4750459cbdf3a069c76ca8726ed75c647ac5d387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352894 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798180}
-
Lijin Shen authored
Remove the incorrect assumption which causes consistent assertion failure on multi-instance tab merging. Bug: 1100460, 1080810 Change-Id: Ief512fa3450e0999fdd9588a5ec6b7b6536691d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318446Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#798179}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I593804596b1ed7045636d9a37b19d92d28c9f9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356048Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798178}
-
Hitoshi Yoshida authored
We redesigned fooOr() APIs to be available with some limited types. This CL applies the design as following. - numeric types, IDL enum : T fooOr(T) - (nullable) string types : String fooOr(const String&) - (nullable) IDL dictionary : const T* fooOr(nullptr_t) - (nullable) other IDL definitions : T* fooOr(nullptr_t) - types converted to base::Optional : base::Optional<T> fooOr(base::nullopt_t) Bug: 839389 Change-Id: Iba6ab3812f023a573c428ad96117d78544351121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319090 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798177}
-
Weilun Shi authored
This is a hacky way to fix the regression problem after using the unsafe appendChild. We need to convert the merged doc back and forth to make sure it builds indexes for the later pretty-print. Bug: 1115727 Change-Id: I9225999aec8132e3a069fe79cacc8b1377e99af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354206Reviewed-by:
-
Maksim Sisov authored
These packages are required by the Ozone/Wayland build and will make the step that checks lib deps for chrome binary happy ones the browser is compiled with use_x11 && use_ozone (and ozone_platform_wayland=true, of course (set by default)). Test: built installer step for use_x11 && use_ozone config Bug: 1116384 Change-Id: I724537766815def49bb1269485433f5f4c2c8e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352884Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798175}
-
David Bienvenu authored
This prefixes the PWA AppUserModelId with GetBaseAppId(), to distinguish between different Chrome channels, and different browsers. Existing chrome proxy shortcuts pinned to the taskbar will get migrated by MigrateTaskbarPins on startup - GetExpectedAppId looks at the shortcut commandline and prefixes the expected app id with install_static::GetBaseAppId() if the command line has a kApp or kAppId switch. Bug: 1084751 Change-Id: I91d21069c8313e1e274cbde22ba3d203c288287d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285399 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#798174}
-
Ben Pastene authored
Testing what a description will look like on Milo for a staging builder. Bug: None Change-Id: I22cb9374ba60bdddc24879567d3abe6890eb68dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355275Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798173}
-
Maksim Sisov authored
ChromeOS switched to Ozone quite some time ago and no longer supports non-Ozone/X11. However, when I started to enable use_ozone for is_linux, is_chromeos started to build use_x11 as well, which is not correct. Atm, use_x11 is not built for is_chromeos, because use_ozone = is_chromeos, and this line is just redundant. Bug: None Change-Id: I38ad54cd2febd5a8cce57bc29d092525e07cb715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353265 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008140800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Fa2uaWyUkyfb0dZlfDu9CiOQue9NyZDytZiTrkZdzm0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163673595,b/163960769 Tbr: help-app@grotations.appspotmail.com Change-Id: Ieb24c0a2a545c73ec8d767418daf5faf1f08682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798171}
-
Maksim Sisov authored
Change-Id: I94756241300ec1d90fdc87391ec57c2dabc7b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355951Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798170}
-
Lexi Stavrakos authored
Binds quota_host_ in AddedChangeListener() if not already bound so that StartObserving() can pass the listener back to the browser side. Bug: 1116316 Change-Id: I43e5bed0dc6cb931c3f950faee05b1c1f3e60ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356284Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Cr-Commit-Position: refs/heads/master@{#798169}
-
Scott Violet authored
I was surprised to see occluded_region is in the coordiantes of the root window. This renames Window::occluded_region to make this more obvious. This also removes the SkRegion argument of WindowDelegate::OnWindowOcclusionChanged() as it's unused. I'm doing this as it is unused, but also because the coordinates are rather confusing. BUG=none TEST=none Change-Id: I99910e29e9efb1abf8c7854ae57d3d7dcc636763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336058Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798168}
-
Yuke Liao authored
The goal is to set up a linux-lacros-rel try builder that that runs a subset of test suites from linux-lacros-tester-rel, so this CL creates a virtual CI builder for linux-lacros-rel to mirror. Bug: 1116180 Change-Id: Id9fba6c6c20d7437e4bc8b22b14dcaf28e60ee37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355003Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798167}
-
Joe Downing authored
The current value for this policy indicates that it applies to all ChromeOS versions after M41 however this isn't right as that policy was not read on ChromeOS prior to a change I made in M86. This CL updates the 'supported on' value to match what the product actually supports. BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but setting the correct value causes the policy checker to complain. Change-Id: I50e21fe9828cb54f6cfaa11a9a120c0f4b89ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354593 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#798166}
-
Peter Kotwicz authored
This CL removes the following duplicate resource text_size_medium text_size_large In both chrome/android/feed/core/java/res/values/dimens.xml and ui/android/java/res/values/dimens.xml Removal of duplicate is tracked in crbug.com/1039415 bottom_sheet_min_full_half_distance bottom_sheet_peek_height bottom_sheet_toolbar_shadow_height bottom_sheet_shadow_top_offset In both chrome/android/java/res/values/dimens.xml and components/browser_ui/android/bottomsheet/java/res/values/dimens.xml The chrome/android values should have been deleted as part of https://chromium-review.googlesource.com/c/chromium/src/+/2242112 IDS_CERTTITLE In both chrome/browser/ui/android/strings/android_chrome_strings.grd and components/browser_ui/strings/android/browser_ui_strings.grd android_chrome_strings.grd value should have been deleted as part of https://chromium-review.googlesource.com/c/chromium/src/+/2062418 IDS_LINK_COPIED In both chrome/browser/ui/android/strings/android_chrome_strings.grd and ui/android/java/strings/android_ui_strings.grd The two call sites which use the string - ChromeProvidedSharingOptionsProvider.java and Clipboard.java - display it in a org.chromium.ui.widget.Toast BUG=1093825, 1039415 Change-Id: Iee21c047453eea285dc7b0a114579666bfdd582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355314Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798165}
-
adoneria authored
Currently win-omaha-builder-rel is unstable and hence the new test suite is not getting triggered on win10-omaha-tester-rel. Re-enable running tests the old way so that dev testing is not halted. This gtest suite currently takes ~20s/build to run on bots. Bug: 1109373 Change-Id: Id8fbaae10c06e84066e35f9c492d25c21c646c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354627 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a652f1ab5d7..27391a090ec2 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cda86eff6461 to abe07b943855 (1 revision) 2020-08-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from df859f77dab3 to b4c4da3e7606 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ib5091f5d0873d04e1f8a3c8b521e2af6176b06c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798163}
-
Brian Sheedy authored
Adds the textpb necessary to start creating Android Q emulator AVD files and adds it to the list of configs that the android-avd-packager builder will use. Bug: 1112488 Change-Id: Ia5e628e6208ddb8f7b756237d085eb0c22a297ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354424Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Tibor Goldschwendt authored
The generic module element implements common UI such as the header and border. The module supplies the information required to populate the common UI via its module descriptor. The generic module element also wraps the local module UI previously instantiated. Bug: 1110047 Change-Id: I4c2579bb2c0d3e19b9120c03606ad21d30dea529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336912 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798161}
-
Dominique Fauteux-Chapleau authored
This also makes the legacy features controlling enterprise deep scanning disabled by default. Bug: 1106433 Change-Id: I3a55998a94b95d28e5640e29663d092ee1c8ceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346741Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798160}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I216d1b4cd0237c5f9d957a409552862ce40aafcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352305Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798159}
-
Karel Král authored
Also support |const char* ValueType::data const| in |base::trace_event::ValueToString|. Thus support turning more types into std::string (for instance |IPC::MessageView|). This will provide more detailed information in captured traces. Bug: 1103623 Change-Id: I897325212fe2202f782e6b8c445a404aba71582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356304Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#798158}
-
Fred Mello authored
https://docs.google.com/document/d/1AhuftD0wlY1WfdatReo23d7ydx0KrQfJgrG2Jj_eNmI/ Bug: 1112872 Change-Id: Ice3a5a38c29f26251085109ad36c517762ba1533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346748Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Mark Cogan authored
This Cl extends tab count metrics that expire after M85 to M92. Bug: 1089564 Change-Id: Id6f3cf8b6d14dcb0e99fb1849075de35879c9f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349306 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Hongbo Song authored
According to Chrome crashes, |GetDelegate().GetPageInputTiming().total_input_delay| can be |std::numeric_limits<int64_t>::min()|. I still have not figured out why this value can be negative. But I think this CL can fix the chrome crash. Change-Id: I8709239a9d96d240840f42a4b4ab661738651a53 Bug: 1105665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351379Reviewed-by:
Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#798155}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I2665571ddd1129feeb4da8ce6dd39cd42a5427e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354951 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798154}
-
Camille Lamy authored
This CL extracts CrossOriginOpenerPolicyStatus into its own class. The struct has grown quite big, and it will allow to better encapsulate CrossOriginOpenerPolicy enforcement. This is a preparatory CL for having reports sent on redirects. Bug: 1059303 Change-Id: Ia2d71e0f592296ac6f7a89519068ac84796bf224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353264Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#798153}
-
Luis G Garcia authored
Change-Id: I365392ad1496169e721f2cb2320aea25048c2024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356189Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Luis Garcia <luisggarcia@google.com> Cr-Commit-Position: refs/heads/master@{#798152}
-
Josh Nohle authored
Reorder the |salt| and |encrypted_metadata_key| parameters of NearbyShareEncryptedMetadataKey to align with existing data structures like Advertisement. Then, use NearbyShareEncryptedMetadataKey in GetDecryptedPublicCertificate() instead of accepting the individual |salt| and |encrypted_metadata_key| parameters. Because NearbyShareEncryptedMetadataKey verifies the expected size of the salt and encrypted key, this function signature is less error prone. Fixed: 1115123 Change-Id: I1b22b6e7755b9947355d7ea21cfa661f78cdcf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354555 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/35492ebf6ba2..39fbb307bc9a 2020-08-13 kevinruvalcaba@google.com Added visualization methods for dependency graph. 2020-08-13 lamontjones@chromium.org Build API: Add unit tests for package_indexes. 2020-08-13 mmortensen@google.com query_build_logs: Enable changing DATE sort order to ASC. 2020-08-13 sidereal@google.com packages: Fix manifest update for pinned uprevs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0e12d8bc7657024f32d9aa2b05e8f6f30b186eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355557Reviewed-by:
-
Ben Pastene authored
This reverts commit 6bc98538. Reason for revert: The linked build is 1 week old... The test is green on tot and does not warrant a revert. Original change's description: > Revert "Add several basic gtest & integration tests to new eve-arc-r bot." > > This reverts commit fc9217ef. > > Reason for revert: chrome_all_tast_tests fails on chromeos-eve-arc-r-chrome, > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2498 > > > > Original change's description: > > Add several basic gtest & integration tests to new eve-arc-r bot. > > > > Bug: 1092973 > > Change-Id: I4df191266f28297cf8581f1687de87e336713363 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580 > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796071} > > TBR=martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1092973 > Change-Id: Ibaa98c41af45981b5d195ef41db31d541c4ed5dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355088 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798055} TBR=lanwei@chromium.org,martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because this is a reland. No-Try: true Bug: 1092973 Change-Id: I5bd5c1ef4a789ae141ea8ac3fa55883cfa495c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356047 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
