- 11 Mar, 2020 40 commits
-
-
Chris Cunningham authored
Adds predictors for non-network rebuffer (NNR) and consecutive "bad windows" with high counts of dropped frames. The predictions will be compared against configurable thresholds for determining smooth=true/false for a given MediaDecodingConfiguration. Bug: 1049339 Change-Id: Ia80a9cdc887c070f8156b58a0da64d02318fda40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021950 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749364}
-
Mitsuru Oshima authored
Next step: * Consolidate string grd file into single shortcut_viewer_strings.grd * Remove NewWindowDelegate::ShowKeyboardShortcutViewer and open it directly. * Remove KSV_EXPORT TBR=thakis@chromium.org Bug: 1046624 Change-Id: I86f8aecea09d67d3f1e5ee6234c5c6792bb87063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094760Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#749363}
-
Lukasz Anforowicz authored
This CL takes //content/public/common/context_menu_params.h and splits it into: 1. //content/public/common/*untrustworthy*_context_menu_params.h which contains: - UntrustworthyContextMenuParams - CustomContextMenuContext (type of a field under UntrustworthyContextMenuParams) 2. //content/public/*browser*/context_menu_params.h which contains: - ContextMenuParams Bug: 534561 Tbr: avi@chromium.org Tbr: michaelbai@chromium.org Tbr: tapted@chromium.org Tbr: reillyg@chromium.org Tbr: hidehiko@chromium.org Tbr: shaktisahu@chromium.org Tbr: jinsukkim@chromium.org Tbr: jochen@chromium.org Tbr: mcnee@chromium.org Tbr: knollr@chromium.org Change-Id: Ie6cd124327a423604e33970e099723dedfb8d1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097468 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749362}
-
Patrick Monette authored
The comment was reworded to reduce repetitions and now references worker nodes. Bug: 993029 Change-Id: Id854cbfa86fc8367e98a5057cd002f9c034f67e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094712 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#749361}
-
Moe Ahmadi authored
Change-Id: I9ea3144f0eb659c8b4bd64be364d056267e6d606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099103 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749360}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cbf7f5178da6..066e6a62edcc git log cbf7f5178da6..066e6a62edcc --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Platform: Add IP Address Fields to InterfaceInfo Created with: gclient setdep -r src/third_party/openscreen/src@066e6a62edcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5b9c96ea6b323c5d26917de414353d4946da1833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749359}
-
Jan Wilken Dörrie authored
This change adds a TOO_MANY_PASSWORDS_AND_QUOTA_LIMIT case to the PasswordCheckState enum. This distinction is relevant for users that are unable to use the online Password Checkup to check the passwords saved in their Google account. Bug: 1047726 Change-Id: If8b28c7db8cd9eb10e0de9e1291f3a97627db9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098682 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749358}
-
Piotr Bialecki authored
Invisible input sources should not cause their hit test results to be surfaced to the application. Change-Id: Id6aff539db20981d78d57098b2f0335ca352319b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098852 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#749357}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I291af7ef2ac95083b0f1e4b59e39b7006b7a4ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095199Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#749356}
-
Donn Denman authored
Converts the server-debug setting used for CoCa integration debugging from a single value to a mixin so we can include that at any level of integration. Also adds support for the exact-search bit as a CoCa integration mixin due to lack of support for the additional parameter needed to support this critical feature correctly. The need for this is covered in issue 1060669. BUG=1060669, 1059004, 956277, 985518 Change-Id: I53d5a9acf114e1b84f8821ddf05283eabcd1c30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098489 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749355}
-
Arthur Eubanks authored
Pointers are only guaranteed to be castable to an integer of at least the same size. gperf currently generates something like {(int)(long)&(foo), bar}, Replace it with {static_cast<int>(reinterpret_cast<uintptr_t>(&(foo)), bar}, Bug: 1059231 Change-Id: Ic68a92f8239ec0d51485f17ac5ada91b7617636e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098763Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#749354}
-
Christian Dullweber authored
Screenshot: https://crbug.com/1060118#c9 Bug: 1060118 Change-Id: Ia645b0e54bb959fba678c8acf8c451f7f51c147a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096765Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#749353}
-
Matt Jones authored
The CompositorViewRezsiser has been replaced by ApplicationViewportInsetSupplier, this patch replaces the password utility's usage of it. Bug=1048183 Change-Id: I83b56da97495e78fb0a47d12f3073912a1e7f786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033375 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#749352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 63d2d5bd. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 2594f643 "Fix timeout in update-and-send-events-replacment.html" f9c54ec3 "Support getAnimations() for ShadowRoot" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2b522541f29488295be46821cf97c9bf312ebc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098502Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749351}
-
Jonathan Ross authored
On Linux ATI GPU conformance/more/functions/bindBuffer.html has an occasional GPU crash. Marking as RetryOnFailure to address its flaky nature until root cause can be deteremined. TBR=ynovikov@chromium.org TEST=conformance/more/functions/bindBuffer.html webgl_conformance_gl_passthrough_tests Bug: 1060632 Change-Id: If3483e5edc7c81d352fa708253d16269bee50d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097841Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749350}
-
Brian Sheedy authored
Switches uses of PrintResult in blink_heap_unittests to PerfResultReporter and whitelists it for conversion to histograms before being uploaded to the perf dashboard. Bug: 923564 Change-Id: I5278ed703b2644eac7fbe7b547ed8dcc94eb8e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095926Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#749349}
-
Hailey Wang authored
Used to analyze traces uploaded via Slow Reports when draw intervals above the 99th percentile threshold are detected. Bug: 1055890 Change-Id: I64c97de8ffcd9d288f5c71a85bdd79789f704d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083431Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#749348}
-
Rouslan Solomakhin authored
Before this patch, both "abort" and "can make payment" shared a PaymentEventResultCallback type, which creates a lot of code churn when only one of the event types needs an update. This patch splits PaymentEventResultCallback into CanMakePaymentCallback and AbortCallback. After this patch, changing the parameters for "can make payment" callback will be easier. Bug: 1005076 Change-Id: I0df01a8a8b4551a16f1949d77ffd546df7ea5702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091646 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749347}
-
Garrett Beaty authored
This keeps the scope of changes in a new milestone directory to the vars.star file. Bug: 922150 Change-Id: I82a951a019f24d2795343b41f8c8785852f1e2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098855Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#749346}
-
Gurchetan Singh authored
We'll eventually go back to gbm_bo_map and hopefully get rid of the ifdef statements. BUG=b:145747350 TEST=CQ will test Change-Id: I70f0c4f947886f32cc533cebbdf1649bb62c1e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088796Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749345}
-
rbpotter authored
Also rename to reflect the fact that it is an interactive ui test, not a browser test. Bug: 1026426 Change-Id: I5754be8b906dac488c2ce739e19dd74e9a0ac2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097556 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749344}
-
Ali Juma authored
This CL introduces a SafeBrowsingTabHelper, which is a WebStatePolicyDecider that makes a Safe Browsing query on each call to ShouldAllowRequest(). For now, the result of the Safe Browsing query is ignored; the purpose of making the Safe Browsing query is to exercise the Safe Browsing database code and record UMA (being added in http://crrev.com/c/2087415) for database freshness. This new behavior is behind the kSafeBrowsingAvailableOnIOS flag. Bug: 1049340 Change-Id: I2844637fa9e3c0845fca6355ff1547b9d19252c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092127 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749343}
-
Ben Pastene authored
Bug: 812428 Change-Id: Idb20a957d712b8a1c1faf259fc0fe2d9559005e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098768 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#749342}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f47b27268ea..6c08e4b57d48 git log 8f47b27268ea..6c08e4b57d48 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 marinaciocea@webrtc.org Remove deprecated RtpVideoStreamReceiver constructor. 2020-03-11 danilchap@webrtc.org Cleanup RtcpReceiver tests 2020-03-11 terelius@webrtc.org Scale unacked_data consistently in RobustThroughputEstimator 2020-03-11 mbonadei@webrtc.org Revert "Reland "Whitespace change to kick bots."" 2020-03-11 mbonadei@webrtc.org Reland "Whitespace change to kick bots." Created with: gclient setdep -r src/third_party/webrtc@6c08e4b57d48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If77e55490b9085f777cdb30e0bbd452e6b607dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749341}
-
Josh Nohle authored
After http://cl/299870071, it is possible for CryptAuth to send device metadata packets with empty |encrypted_metadata|. This can happen if a device has not uploaded its metadata encrypted with the correct group public key. Note: We still always expect nontrivial encrypted metadata for the local device. Bug: 951969 Change-Id: If18ddf4bc20559be47a7bf9382ab4fb8fcdd6d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097240 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#749340}
-
Alex Leung authored
Bug: b/149422033 Merge-With: eureka-internal/365398 Change-Id: I67f3440efcfde831f025e57bd92c40d41051077a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063533Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#749339}
-
Philipp Hancke authored
BUG=1052765 Change-Id: I85abe058fa355c8ac08c928d4938e2be86a4b239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098902Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#749338}
-
edchin authored
This unittest started failing soon after landing. Disabling for now. stdout: Crashed during OverlayPresentationContextImplTest.ContainedOverlayUI TBR=kkhorimoto@chromium.org Bug: 1060758 Change-Id: Idf593a9b3ae9858a11610fb07d6036baf7e42496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099083Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749337}
-
Rahul Arakeri authored
This CL fixes an issue where source device changes mid gesture scroll. For example, when user initiates a mousewheel scroll, a GSB and a GSU are dispatched. Before the GSE for mousewheel is dispatched, lets say the user initiates a scrollbar scroll. At this point, a new set of GSB and GSU are dispatched. While the scrollbar scroll is in progress, the deferred GSE from the mousewheel will arrive and end up clearing the scroll and current device (i.e scrollbar) would no longer be able to scroll. To fix this, we maintain state in the InputHandlerProxy that tells which source device is currently in charge of scrolling. If a GSE for a device, other than the one in charge, is dispatched, it is dropped. This state is maintained in currently_active_gesture_device_. It is set on DID_HANDLE or DID_HANDLE_SHOULD_BUBBLE (for cases where a scroll doesn't occur and the event needs to be bubbled) for GSB/GPB and cleared on GPE/GSE. Bug: 1055237, 1060157 Change-Id: Ib42637d33efbdc0cef5e957e095b3015eb5ec2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068743 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749336}
-
Jeff Yoon authored
With ios13-beta-sim running Chromium, this file is no longer needed. MB in its current state will check this file for the GN args, which is undesired. We want it to grab the arguments from the already migrated mb_config.pyl. Downstream has its own definitions for ios13-beta-sim under the internal master groups and are unaffected. Bug: 1055164 Change-Id: I9a995aa9dcc33f6d2f419438c25ef4c7a5bc2f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096881 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749335}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6dc0f63a509c..dafbf121a8b1 git log 6dc0f63a509c..dafbf121a8b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 brianosman@google.com SkVertices: Remove volatile/nonvolatile bit Created with: gclient setdep -r src/third_party/skia@dafbf121a8b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ibadda86f25aa77f8d6790c9f4a9cc92d86522283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749334}
-
Alex Ilin authored
crrev.com/c/2066840 made it impossible to create a Chrome profile outside of the user data directory. Unfortunately, some sync tests rely on this to be able to test two profiles syncing to the same account. This CL adds a command line flag --allow-profiles-outside-user-dir that restores previous behaviour. This flag should be only used as a workaround to fix the sync tests before we have more robust solution. Bug: 1060366 Change-Id: I864a32d5e5d06b029bab1233b33fbb80d27ea137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096769 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#749333}
-
Minyue Li authored
This is a reland of 00134099 Original change's description: > Passing audio capture timestamp to WebRTC. > > Bug: 1054403 > Change-Id: I6349687ce55535a0cdc405db67687d967a04fea1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066777 > Commit-Queue: Minyue Li <minyue@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749126} Bug: 1054403 Change-Id: Icf0af14fd91f2390c933d4b97b8cdbe06dc34ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093446Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Minyue Li <minyue@chromium.org> Cr-Commit-Position: refs/heads/master@{#749332}
-
Martin Kreichgauer authored
Add the WebAuthenticationCrosPlatformAuthenticator feature flag (default disabled). If enabled, it will cause the FidoChromeOSDiscovery to be instantiated for MakeCredential and GetAssertion requests that permit the 'internal' transport. Also move ChromeOS code up into the device namespace like most of the other fido-related code. Its naming is sufficiently unique. Bug: b/144861739 Change-Id: I50bf39c5c7841a7358840968d10a568c6f22ae6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088535 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#749331}
-
Ben Pastene authored
In preparation for removing the N betty bots. Bug: b/150926708 Change-Id: I2c98c09cfff229393b55bae6b916b5b0b81eea1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098843 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#749330}
-
Andrew Grieve authored
Not a future-proof fix, but at least unbreaks it for now by adding libcrashpad_handler_trampoline.so to the ignored list. Crash looks like: Dumping static initializers via dump-static-initializers.py: Traceback (most recent call last): File "../../build/android/gyp/assert_static_initializers.py", line 174, in <module> main() File "../../build/android/gyp/assert_static_initializers.py", line 159, in main ignored_libs, no_initializers_libs) File "../../build/android/gyp/assert_static_initializers.py", line 125, in _AnalyzeStaticInitializers _PrintDumpSIsCount(f.filename, temp.name, out_dir, tool_prefix) File "../../build/android/gyp/assert_static_initializers.py", line 55, in _PrintDumpSIsCount so_with_symbols_path) Exception: ('Unstripped .so not found. Looked here: %s', './lib.unstripped/libcrashpad_handler_trampoline.so') Bug: 939207 Change-Id: I3cf6b9ba52d80a789ec5bcd3b8e1943e0a578a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098773 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749329}
-
David Van Cleve authored
This CL updates the Trust Tokens store to handle a few requirements for token issuance: 1. Allow adding tokens to fail if there is no stored key commitment for the tokens' issuer with value equal to that of the tokens' associated key. (Previously, this was DCHECKED as a precondition, but it's easier to handle within the store.) 2. Add a capacity limiting the number of tokens stored per issuer, and make TrustTokenStore::AddTokens respect this capacity. 3. Add a number-of-tokens-for-issuer getter so clients can check (for instance) if tokens are at capacity without attempting to add a token. 4. Add a cap on the number of issuers allowed to be associated with any given top level origin, and make TrustTokenStore::SetAssociated respect this limit. Bug: 1042962 Test: Expand unittests. Change-Id: I544aa64eeeab1a1f6c777631f1579d2402fd179e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057523Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749328}
-
Francois Doray authored
This is a partial reland of https://crrev.com/c/chromium/src/+/2062692. We confirmed that the CL affected startup metrics on Mac. However, our assessment is that the change is correct (restored tabs are painted before non-restored tabs more often). As a precaution, the original CL is split in two: - Start loading restored tabs earlier (this CL) - Enforce stricter requirements in FirstWebContentsProfiler (http://crrev.com/c/chromium/src/+/2097368) Original change description: On Windows, a visible restored tab starts loading in the following stack, before FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewAura::UpdateWebContentsVisibility ... BrowserView::Show SessionRestoreImpl::ShowBrowser SessionRestoreImpl::RestoreTab SessionRestoreImpl::RestoreTabsToBrowser SessionRestoreImpl::ProcessSessionWindows SessionRestoreImpl::ProcessSessionWindowsAndNotify SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun On Mac, it starts loading in the following stack, after FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewMac::OnWindowVisibilityChanged -[WebContentsViewCocoa updateWebContentsVisibility] -[WebContentsViewCocoa windowChangedOcclusionState:] ... base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run ... ChromeBrowserMainParts::MainMessageLoopRun This prevents FirstWebContentsProfiler from having strict cross-platform expectations about events it observes. With this CL, we ensure that visible restored tab start loading in the following stack on all platforms: content::NavigationControllerImpl::LoadIfNecessary chrome::`anonymous namespace'::CreateRestoredTab chrome::AddRestoredTab ... SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun This allows us to enforce strict cross-platform expectations about events observed by FirstWebContentsProfiler, and also have the nice benefits that navigation isn't delayed until we get a window visibility update during a Mac session restore. Bug: 1035419, 1020549, 1022492 Change-Id: I2964de553c0195ba94a35dc41d17c4a28cc5d05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095970 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#749327}
-
Andrew Grieve authored
What's New (from: https://github.com/google/bundletool/releases): - Skip dex merging in universal APK for devices that have multidex support - Support for keeping resources with given names in the master split. Bug: 1027124, 1033098 Change-Id: I19964fc25fe4db60b77b4e7901afcf5d53020c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098842Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749326}
-
Joshua Berenhaus authored
As per CL 1176109, removing similar sentence with broken link from documentation Change-Id: I62eaf44824b86e0a37374201fa2667b351bb383a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095140 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#749325}
-