- 09 Jan, 2020 40 commits
-
-
Xida Chen authored
This CL adds a gpu pixel test for off-thread paint worklet, which contains basic draw and transform operations. This test serves as preventing regression before shipping off-thread paint worklet, it also ensures that we would get consistent results cross platforms. Bug: 829967 Change-Id: I0597213905630b84391157b134982a19b2215cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992311Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729873}
-
Jimmy Gong authored
- This is another step in removing deprecated printer settings code. - This removes unused dialogs. - Adjusts browser tests to reflect this change. Bug: 1005905 Test: Browser tests Change-Id: I674f4436c4bd17351ff9db2c98e8602dd229ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939957 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#729872}
-
Miguel Casas authored
This CL: - Adds a media_gpu_cros target, with the appropriate folders to watch and directed to the similarly named mailing list. - Takes the chance to rename other similar variables, |media_win| and |vaapi|, so they start with media_gpu_ and are therefore grouped together. Tested it with statements like: ~/p/depot_tools/watchlists.py media/mojo/clients/mojo_video_encode_accelerator.h ~/p/depot_tools/watchlists.py media/gpu/h264_decoder.h to verify it. Change-Id: I790a88bf109137a7119a164fa98b0c754e342f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993143Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#729871}
-
Chase Phillips authored
This change updates the IfModifiedSinceUpgradeParserVersion1 test to use the new cache helper. There's no expected change in functionality for this test. A later CL will add another test to verify the 304 behavior for multiple cached resources (not just the manifest) based on this test's new structure. Bug: 989611 Change-Id: I6984632694efa2fd17d100281416890800e93990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990252 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#729870}
-
Christopher Grant authored
DFMs use explicit JNI registration for both Chrome and Monochrome, but the feature shouldn't care which it's in. Traditionally, JNI registration has been done based on APK targets, but we can also point generation at an Android library. Do that here, and also, tweak the JNI generation template to allow exclusion of transitive deps. For a DFM, this means we can generate JNI only for a module's entrypoints, without pulling in methods from the base module or other unneeded deps. This seems cleaner, and also allows this change to work in component builds. Bug: None Change-Id: I3f3f457815a7e2f06f575f72476cc4c877741c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992694 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#729869}
-
Ben Kelly authored
Bug: 913107 Change-Id: Ie5f5360e8d8c31bbd5b54f739266f5ac0f7038f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991411Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#729868}
-
Mitsuru Oshima authored
This will make window dragging in tablet mode smoother. I'll convert splitview code in a separate CL. Bug:1031927 Test: manually tested on slate. Change-Id: I99f28c6239e31cbd8556ce9e5fd18a01fab50b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987580Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729867}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b92d20526b83..797d74a266bb git log b92d20526b83..797d74a266bb --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@google.com vpython: Specify interpreter to run. Created with: gclient setdep -r src/third_party/depot_tools@797d74a266bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1036606 Tbr: agable@chromium.org Change-Id: I62f011bf09a60291f27f05f110b617a805efacaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729866}
-
Willie Koomson authored
This change adds startTracing()/stopTracing() functions to the autotest API to allow Chrome tracing to be started/stopped from tests. tast test Test: startStopTracing browser test; manually tested by using API in Bug: b:145813709 Change-Id: I636bb8aa4c8bdaaa144ecfd4160a74d43ac404fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989883 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729865}
-
Henrique Nakashima authored
Some SharedPreferences keys used in the past are dynamic. For example, in PaymentPreferencesUtil, keys of the format "payment_instrument_use_count_[type]" are generated. These keys should be usable by SharedPreferencesManager, which will only allow whitelisted keys to be used. This CL creates a whitelist of dynamic key prefixes grandfathered in because they do not follow the format "Chrome.[Feature].[KeyPrefix].*". Bug: 1022108 Change-Id: Iaf9ebf170c339cc4b6d13705d515c97eef9087cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981262 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729864}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/caa32a553682..63dded1f4d55 git log caa32a553682..63dded1f4d55 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 fmayer@google.com Merge "Import what you use." 2020-01-09 fmayer@google.com Merge "Remove dead code." Created with: gclient setdep -r src/third_party/perfetto@63dded1f4d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I853632adb2a8d84b68d19dc0ff0d610727bd7893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993581Reviewed-by:
-
Toby Huang authored
Add tip about @{u} as short-hand for the upstream branch when trying to squash commits using `git rebase -i @{u}`. Bug: None Change-Id: I8b06ccdb976fdfe84eac858d3871fac8f85c2f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993498Reviewed-by:Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729862}
-
Chase Phillips authored
Originally, the AppCacheUpdateJobTest was only concerned with testing that manifest fetches and the headers that were returned matched expectations. That was because the update job tests weren't verifying anything about the fetch process for cached resources. Unfortunately, the 304 response handling for cached resources isn't correct which led to a series of bugs where any cached resource that gets a 304 response can go stale when it could instead have had its lifetime extended by the server. This, coupled with a bug where the request and response times weren't saved at all led to a bunch of corrupt resources in AppCaches. This CL extends the interceptor in AppCacheUpdateJobTest so it can handle monitoring multiple resources, not just a single manifest resource. A later CL will add a test which captures a full cache request and response cycle and monitors multiple resource fetches. Bug: 989611 Change-Id: I486d11f5be187f76e2ab2bf2c0f931c3efa9d7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989002 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Peng Huang authored
In some cases, device can be lost with vulkan. This change supports context lost with non-gl backends. However on Android, the GPU is not running in a separate GPU process, when the context is lost, we need to fallback from non-gl backends to gl or sw backend. It is not implemented right now. Bug: 1038107 Change-Id: I5b1a0c9380c6ad3b995bf602a4e7787360f2993f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980185Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729860}
-
Connie Wan authored
See screenshots in attached bug. Bug: 1027483 Change-Id: Ibce801813480d49ffe856fb095d260c1e56213cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990423 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729859}
-
Nelson Billing authored
- Modify some compiler build definitions to allow symbol_level=2 with Chrome Android 32bit, and to make the build respect use_debug_fission in those cases. - Modify "link" and "solink" tools in Android toolchain so that DWP files can be generated for builds with use_debug_fission. - Modify partitioned_shared_library template/script so that DWP files can be generated for partitioned libs when use_debug_fission is set. Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729858}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a88cab1ad9f2..8d3c0c7a1a60 git log a88cab1ad9f2..8d3c0c7a1a60 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-09 bsalomon@google.com Allow implicit conversion from GrSamplerState::Filter to GrSamplerState Created with: gclient setdep -r src/third_party/skia@8d3c0c7a1a60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: If357d636fa8c7cbc5b2c8b0894486a22e82c31c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993494Reviewed-by:
-
Aaron Gable authored
We support changing Visual Studio versions with the `--ide=vs2017` flag to `gn gen`. The default version is now VS2019. Bug: 1038364 Change-Id: I4de7849aab72bfdf1a4ba7465858816500abf122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984705Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#729856}
-
danakj authored
The terminology was defined around never Showing a RenderWidget to the user and thus not compositing it. However visibility is now split between Widgets (show for compositing) and Views/Pages (show for blink timers/js). And since we plumb this bit through RenderView creation and store it there, it becomes ambiguous. This renames it throughout to be more clear that it is about compositing (ie RenderWidgets) and not about page visiblity. R=avi@chromium.org, dcheng@chromium.org TBR=sky Bug: 419087 Change-Id: Ic95d7c0eae473d5a1adfc369fd88272471f6fafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992343 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729855}
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/browser_view/browser_view_controller_helper_unittest.mm This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 546640 Change-Id: I35aead2dc83bcd3493eb3a8c0ed9ef5064f3a275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991754Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#729854}
-
chrome://omniboxmanukh authored
The copy, paste, download, upload, and batch buttons can be focused with the tab key or mouse clicks. However, pressing 'space' or 'enter' does not activate the focused button. The download, upload, and batch buttons are labels wrapping invisible file inputs. This is required in order to style file inputs. The copy and paste buttons are spans for consistency with the other 3 buttons. Since neither spans nor labels are typically intractable, they don't inherently process 'space' and 'enter' key presses when focused as standard buttons do. This CL explicitly adds a keypress listener to do so. Bug: 1040024 Change-Id: I182a238b8daf3bd25d874b090752173ae1738c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992309 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#729853}
-
Elly Fong-Jones authored
These are all straightforward replacements with DialogDelegate::set_buttons(), where still needed. One of them was specifying OK | CANCEL, which is the default. Bug: 1011446 Change-Id: I8c81468bd50425091f8a330b0d4427a1b4b7874f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992520Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
gogerald authored
The feed header on start surface is using 14sp instead of 12sp as on NTP Screenshot: https://drive.google.com/a/google.com/file/d/1uSperMqiScVC7EeK-UfhqaVJBAHW6Uiq/view?usp=sharing Bug: 1040242 Change-Id: Ic7c2df36c394d1513ff738187c3bb27236c2c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991711 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729851}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/549216f7..f59495dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If43badbf3cac46eec8de6859534a90fa961b190f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993441Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729850}
-
Alison Maher authored
We don't want to print high contrast colors when in forced colors mode. To avoid this, add a check in Document::InForcedColorsMode() to see if we are printing. If so, InForcedColorsMode() returns false, and the printed content is no longer affected by forced colors mode. Bug: 970285 Change-Id: Ia0338834a6fa945a4446e51377014f951d83e997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987985 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#729849}
-
Drew Davenport authored
BUG=b:147124526 Change-Id: Ice46e714bcc1c963fed9419cbcdbf4c8055d3491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993488Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#729848}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d4d40b08d20..ac0b770408f5 Created with: gclient setdep -r src-internal@ac0b770408f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib2b677f83655afd15c7567f020ff8049f6460d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729847}
-
Vladimir Levin authored
This patch makes IsActivatable return the 'correct' value which reflects the current state of either the attribute or the CSS tokens, independently of whether the context is locked. This is a first step to us re-locking the context on visibility changes. In other words, we need to know whether visibility activation is possible even if the context is unlocked R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I5d2f5c520b7864fb726cdda01cc94aec5f8da7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993433Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729846}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 546640 Change-Id: I1277f609c86d6087e8cecbabad9fbaf5172a242f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991713 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#729845}
-
Robbie McElrath authored
Not setting the process type resulted in an assertion error when loading the library before starting the license activity. Test: Start license activity via adb in trichrome and system webview. Bug: 1039896 Change-Id: I4a5400a8cd6d9644eacb92cca14d59197ad50ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990141Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#729844}
-
Tina Wang authored
Change-Id: If54912bc75c11f7606fceb19b27a5dd09055e545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990488 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729843}
-
Dominic Battre authored
The Presentation API allows to create full screen windows for a secondary display. The corresponding WebContents is not associated with the TabStrip and therefore, TabHelpers::AttachTabHelpers() is not called on the WebContents and the autofill drivers are not registered. As per https://chromium.googlesource.com/chromium/src/+/master/docs/tab_helpers.md, we must not reuse TabHelpers::AttachTabHelpers() but be selective about the helpers we attach to each WebContents. Bug: 1038329 Change-Id: I455a11b997a14ed6e7a7a5dad6a47fdada77cedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986827Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#729842}
-
Patrick Monette authored
Bug: 1035555 Change-Id: Ic4e977a2b0aa3952eef1f54bd1ada62bdd07d4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988741 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#729841}
-
Pavel Yatsuk authored
AutoSigninSnackbarController is specific to password_manager. Moving the file closer to the feature that is using it. BUG=1028382 R=ioanap@chromium.org,dvadym@chromium.org,twellington@chromium.org Change-Id: Ia000c1935367386667fec2dd514b7d978b3dde44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992307Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#729840}
-
Miguel Casas authored
This CL removes the #if defined(OS_LINUX) in platform_video_frame_utils since it's unnecessary given [1], and takes the chance to fold the file static function CreateVideoFrameGpu() into its only caller CreatePlatformVideoFrame(). No functional changes intended. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/chromeos/BUILD.gn;l=11 Bug: 1040291 Change-Id: I7559346f032f2cd9b935f767e9bbcb27cdd796f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993402 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#729839}
-
Kenneth Russell authored
This reverts commit b4099b2c. Reason for revert: new image has been triaged in Skia Gold. Original change's description: > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > This reverts commit 7076daa4. > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 > > Original change's description: > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > > > Test was producing a minor image diff, has been triaged. > > > > Bug: 1040202 > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729597} > > TBR=kbr@chromium.org,bajones@chromium.org > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367 > Reviewed-by: sebsg <sebsg@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729736} TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729838}
-
Andrei Polushin authored
The histogram created in r729463 is actually sent with the name that differs from that was registered in `histograms.xml`, so the name in `histograms.xml` file is fixed. In addition, according to my experience, there exist many error codes reported by DPAPI functions CryptProtectData() and CryptUnprotectData(). The codes could be added to `enums.xml` to make the aforementioned histogram more useful. The symbolic names were collected from "winerror.h" and "ntstatus.h". TEST=manually review the histogram OSCrypt.Win.KeyDecryptionError BUG=1036277 Change-Id: I4cc688c2d93447f00776e6d9a171ede733620caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992065 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#729837}
-
Xing Xu authored
Bug: 1036490 Change-Id: I5bd567c66f43e5c8c1b4149e6f05125c7ccf9700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988717 Commit-Queue: Xing Xu <xingx@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#729836}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/73bcece48b0c..368d39c30c42 git log 73bcece48b0c..368d39c30c42 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 bclayton@google.com C++14: Use std::make_unique where possible. Created with: gclient setdep -r src/third_party/swiftshader@368d39c30c42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8d5e3b02a240f8d2a9b822ad17c43fef8646e2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993435Reviewed-by:
-
Ana Salazar authored
During screen rotation we create a copy of the current screen as a layer and stack it in the LayerTree to ease the animation between the screen before and after the rotation. However, some elements in the shelf are obscured by the copied layer. The new layer is set to be transparent as a workaround so it doesn't occlude these elements. Bug: 1025400, 1040279 Change-Id: I003cc149fca54cc821f65bc2f476c57c61d1788b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992689 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729834}
-
