- 01 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/977b68ba4969..8ef8112b0c27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1123915,chromium:897470 Tbr: ramyan@google.com,tmartino@google.com Change-Id: Ibeea08482ba4e396bd6b6ab9e91cf3a98510d65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803584}
-
Sammie Quon authored
Second CL to allow chaining keyboard shortcuts. Follow up to crrev.com/c/2354798 which allows RootWindowDeskSwitch to handle more than two screenshots. This CL fills it out by handling taking third and fourth screenshots and placing them on the animation layer to get a nice smooth continuous animation. Tests in a follow up. Test: manual Bug: 1111445, 1068508 Change-Id: I33f4a26ae794fca799888953b23d617a9f8d0832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376418 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#803583}
-
Michael Hansen authored
The component is the first row on the subpage which displays the device name and the current user's identifier. Screenshot: https://screenshot.googleplex.com/8YdkgsFXnk3k3XH Specs in Carbon: https://goto.google.com/orazy Bug: b:154863194 Change-Id: Ib9d17426315c111c9ba855c22135f7f4c8d2c7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367651 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803582}
-
Dana Fried authored
Bug: 1123809 Change-Id: Ifddfa6447685322b5a1fd3484718ddcdfa754c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387540Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#803581}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 87 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-30. TBR=chromium-metrics-reviews@google.com Change-Id: I2401e8caf4574aaa5bcbd799fdc8c4cd18bf97c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387556Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#803580}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63911905..f2e5606d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I195022cde8453c3fe75d513429678cac33005386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388300Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803579}
-
Regan Hsu authored
* PhoneHub tab in chrome://multidevice-internals includes new feature status dropdown. * Selecting a feature changes the feature on demand. Screenshot: https://screenshot.googleplex.com/7NwZJKgRF4WiNmT Bug: 1106937 Change-Id: Ibb53e737f29f4bc3e209928804cb2d1ff5876a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386322 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803578}
-
Mikhail Khokhlov authored
This metric will be useful to track CPU power optimization work. Bug: b/166816037 Change-Id: I7bbc7018345019db9f307b47ab7a8efbb61bb0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388200Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#803577}
-
Xianzhu Wang authored
This is to investigate performance regression shown on UMA. The disabled logic was introduced in crrev.com/798268 to achieve sharp text in composited layers with fractional transform. It is expected to cause performance regressions for JavaScript animations without will-change:transform. This CL won't cause loss of all crrev.com/798268. A composited layer will be still initially drawn with perfect raster translation if eligible. Only skip update of raster translation on subsequent fractional transform changes. Bug: 1123555 Change-Id: Id220df3f05c9757ea571ea948a529b2e247d7483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386657 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803576}
-
Jordan Taylor authored
These changes were made to bring the implementation into alignment with recent spec changes: https://github.com/w3c/csswg-drafts/pull/5059 Inline spec comments were updated to match as well. Bug: 1081267 Change-Id: Ic4186905377c836b644fed158efe25c369b4cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386339Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803575}
-
Lijin Shen authored
TBR=finnur@chromium.org Bug: 1123848 Change-Id: I14546bae16d5265cbd710cc81d58f49052067945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387201Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#803574}
-
Yngve N. Pettersen authored
When defining lint_suppressions_dep it might not be used when generating some variants of the project for Android. Change-Id: I056865bd030201448c870f259e0b0027c9c71eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385361Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803573}
-
Karel Král authored
Add WARN_UNUSED_RESULT to methods creating |ArrayScope| and |DictionaryScope|. Ignoring results of those functions might lead to closing the given container at unexpected time (right after creation and thus effectively opening and closing an empty container). Bug: 1043616 Change-Id: Ib445716cf0ce669f501d1995904d34761457ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385296Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#803572}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b46300fe4ff..4202dc47a417 2020-09-01 johnstiles@google.com Use erase-remove idiom for dead-variable removal. 2020-09-01 johnstiles@google.com Use erase-remove idiom to remove dead SkSL functions. 2020-09-01 brianosman@google.com Make some internal runtime effect API private If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I5bac484b6e64ff86138155e39ae1c63195179ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803571}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2a2c320dd225f41f998e834aa3781f5a46e0a0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382319Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803570}
-
Thomas Lukaszewicz authored
This CL introduces a new method on the TabSearchHandler that allows the WebUI to notify the backend when the UI has finished rendering and is ready to be shown. This will help in eliminating the current UI stutter that occurs as a result of the UI resizing to fit the dynamically loading content. A follow up CL integrates this API with the TabSearchBubbleView. Bug: 1099917 Change-Id: Ie9679952dc5790d64d61e84840f144b46b66a710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386425Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803569}
-
James Cook authored
The CreateLogFile task needs to be posted with MayBlock(). Bug: none Change-Id: Ie8e356a7255662914d5cdafdcf6696a3eb0123fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388263 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803568}
-
Sylvain Defresne authored
The free function GetFallbackImageWithStringAndColor was defined in the middle of the @implementation part of BaseSpotlightManager which is confusing (as one would expect to see only methods for the class defined there). Move the free function to an anonymous namespace and out of the class @implementation/@interface parts to make it clearer that it is not in fact a class method. Bug: none Change-Id: Iacc46d73217fa8ca65867150f729fcfdf4fed3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388320 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803567}
-
Sylvain Defresne authored
The creation of weakSelf in -updateAllTopSitesSpotlightItems was done in a block passed to -clearAllSpotlightItems to be used by an inner block. This caused the outer block (that is passed to Spotlight) to capture a reference to self. As spotlight execute the block on a background thread, this could cause the instance of TopSitesSpotlightManager to be deallocated on the background thread which is not supported (as BaseSpotlightManager owns a base::CancelableTaskTracker which is sequence-affine). Creating the weakSelf outside of all the block ensure that none of them (either the outer or inner block) capture a strong reference to the BaseSpotlightManager, leaving the full ownership of them to SpotlightManager (and ensuring that they are deallocated when shutdown is called). Bug: 1122991 Change-Id: Ie5e91d3cf29da2ecbca91d2c6c3722cf8b6d0769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388280 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#803566}
-
Chris Hamilton authored
BUG=1096617 Change-Id: I962dcb06fdfbbbdc1494a9e4d3f1b1eeda8dbdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363022Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#803565}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 15 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-30. TBR=chromium-metrics-reviews@google.com Change-Id: I91cc8a0e0a1d5ed39fc97a0f949834db3343bf2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387741Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#803564}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 83dffc51. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0f94f9f22dae5de5c468420e99cbbca8760801e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388000Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803563}
-
dpapad authored
Specifically: - change toolbar height from 48px to 56px - add 16px start/end padding - add 4px padding between toolbar icons - adjust margin and padding in zoom-controls Bug: 1123803 Change-Id: I5f8d7b68e3cc651422de7bc58465c2be35440874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386853Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#803562}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b6c82a149ed8..482642324c4e 2020-09-01 rharrison@google.com Roll 3 dependencies and update expectations (#1133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I8142d20095bc4095fc8bceb33edf7359292db72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803561}
-
Austin Eng authored
Instead of eagerly flushing commands whenever there is a pending callback, enqueue a microtask if one hasn't been already, to perform a flush if it is still needed. This optimization prevents excess IPC flushes. Bug: none Change-Id: Icc48978fdc5d6a54ef61f9379bb4c78d3c75e08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380084Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#803560}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64e4b1e8e2e8..816506e1c600 2020-09-01 primiano@google.com Update CHANGELOG for v7.0 release If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2652d58830aa73f2ef838014c544189aa9e739e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803559}
-
Ben Pastene authored
Like crrev.com/c/2386599, but adds one more that was missed on accident. Bug: 1123300 Change-Id: I0b97c17eb77eab08f45009147183c7ea528ef328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388340 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803558}
-
Tomasz Wiszkowski authored
This has been requested by l10n team. The team also finds annotations better. Screen: http://screen/5hS2fKXfgpmAv7W Original bug: http://b/167229239 Bug: 1096131 Change-Id: I0aac8f04a1cd9fc1d9225410b4af103e59b7c6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386493Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#803557}
-
Stepan Khapugin authored
Removes unused method argument in app state. Bug: none Change-Id: I126ed9d24407311b2bae745ec8af2eec791f10b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386803 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803556}
-
Tommy Martino authored
This reverts commit 33d4fbea. Reason for revert: We believe this is causing the build failure that closed the tree: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17171? Original change's description: > PSM: Support PSM RLWE based message definitions in Chromium > > This CL adds the communication between client and server > for issuing and retrieving determination using PSM. It also > supports the usage of private_membership third_party protos > package in device_management_backend. > > BUG=chromium:1094675 > > Binary-Size: Increase is temporary. > Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131 > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803532} TBR=davidben@chromium.org,emaxx@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org Change-Id: I33f2f9200c3ef24d7c6059d116a88807d83aa0f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1094675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388267Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#803555}
-
Alison Maher authored
When adding fragmented OOF positioned layout results to a multi-col, we need to skip over any spanning fragments. Bug: 1079031 Change-Id: I81fc206b2506a66cb7c701c8ff7c7f6d1f7aa364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357514Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803554}
-
Christopher Cameron authored
The ARM DTK does not specify a PCI device ID for the GPU. Do not fail in this configuration. There are other places, GPUTestConfig::IsValid, for instance, where we explicit allow a zero device ID. Of note is that zero device IDs are allowed only when there is a single GPU. ANGLE's current enumeration code will only enumerate non-PCI devices once no PCI devices are found, so this is will continue to work for the moment. Bug: 1110421, 1121663, 1121672 Change-Id: I7cba1c4d074c291663913b970db3e4085afa0adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387308Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#803553}
-
yiyix authored
In past 2 month, I have moved all tests in blink_perf.canvas to rendering_benchmark. In the future, developers should continue add tests to renderingbenchmark instead to blink_perf.canvas. As this target is no longer needed, I removed it from the code base. Bug: 1077148 Change-Id: Idd8ba7e0a80d3088824c9588be9d022c1455e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367753Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#803552}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a2e6c1a149f4..4953712980a2 2020-09-01 jaebaek@google.com Handle DebugGlobalVariable using DebugInfoNone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I10a752171dc92e134f322e05154e2bbcf885b262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803551}
-
John Smith authored
Themes with images for the ntb use a calculation to determine the right part of the image to use. The ntb was recently moved to a new container (http://crrev.com/c/2333341), which meant that this calculation wasn't getting the right position anymore. Switch to make sure that we get the position of the ntb relative to the tabstrip so it gets the right offset. Bug: 1123195 Change-Id: I917e13bf342f670bc8f50a0b9da6eb84b3691eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382429 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803550}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009010800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hpvLwAWDVkSoL-uwAv5VXFc-bqnqhg1pfnTdcLgdoBAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ie7b211de6ac4c743c37bc415a0f8f99a54fb7776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387953Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803549}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/090049c54646..2bca0089149c 2020-09-01 perkj@webrtc.org Reland "Make cricket::SctpTransportInternalFactory injectable through PeerConnectionFactory Deps" 2020-09-01 zhaoliang.ma@intel.com aec3: Support AVX2/FMA intrinsics in AEC3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe0724fc6a61f7fd505bbfa7dea44ae994be1953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803548}
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0b3d37aeebc855e62b5f42af5d886b53fab1dc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386728 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#803547}
-
Nektarios Paisios authored
Document markers were only exposed on static text nodes in the accessibility tree. However, all other textual information, including word boundaries and character bounds, were exposed on inline text boxes. This patch adds document markers to kInlineTextBox nodes in the accessibility tree. This will enable us to use AXPosition for finding and navigating among misspelling and grammar errors on all platforms, including Mac, Win (IA2 / UIA), and Linux ATK, eliminating all the custom code we currently have for each platform. AX-Relnotes: Misspellings are now announced with VoiceOver on the Mac. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I246ab1f267dd5e01d3920a78f26ec377016b179e Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288789 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803546}
-
Dominik Röttsches authored
Enable the binding by explicitly passing the bind request over to the Java side, otherwise, the registry on the Java side of things is not reached. Requires: https://chromium-review.googlesource.com/c/chromium/src/+/2347916 Bug: 1121589 Change-Id: I75193e1743a0c86cc7fa364c53fd5ec88650d123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375329 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#803545}
-