GitLab

Similarly to the non-blob code path, we should pass a Font arg to
setupPaint() for Mac hinting heuristics.

(See https://codereview.chromium.org/692643006)

BUG=421412
R=eae@chromium.org,jbroman@chromium.org,bungeman@chromium.org

Review URL: https://codereview.chromium.org/692643007

git-svn-id: svn://svn.chromium.org/blink/trunk@185082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eeGNNCIBkX8/5KzPyK2caoUJ

BUG=428348

Review URL: https://codereview.chromium.org/681113006

git-svn-id: svn://svn.chromium.org/blink/trunk@185081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/700843006

git-svn-id: svn://svn.chromium.org/blink/trunk@185080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/684293004

git-svn-id: svn://svn.chromium.org/blink/trunk@185078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185065

BUG=421412
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/711193002

git-svn-id: svn://svn.chromium.org/blink/trunk@185077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185065

BUG=421412
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/710973006

git-svn-id: svn://svn.chromium.org/blink/trunk@185076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL reverts
https://codereview.chromium.org/414503002

The RenderLayer change was wrong and is the cause of the regression.
Unfortunately it's unclear what the path forward is: the ASSERT is
triggering, which means there are some bugs in the code, but it is
caused by having several definitions of paint invalidation container.
Fixing it will require aligning these definitions and it's unclear
which one is right.

BUG=415513

Review URL: https://codereview.chromium.org/706353002

git-svn-id: svn://svn.chromium.org/blink/trunk@185075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=416907

Review URL: https://codereview.chromium.org/710443002

git-svn-id: svn://svn.chromium.org/blink/trunk@185074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No more overloads! The method/methodImpl pattern could be further
collapsed, but this seems like a good start while we work out kinks.

The 'RequestInfo' typedef is from the fetch spec[1], also used in the
ServiceWorker spec[2] to improve readability.

[1] https://fetch.spec.whatwg.org/
[2] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html

BUG=240176
R=bashi@chromium.org,jkarlin@chromium.org

Review URL: https://codereview.chromium.org/700323003

git-svn-id: svn://svn.chromium.org/blink/trunk@185073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431625

Review URL: https://codereview.chromium.org/694773005

git-svn-id: svn://svn.chromium.org/blink/trunk@185072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As CSSValue is no longer web-exposed there's no point testing it.
Removing testing of it will allow us to delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/711043004

git-svn-id: svn://svn.chromium.org/blink/trunk@185071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebAudio spec removed these methods a year ago in favor of start
and stop.  Chrome had removed these methods for
AudioBuffserSourceNodes, but not OscillatorNodes.

BUG=430995
TESTS=dom-exceptions updated

Review URL: https://codereview.chromium.org/707753006

git-svn-id: svn://svn.chromium.org/blink/trunk@185070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It appears that in some cases if an extension object outlives the context it was
created with that context could be GCed out from under it mid-function. This new
pattern enforces a scoped ref count of the associated canvas any time the
context is used by an extension.

BUG=429478

Review URL: https://codereview.chromium.org/687533005

git-svn-id: svn://svn.chromium.org/blink/trunk@185069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This bit is useful for better understanding how the touch sequence that
gave rise to a given scroll sequence was handled by the page. In
particular, this affords the gesture consumer an opportunity to limit
itself if part of the gesture was consumed by the page's touch handler,
e.g., disabling a pull-to-refresh styled overscroll effect if the
initial motion was preventDefault'ed,
https://codereview.chromium.org/679493002.

Chromium-side wiring for this data will be added in
https://codereview.chromium.org/712133003.

BUG=428429

Review URL: https://codereview.chromium.org/690173002

git-svn-id: svn://svn.chromium.org/blink/trunk@185068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch switches the bindings code from using LocalDOMWindow to using
the DOMWindow interface. This will allow OOPIF to add a RemoteDOMWindow
class that remote frames can expose to web content.

BUG=425623

Review URL: https://codereview.chromium.org/683013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Column styling is not used on SVG elements so don't allow it to apply when parsing 
the style.

BUG=399603

Review URL: https://codereview.chromium.org/695423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With https://codereview.chromium.org/175253002 (Blink r182920)
webkit-font-smoothing was broken on Mac. This restores
the previous behavior.

BUG=chromium:421412

Review URL: https://codereview.chromium.org/692643006

git-svn-id: svn://svn.chromium.org/blink/trunk@185065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the same HTMLMediaElement, the WebMediaPlayer can get recreated if src changes.
However, the fullscreen status of the media element will remain unchanged.
On android, we need to know whether the newly created WebMediaPlayer is fullscreen or not.
This is because we need to pass the surface view to the new WebMediaPlayer.
This change calls the enterfullscreen() function to let the WebMediaPlayer to pass the surface.


New layout test will be added once this CL goes in, and the chromium side change is submitted

BUG=428209

Review URL: https://codereview.chromium.org/644153005

git-svn-id: svn://svn.chromium.org/blink/trunk@185064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added blink::WebView::hitTestResultForTap to do so.
blink::WebView::hitTestResultAt will be removed in a follow up patch.

See also https://codereview.chromium.org/475633002/ on how chromium uses it.

BUG=403865

Review URL: https://codereview.chromium.org/470833002

git-svn-id: svn://svn.chromium.org/blink/trunk@185063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All members are reset with the exception of m_frame which is the pointer to
the owner frame. This ensures any residual state is cleared.

  
BUG=270123

Review URL: https://codereview.chromium.org/643143003

git-svn-id: svn://svn.chromium.org/blink/trunk@185062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Scripting is forbidden during Document::detach() now, so these checks
are no longer needed.

BUG=367210,371084

Review URL: https://codereview.chromium.org/710153002

git-svn-id: svn://svn.chromium.org/blink/trunk@185061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also remove extraneous test cache entry.

The result of inserting cache entries that have 'Vary' headers depend on
the order of insertion. Make the test setup step be deterministic so
that the prepopulated cache is always in a predictable state when the
tests are run.

R=jsbell, bkelly@mozilla.com
BUG=428965,374802,429874

Review URL: https://codereview.chromium.org/705343002

git-svn-id: svn://svn.chromium.org/blink/trunk@185060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=mstensho@opera.com

Review URL: https://codereview.chromium.org/715653002

git-svn-id: svn://svn.chromium.org/blink/trunk@185059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This expands the viewport trigger for GPU rasterization to
all viewport tags containing "width=device-width".

This is a generalization of the current trigger (which
additionally requires "minimum-scale=1").

Review URL: https://codereview.chromium.org/696493004

git-svn-id: svn://svn.chromium.org/blink/trunk@185058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a site hasn't set an explicit referrer policy, this runtime-enabled
flag will strip the outgoing header down to an origin. Perhaps this is
a direction we could offer as a choice to users in the future? (Note that this
implementation does not yet effect reditects. That's something to fix later
if/when we want to look more closely at this kind of approach. Nothing worth
doing for a strawman...).

Adding this flag to help evaluate the impact such a change might have.

[1/2] Blink: This patch.
[2/2] Chromium: https://codereview.chromium.org/711033002

BUG=431711

Review URL: https://codereview.chromium.org/684683003

git-svn-id: svn://svn.chromium.org/blink/trunk@185057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Input type number should return SpinButtonRole from blink to chromium side to expose w correct role.

This patch would return SpinButtonRole for input type number.
So, that input type attribute "number" could be exposed similar to ARIA role spinbutton.

This is in accordance with following http://rawgit.com/w3c/aria/master/html-aam/html-aam.html

Note: I am facing problem in rebasing this https://codereview.chromium.org/653433002/ CL. So, I'm continuing the same in this new CL.

BUG=385014

Review URL: https://codereview.chromium.org/718433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yhirano
BUG=431688

Review URL: https://codereview.chromium.org/713943002

git-svn-id: svn://svn.chromium.org/blink/trunk@185055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424507

Review URL: https://codereview.chromium.org/711063002

git-svn-id: svn://svn.chromium.org/blink/trunk@185054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove redundant role HorizontalRuleRole. HR tag should return SplitterRole.

This CL depends on https://codereview.chromium.org/709523002/

BUG=384723

Review URL: https://codereview.chromium.org/703033006

git-svn-id: svn://svn.chromium.org/blink/trunk@185053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yhirano
BUG=431778

Review URL: https://codereview.chromium.org/713073002

git-svn-id: svn://svn.chromium.org/blink/trunk@185052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The fetch spec[1] has the body parameter of the Response constructor
marked optional, and none of the accepted types are nullable. In contrast,
the Blink implementation supported passing null but required an argument.
Make the impl match the spec.

[1] https://fetch.spec.whatwg.org

BUG=412027

Review URL: https://codereview.chromium.org/701683005

git-svn-id: svn://svn.chromium.org/blink/trunk@185051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mac:
In the Mac accessibility API on the summary element (AXDisclosureTriangle), set AXExpanded property to NO.
When the details element content is shown, on the summary element (AXDisclosureTriangle), set theAXExpanded property to YES.

Win:
In the IA2 accessibility API on the summary element (ROLE_SYSTEM_PUSHBUTTON), set STATE_SYSTEM_COLLAPSED.
When the details element content is shown, on the summary element (ROLE_SYSTEM_PUSHBUTTON), set STATE_SYSTEM_EXPANDED.

How hidden nd show states is reflected for details element?
The hidden and shown states of the details element content is reflected by the absence or presence of the open attribute.

This is in accordance with the spec http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#summary-and-details-elements

BUG=282016

Review URL: https://codereview.chromium.org/712983002

git-svn-id: svn://svn.chromium.org/blink/trunk@185050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The promise needs to be created before calling the client for
layout tests to work, it does not seem to be an issue in real code.

BUG=401424

Review URL: https://codereview.chromium.org/709733003

git-svn-id: svn://svn.chromium.org/blink/trunk@185049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/710743005

git-svn-id: svn://svn.chromium.org/blink/trunk@185048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All recorded events are processed at once. It doesn't make sense to process them one by one now that we use tracing backend and there are no live updates while the profile is being recorded.

BUG=361045

Review URL: https://codereview.chromium.org/710113002

git-svn-id: svn://svn.chromium.org/blink/trunk@185047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since union container types have setters rather than assignment operators,
restructure the default value handling to generate a C++ expression that
sets the value instead of the value as a C++ literal expression.

And as a special case, since union containers are null initially, if the
default value is null, generate an empty expression then.

This also fixes a minor bug in the union handling: enum types were not
supported. They should be treated as string types, including conflicting
with any other string type in the union.

BUG=240176

Review URL: https://codereview.chromium.org/713683003

git-svn-id: svn://svn.chromium.org/blink/trunk@185046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

So the problem is that in
StyleBuilderFunctions::applyValueCSSPropertyGridTemplateAreas we were assuming
that we were always getting a fresh RenderStyle, something that is not true,
because we might have overlapping declarations (multipled matching media
queries, user styles, etc).

As that function might be called multiple times, we need to properly regenerate
the list of named grid lines each time the function is called because the
NamedGridLinesMap returned by RenderStyle contains both the old explicit named
grid lines and the old implicit named grid lines.

BUG=427481

Review URL: https://codereview.chromium.org/680063005

git-svn-id: svn://svn.chromium.org/blink/trunk@185045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updates include:
   * Test that fragment part of URLs are ignored.
   * Add Cache.match tests for scenarios that were only being tested
     using Cache.matchAll. Currently all Cache.matchAll tests are
     failing due to the method not being implemented.
   * Add tests for URLs that contain embedded credentials.

BUG=374802,428970
R=jsbell, bkelly@mozilla.com

Review URL: https://codereview.chromium.org/704043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to https://xhr.spec.whatwg.org/, sync XHRs on the main thread
have detrimental effects on the end user's experience and shall be removed.

R=vsevik

Review URL: https://codereview.chromium.org/685203003

git-svn-id: svn://svn.chromium.org/blink/trunk@185043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test is no longer reported as timing out on Windows bots.

R=tyoshino@chromium.org
BUG=409535
NOTRY=true

Review URL: https://codereview.chromium.org/711013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185042 bbb929c8-8fbe-4397-9dbb-9b2b20218538