GitLab

This is a reland of https://codereview.chromium.org/717193003/
which was reverted due to a SyzyASAN failure:
https://code.google.com/p/chromium/issues/detail?id=433357

I'm not quite sure how my patch caused the issue, but reverting it did fix it.
It seems that layout was being triggered during isKeyboardFocusable(), during
which the plugin element itself was destroyed.

This changes that path to only use an existing plugin to check for keyboard
focusability, similar to other code in HTMLPlugInElement.

TEST=fast/plugins/plugin/placeholder-focus.html
BUG=364716

Review URL: https://codereview.chromium.org/732783002

git-svn-id: svn://svn.chromium.org/blink/trunk@185468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185463

BUG=426507
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/734753003

git-svn-id: svn://svn.chromium.org/blink/trunk@185467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The only call site (NativeImageSkia::draw) already does the same work via
GraphicsContext::drawBitmapRect.

BUG=433902

Review URL: https://codereview.chromium.org/729413003

git-svn-id: svn://svn.chromium.org/blink/trunk@185466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185461

BUG=433282,423071
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/729373005

git-svn-id: svn://svn.chromium.org/blink/trunk@185465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Skia on Android (required by /system/etc/fallback_fonts.xml) on L
requires script-based locale names (e.g. zh-Hans and zh-Hant), but
chromium uses region-based locale names (e.g. zh-CN and zh-TW).

Convert region-based locale names to scirpt-based locale names before
passing locale names to Skia.

For now this is for "zh" only.

BUG=433074
TEST=ManualTests/zh-font-fallback-android.html

Review URL: https://codereview.chromium.org/729573003

git-svn-id: svn://svn.chromium.org/blink/trunk@185464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change partly reverts
https://codereview.chromium.org/498773007

This is blocked on fixing issues with incorrect paint
invalidation containers. Those are complicated matters
and require a lot of thinking to get right. It's also not
clear the amount of work required to fix this more fundamental
issue and we need something to fix the regression.

This change doesn't re-introduce the
updateFixedElementPaintInvalidationRectsAfterScroll
logic as it should be taken care by the paint
invalidation logic (or covered by some test case).

BUG=426507

Review URL: https://codereview.chromium.org/714083003

git-svn-id: svn://svn.chromium.org/blink/trunk@185463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/723043004

git-svn-id: svn://svn.chromium.org/blink/trunk@185462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

large enough.

Otherwise, rasterized output of cases such as sprited backgrounds of <img> tags will
have poor quality.

BUG=423834,433282

Review URL: https://codereview.chromium.org/733583003

git-svn-id: svn://svn.chromium.org/blink/trunk@185461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only used/referenced from paint code. Straight-forward code movement, while
renaming RenderBoxClipper -> BoxClipper.

BUG=412088

Review URL: https://codereview.chromium.org/732093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Default orientation for aria scrollbars regarding http://www.w3.org/TR/wai-aria-1.1/#aria-orientation
and http://www.w3.org/TR/wai-aria-implementation/ should be vertical.

It's based on WebKit changeset http://trac.webkit.org/changeset/174217

BUG=

Review URL: https://codereview.chromium.org/723123002

git-svn-id: svn://svn.chromium.org/blink/trunk@185459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=427868
TBR=Xianzhu

Review URL: https://codereview.chromium.org/734713002

git-svn-id: svn://svn.chromium.org/blink/trunk@185458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to land first-letter as a pseudo element I had to set the virtual
test for slimming plaint lineboxcontain/glyph.html to manual rebaseline.
Now that the real rebaselines have landed, this can be set back to ImageOnlyFailure.

BUG=391288
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/734703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a scrollable area is resized, scrollbars will be relocated.
The original scrollbar damage logic doesn't always cover the case
because the properties of the scrollbars may be unchanged.

We could let incremental invalidation cover scrollbars, but just do
a full invalidation if there are any non-composited scrollbars because
incremental invalidation will go away with slimming paint.

BUG=430053
TEST=fast/repaint/scrollbar-invalidation-on-resize.html
TEST=fast/repaint/scrollbar-invalidation-on-resize-with-border.html

Review URL: https://codereview.chromium.org/726123002

git-svn-id: svn://svn.chromium.org/blink/trunk@185456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Set 'column-gap: 0'.
 * Reduced height to 300px to make it more visually obvious that the float
   does not fit in first column.
 * Removed evil twin in newmulticol.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/702853003

git-svn-id: svn://svn.chromium.org/blink/trunk@185455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, vsevik
BUG=431519

Review URL: https://codereview.chromium.org/729453003

git-svn-id: svn://svn.chromium.org/blink/trunk@185454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Text.replaceWholeText() was removed from DOM and has very low usage:
https://www.chromestatus.com/metrics/feature/timeline/popularity/100

Measure Text.wholeText also to see if it is similarly unused.

Discussed briefly with Anne van Kesteren on IRC:
http://krijnhoetmer.nl/irc-logs/whatwg/20141117#l-248

Review URL: https://codereview.chromium.org/730003003

git-svn-id: svn://svn.chromium.org/blink/trunk@185453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- add a "Paint Profiler" link to layer details view when paint
    is selected;
- add a "Paint Profiler" link to Paint event details view;
- collapse Size & Position cells of Layer Details View into
    Size: W x H (at X,Y)
- do not show Paint Count if it's 0 (Paint Count is n/a in Timeline)
- do not force-switch to Paint Profiler tab in Timeline details
    if user explicitly selected other tab.

BUG=

Review URL: https://codereview.chromium.org/726653003

git-svn-id: svn://svn.chromium.org/blink/trunk@185452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the default behavior is to fallback to network, preventDefault()
should cause a network error.

As per spec: https://github.com/slightlyoff/ServiceWorker/issues/51
(see commit f022c3a6d)

Also add a test for calling FetchEvent.respondWith() with a rejected
promise; this must also produce a network error.

BUG=432825

Review URL: https://codereview.chromium.org/733983002

git-svn-id: svn://svn.chromium.org/blink/trunk@185451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/718393006

git-svn-id: svn://svn.chromium.org/blink/trunk@185450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Font mutations during style resolution should happen through the FontBuilder
of the StyleResolverState. Otherwise, the elaborate zooming and min-max
logic in FontSize via FontBuilder is not applied.

It is also good etiquette by AnimatedStyleBuilder to *not* secretly update
the Font without notice, because it makes the 'fontDirty' flag wrong, in
some cases. (Although the worst-case scenario is just an extra Font update).

FontBuilder::setSize used to accept a CSSValue*, and I would assume that's
why RenderStyle::setFontSize was created in the first place. It's easy to
cleanly set a new size on the builder now, though.

R=alancutter@chromium.org
BUG=227545

Review URL: https://codereview.chromium.org/721773002

git-svn-id: svn://svn.chromium.org/blink/trunk@185449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://codereview.chromium.org/731093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moved Preview image for Paint & Images up (just after base timing
info) and Pie Chart down (just before stacks, but after all event-specific
info) in Timeline Details view.

BUG=

Review URL: https://codereview.chromium.org/725903002

git-svn-id: svn://svn.chromium.org/blink/trunk@185447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363976

Review URL: https://codereview.chromium.org/724013003

git-svn-id: svn://svn.chromium.org/blink/trunk@185446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397107

Review URL: https://codereview.chromium.org/722173002

git-svn-id: svn://svn.chromium.org/blink/trunk@185445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397107

Review URL: https://codereview.chromium.org/722173003

git-svn-id: svn://svn.chromium.org/blink/trunk@185444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185431

BUG=427868
TBR=aandrey@chromium.org

Review URL: https://codereview.chromium.org/726313005

git-svn-id: svn://svn.chromium.org/blink/trunk@185443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431697

Review URL: https://codereview.chromium.org/727773002

git-svn-id: svn://svn.chromium.org/blink/trunk@185442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Animation timelines now expose a protocol method to change the playback
rate. This change adds controls on the animations pane to allow all
animations to be paused and for the playback rate to be changed. This
aids debugging of non-trivial web pages with many animations running
simultaneously.

BUG=432368

Review URL: https://codereview.chromium.org/724693003

git-svn-id: svn://svn.chromium.org/blink/trunk@185441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The progress is estimated as event count divided by total buffer size.

BUG=426117

Review URL: https://codereview.chromium.org/722693002

git-svn-id: svn://svn.chromium.org/blink/trunk@185440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/727823002

git-svn-id: svn://svn.chromium.org/blink/trunk@185438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can calculate the pointer to EventTarget from a pointer to
ScriptWrappableBase because EventTarget inherits from ScriptWrappableBase.
So we don't need V8T::toEventTarget function for each V8T.

This CL also reduces the binary size (static data size) of libblink_web.so
packing several flags into bitfields.  The reduced size is about 60kbytes,
which covers http://crbug.com/409852

BUG=409852,235436

Review URL: https://codereview.chromium.org/725163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185405

BUG=391288
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/733783006

git-svn-id: svn://svn.chromium.org/blink/trunk@185436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185367

BUG=429536
TBR=philipj@opera.com

Review URL: https://codereview.chromium.org/731113002

git-svn-id: svn://svn.chromium.org/blink/trunk@185435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To fix crbug.com/126766, we stopped to create snapshot files for non-natvie
files at the beginning of drag operations. It causes files having empty paths
are reaches to input tag, and thus renderer process crashes.

BUG=407568
TEST=FileInputTypeTest.ignoreDroppedNonNativeFiles

Review URL: https://codereview.chromium.org/720403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185402

BUG=423071
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/726373002

git-svn-id: svn://svn.chromium.org/blink/trunk@185433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are the reviews in which the enum values became unused:

CSSStyleDeclarationGetPropertyCSSValue:
https://codereview.chromium.org/717933002

ContentSecurityPolicyReportOnlyInMeta:
https://codereview.chromium.org/554303002

HTMLAppletElementLegacyCall:
https://codereview.chromium.org/719013002

MixedContentImage/MixedContentMedia/MixedContentRaw:
https://codereview.chromium.org/561153002

SVGFontElement/SVGFontInCSS:
https://codereview.chromium.org/656913006

Review URL: https://codereview.chromium.org/732013003

git-svn-id: svn://svn.chromium.org/blink/trunk@185432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=427868
TBR=vsevik

Review URL: https://codereview.chromium.org/732043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431335
R=mkwst@chromium.org
TEST=content_shell doesn't do tabs, so no tests

Review URL: https://codereview.chromium.org/730013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas

Review URL: https://codereview.chromium.org/732013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Contributed by Denis Pravdin <denis.pravdin@intel.com>

Review URL: https://codereview.chromium.org/719853003

git-svn-id: svn://svn.chromium.org/blink/trunk@185428 bbb929c8-8fbe-4397-9dbb-9b2b20218538