- 21 Nov, 2018 40 commits
-
-
Xida Chen authored
602554 was created to fix a containing block issue, stated in crbug.com/764783. Once 602554 is landed, we found that it breaks inbox, as stated in crbug.com/899759, so we landed 607336. Now with 607336 landed, the callsites of "ContainerForAbsolutePosition" are making an assumption that the container will always have a PaintLayer. Apparently, that is no longer true. So this CL reverts both CLs, we should fix chrome's stacking context behavior as stated in crbug.com/903946 Bug: 905914 Change-Id: I15df9041f7b34b525e5bc0875443a46213c2de03 Reviewed-on: https://chromium-review.googlesource.com/c/1344813Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609906}
-
Robert Ogden authored
This came up in UI review, the UI/UX folks would like a space added in. For example: Old: "Updated 6mins ago" New: "Updated 6 mins ago" Change-Id: I5f09f6745334049d4f10befa8c0c3c8d2bef63a5 Reviewed-on: https://chromium-review.googlesource.com/c/1344264Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#609905}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44974e143c90..38332cdcb107 git log 44974e143c90..38332cdcb107 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 orphis@webrtc.org Add RTCP and simulcast support for RTCRtpReceiver::getParameters() 2018-11-20 alessiob@webrtc.org Add output directory option for audioproc_f data dump files. 2018-11-20 jonasolsson@webrtc.org Make RTC_LOG_FILE_LINE use its parameters 2018-11-20 terelius@webrtc.org Remove unused variables in RtcEventAudioXStreamConfig::Copy() 2018-11-20 nisse@webrtc.org Move VideoCodecType from common_types.h to api/video/video_codec_type.h 2018-11-20 mbonadei@webrtc.org Fix threshold in VideoCodecTestLibvpx.ChangeFramerateVP9. 2018-11-20 alessiob@webrtc.org APM audioproc_f: flag for AGC2 adaptive level estimator. Created with: gclient setdep -r src/third_party/webrtc@38332cdcb107 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I404c6b156fffc919b2d8199cdca67467c0b791bc Reviewed-on: https://chromium-review.googlesource.com/c/1344272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609904}
-
Takashi Sakamoto authored
This reverts commit 2a5578c2. Reason for revert: Suspect "compile" failure on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9034 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929285648013221200/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 [1423/1718] LINK ./ash_unittests FAILED: ash_unittests ../../ash/assistant/model/assistant_query_history_unittest.cc:38: error: undefined reference to 'ash::AssistantQueryHistory::AssistantQueryHistory(int)' ../../ash/assistant/model/assistant_query_history_unittest.cc:38: error: undefined reference to 'ash::AssistantQueryHistory::GetIterator() const' ... ash::AssistantQueryHistory_Add_Test::TestBody(): error: undefined reference to 'ash::AssistantQueryHistory::~AssistantQueryHistory()' clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > Support key up/down to move through query history. > > We follow the behavior of linux shell: > (1) Whenever there is a new query, the iterator is reset to the new > query. > (2) Prev of the iterator moves till the first query and stick there. > (3) Next of the iterator can move beyond last query and get an empty > query. > > > Bug: b:119504796 > Change-Id: Iee1247359df78b8e2189fa86c3bd1b8b6ebfe612 > Reviewed-on: https://chromium-review.googlesource.com/c/1334271 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609888} TBR=wutao@google.com,dmblack@google.com,wutao@chromium.org,yileili@google.com Change-Id: I837ff88ed6e3b812e4499b33a2b1344d78d4aebe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:119504796 Reviewed-on: https://chromium-review.googlesource.com/c/1345749Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#609903}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: Ic7edb3635d0fcdc4985b2b2075010f7a3419ba64 Reviewed-on: https://chromium-review.googlesource.com/c/1345245Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#609902}
-
Ethan Xu authored
The purpose of this CL is to refactor the MimeTypeFilter code inside chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java, and modify it for the purpose of mime type filtering in Web share target v2. The specific usage of MimeTypeFilter is to help determine whether a mime type is accepted by a list of accepted mime types. In order to fit the spec for Web Share Target v2, one new additional logic is added. "*/*" is now recognized as accepting all mime types. The Web Share Target v2 CL in reference is: https://chromium-review.googlesource.com/c/chromium/src/+/1271776 Change-Id: I9daa21e4049ae7a153858dc084f64294fe4f2584 Reviewed-on: https://chromium-review.googlesource.com/c/1324096 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#609901}
-
Joel Hockey authored
Fixed file_manager::path_util::ConvertFileSystemURLToPathsInsideCrostini to correctly handle filesystem roots. Added tests for path_util, and crostini unshare. Bug: 907256 Change-Id: I0397c45330dae0d2a88f3d1f83c0a9c3a1349337 Reviewed-on: https://chromium-review.googlesource.com/c/1345379Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609900}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If8333de97ff66d5185840456a6b1e34ca60a3786 Reviewed-on: https://chromium-review.googlesource.com/c/1345392Reviewed-by:
-
Nico Weber authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/13a00f110ef9..da9b2941cbf6 $ git log 13a00f110..da9b2941c --date=short --no-merges --format='%ad %ae %s' 2018-11-20 thakis Revert "Roll libcxx{abi} 2018-11-16 smaier Update clang-format binaries and scripts for all platforms. 2018-10-29 thomasanderson Roll libcxx{abi} Created with: roll-dep src/buildtools Bug: 768586,768983 Change-Id: Ib72e2e4f38b9ed662652a440925ff9260f97abcc Reviewed-on: https://chromium-review.googlesource.com/c/1344293Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609898}
-
David Grogan authored
The spec doesn't address some behavior that has interop. It also doesn't address some related behavior that doesn't have interop. These tests demonstrate both. Hopeful to spur some discussion on https://github.com/w3c/csswg-drafts/issues/3336 Normally a cell with % width is resized based on an initial measure of the table's intrinsic widths. But this is not done when the table is itself inside of a table cell. Engines agree on this but it's not in the specification. Engines don't agree on ignoring this step when the table is inside a shrink-to-fit block. Edge and Chrome perform the step, FF doesn't. Bug: 613705 Change-Id: I4733b693bed754c3924fe357cdc6d5198d7613df Reviewed-on: https://chromium-review.googlesource.com/c/1343530Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609897}
-
Ben Wells authored
Bug: 906961 Change-Id: I6cdb8bbb17772d0b7c733ccccb46198eeec3e936 Reviewed-on: https://chromium-review.googlesource.com/c/1343474Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#609896}
-
Steven Bennetts authored
This CL: * Adds some debug logging to the keyboard code (DVLOG). * Cleans up ChromeKeyboardBoundsObserver and refactors ShouldWindowOverscroll to not be dependent on Ash. * Removes Ash and KeyboardController dependencies from browser tests. These changes are in preparation for enabling the virtual keyboard in SingleProcessMash and should have no impact on existing tests or behavior. Bug: 843332 Change-Id: I8954b4640c39e670350adae776fe14b079e37f36 Reviewed-on: https://chromium-review.googlesource.com/c/1343557 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#609895}
-
Eric Willigers authored
Test that attribute selectors are effective when attributes, ids and class lists change. https://drafts.csswg.org/selectors-4/#attribute-selectors Test adjacent and universal sibling selectors when classes change. https://drafts.csswg.org/selectors-4/#adjacent-sibling-combinators https://drafts.csswg.org/selectors-4/#general-sibling-combinators Based on fast/css/invalidation/class-sibling-universal.html (which Blink still needs as it uses internals to count style recalcs). Change-Id: Ia62516e4ab596ef095d4c26a08f90f8f19e5069b Reviewed-on: https://chromium-review.googlesource.com/c/1345371Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#609894}
-
Yoshifumi Inoue authored
This patch Introduces |NGPaintFragment::RareData()| to reduce memory usage of |NGPaintFragment|. Change-Id: I4b74f1b0cddcbb432b84847173f93bb4c897d08d Reviewed-on: https://chromium-review.googlesource.com/c/1343810Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609893}
-
Etienne Pierre-Doray authored
Revert "[TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc" This reverts commit 50b50793. Reason for revert: Thread restriction is not valid for sampling profier Bug: 907177 Original change's description: > [TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc > > base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more > explicit counterpart. > > It should have been replaced by : > * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. > * base::ScopedAllowSyncPrimitives in non-test files > * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads > that don't allow blocking > The last one is strongly frowned upon but this CL aims to document existing > behavior rather than address it. Owners are encouraged to follow-up by fixing > unnecessary waits and more particularly unnecessary waits > outside-blocking-scope. > > Note: The non-for-testing versions require friend'ing in thread_restrictions.h > but care was taken to add these friends ahead of git cl split (since it wasn't > possible to do a line-by-line associated CL split). > Refer to the top-level CL if necessary : > https://chromium-review.googlesource.com/c/chromium/src/+/1288533 > > Please CQ if LGTY! > > This CL was uploaded by git cl split. > > R=wittman@chromium.org > > Bug: 766678 > Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03 > Reviewed-on: https://chromium-review.googlesource.com/c/1325191 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606478} TBR=wittman@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 766678 Change-Id: Iba9e69ad0923da8d6b6dcc2f89b9e323a30894d6 Reviewed-on: https://chromium-review.googlesource.com/c/1344577 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609892}
-
Charlie Harrison authored
The only behavior change here is that |managed_by_user| is now consistent. It is the source == USER && CanSetNarrowestContentSetting. Some UIs (like plugins), were only looking at the setting source. Bug: None Change-Id: Ibf55f3f9fea3576745a0be95fa25a1b18a5c3c92 Reviewed-on: https://chromium-review.googlesource.com/c/1344192Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#609891}
-
Joel Hockey authored
Bug: 907256 Change-Id: If223956a330497b4b0318f91e4ea6c941d94b5aa Reviewed-on: https://chromium-review.googlesource.com/c/1345377 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#609890}
-
Yoshifumi Inoue authored
This patch makes |TextIteratorTest| to run on both legacy and ng layout tree to catch ng failure earlier for helping layout ng release. Change-Id: I10e98c10d29082fc7de4afd040cb9d93b370e854 Reviewed-on: https://chromium-review.googlesource.com/c/1343872Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609889}
-
yileili authored
We follow the behavior of linux shell: (1) Whenever there is a new query, the iterator is reset to the new query. (2) Prev of the iterator moves till the first query and stick there. (3) Next of the iterator can move beyond last query and get an empty query. Bug: b:119504796 Change-Id: Iee1247359df78b8e2189fa86c3bd1b8b6ebfe612 Reviewed-on: https://chromium-review.googlesource.com/c/1334271 Commit-Queue: Yilei Li <yileili@google.com> Reviewed-by:Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609888}
-
Anne Lim authored
New StrikeDatabase class for the StrikeDatabase v2. It shares the same existing ProtoDatabase as legacy_strike_database.h/cc which is used as persistent storage, as well as an in-memory cache. Virtual functions are also introduced, which are to be implemented per project. Bug: 884817 Change-Id: I48c38b17274ec440afd593dc48223b97c2b2d90e Reviewed-on: https://chromium-review.googlesource.com/c/1334832Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#609887}
-
Andrey Lushnikov authored
When renderer navigates, all worker agent hosts will be eventually disposed. In order to keep protocol determenistic, this patch proactively detaches all worker sessions on renderer navigation. R=dgozman Change-Id: Ief0fe3db90eade9e12baa3cbe4f6b78785c60e4f Reviewed-on: https://chromium-review.googlesource.com/c/1345529 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609886}
-
Min Chen authored
Currently we can see AUTO_HIDE_SHOWN shelf can be hidden when tap inside some of the apps, e.g, chrome browser. That is because of the window hierarchy, stacking changes or set bounds for the child windows. Tap inside of some the apps like "Files" or Wallpaper can't hide the AUTO_HIDE_SHOWN shelf since we don't have the related logic for TAP event. This cl adds the logic that tap outside of the AUTO_HIDE_SHOWN shelf to hide it. Bug: 882059, b/119322652 Change-Id: I8fc5b6d06a885a7b77280cbf86de4d830c04a296 Reviewed-on: https://chromium-review.googlesource.com/c/1343511 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609885}
-
Ted Choc authored
When images are loaded async, it was updating the existing list of property models. The property model for the list was doing an equality check for the list. Two separate list instances with the same contents (in this case, the exact same objects), then the equality check will pass. To overcome this, we allow skipping the equality checks for object properties. BUG=898522 Change-Id: I60483d3365217b5da5d0a2cf052ac888bac1a522 Reviewed-on: https://chromium-review.googlesource.com/c/1345510Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609884}
-
Aga Wronska authored
Call CloudPolicyService::RefreshPolicy instead of CloudPolicyClient::FetchPolicy in CloudPolicyRefreshScheduler, so there is a common path for in session policy fetches. It allows to add additional logic for policy fetch to CloudPolicyService. It is a part of larger change: passing credentials with child user policy fetch. Bug: 839025 Test: CloudPolicyRefreshSchedulerTest + manually Change-Id: I3f5b497ef28179d3d181d45b30bf11b4a4f3fcac Reviewed-on: https://chromium-review.googlesource.com/c/1339099 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#609883}
-
Simon Que authored
Since increasing to 20% on 2018-11-16, there is still no saturation of bots: https://screenshot.googleplex.com/VRSaKSXnSvs.png Bug: 855319 Change-Id: I417a8a3ac573c8b728eaca322186eda9b0b8602b Reviewed-on: https://chromium-review.googlesource.com/c/1341442 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#609882}
-
Jinsuk Kim authored
This CL moves the methods handling InProductHelp UI in Tab to ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and Tab page load observing mechanism. Now the methods are handled by ChromeTabbedActivity only. Bug: 889682 Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1 Reviewed-on: https://chromium-review.googlesource.com/c/1272779 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#609881}
-
chrome://flagsAdrienne Walker authored
The internal settings still exist, and we haven't really needed to adjust these from flags for some time. Change-Id: I74823663e497832f8accb5c0d922cf9ed017e997 Reviewed-on: https://chromium-review.googlesource.com/c/1342937Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#609880}
-
Noel Gordon authored
No change in test behavior, no new tests. Bug: 905934, 847729 No-try: true Change-Id: Ic1a9b352260670b643bb60cae6cfb5483f80ea70 Reviewed-on: https://chromium-review.googlesource.com/c/1345374 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609879}
-
John Z Wu authored
//ios/web_view clients would like to know if a suggestion is for a password form or not. Change-Id: I557857494d3e7889713f2fe8462a37a215111fbc Reviewed-on: https://chromium-review.googlesource.com/c/1345423 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609878}
-
Becky Zhou authored
+ Use PropertyModel for all modal dialogs + Remove ModalDialogView.Params + Fix cancel on touch outside not being able to cancel on some area for app modal dialogs Bug: 899318 Change-Id: Ib3f9160d57483ade1aa54f1522aa7fe73eaa4212 Reviewed-on: https://chromium-review.googlesource.com/c/1344435 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
edchin authored
Test Case '-[FullscreenTestCase testLongPDFScroll]' started. ../../ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm:207: error: -[FullscreenTestCase testLongPDFScroll] : Exception: AssertionFailedException Exception Name: AssertionFailedException Exception Reason: ((base::test::ios::WaitUntilConditionOrTimeout( kWaitForToolbarAnimationTimeout, condition)) is true) failed Exception Details: Toolbar was visible Bundle ID: org.chromium.gtest.generic-unit-test Stack Trace: ( 0 EarlGrey 0x0000000124b14446 -[GREYDefaultFailureHandler handleException:details:] + 1302 1 ios_chrome_ui_egtests 0x000000010e983a30 +[ChromeEarlGreyUI waitForToolbarVisible:] + 1952 2 ios_chrome_ui_egtests 0x000000010ea3cc9c -[FullscreenTestCase testLongPDFScroll] + 780 TBR=gambard@chromium.org, kkhorimoto@chromium.org, justincohen@chromium.org Change-Id: Id9d1a6e9c3a3a047e9241cf5a1838721899a4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1345420Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609876}
-
Nate Fischer authored
This connects the cache settings from AwSettings to the network service code path, which fixes 2 related tests. This creates the net_helpers file to share common logic between both the network service and legacy code paths. Right now, this only contains WebView's logic to translate WebView cache settings into net layer load_flags. Bug: 904890 Bug: 893573 Bug: 893574 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f=ClientOnReceivedError*Test#test*CacheMiss Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic2d62dfedd5f0c1ddfa04469454aea7d43df9373 Reviewed-on: https://chromium-review.googlesource.com/c/1339720Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609875}
-
Geoff Lang authored
Replace '<' with '<=', this was not found until recently because it required that the result was being copied into the exact last element of a much larger buffer. BUG=874402 TBR=piman@chromium.org Change-Id: Ib35552f331f0d9f1f1d19aa4914d1d14ec75ee2d Reviewed-on: https://chromium-review.googlesource.com/c/1344214 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609874}
-
Jonathan Metzman authored
Call CoInitiliazeEx once before fuzzing so that CoCreateInstance succeeds. Change-Id: I6e6c1fed60da7967a2294b3d781c2d1bd468bbbb Bug: 904877 Reviewed-on: https://chromium-review.googlesource.com/c/1342620Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609873}
-
Kevin Strohbehn authored
Bug: 902957 Change-Id: Ie0ddf3d189bcedd7a7e6f40a4b5db919b8554878 Reviewed-on: https://chromium-review.googlesource.com/c/1332427Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#609872}
-
Kristi Park authored
When checking for updated tiles, wait for the tiles to reload instead of opening another NTP. Also fix the incorrect removeEventListener in local_ntp_test_utils. Bug: 903265 Change-Id: If48fac6eced637721c6b199492db2edee06370c4 Reviewed-on: https://chromium-review.googlesource.com/c/1334807 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609871}
-
Lukasz Anforowicz authored
Before this CL, after RemoteFrame is detached, it would be kept alive by FocusController::focused_frame_. Before this CL, LocalFrame::DetachImpl would clear FocusController::focused_frame_ if needed. After this CL this is done from Frame::Detach (and so covers both LocalFrame and RemoteFrame). Before and after this CL, FocusController::focused_frame_ stores either a LocalFrame or RemoteFrame, but FocusController::FocusedFrame only exposes LocalFrame. This CL preserves this approach of handling RemoteFrame internally within FocusController, by introducing FocusController::FrameDetached(Frame* detached_frame) method which can directly compare |detached_frame| with |focused_frame_| (without going through local-vs-remote considerations and/or casts). Bug: 906809 Change-Id: I47f3a725db87f3a887ad96c7a4739b4fc02496ed Reviewed-on: https://chromium-review.googlesource.com/c/1344254 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609870}
-
edchin authored
Change-Id: I0e9a96d8129aee20610eb3dcd7c82a75e854f40a Reviewed-on: https://chromium-review.googlesource.com/c/1345530Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609869}
-
Sadrul Habib Chowdhury authored
Remove DisplayScheduler.ShouldNotDraw.* UMA metrics, since it is no longer needed anymore. The collected metrics shows that almost ~100% of the time, the reason for not drawing is DrawNotNeeded, and almost never any of the others. BUG=899956 Change-Id: Ibe775a26936de910ad33745dad0e7e1e4369d429 Reviewed-on: https://chromium-review.googlesource.com/c/1343566Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#609868}
-
Noel Gordon authored
unittest_util is a js_library: it is not js_unittest, best I can tell. No change in behavior, no new tests. Bug: 905934 No-try: true Change-Id: Ib508c7380ca7babf970895ce7d69545d219daaa6 Reviewed-on: https://chromium-review.googlesource.com/c/1345370 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
