- 29 Jul, 2020 40 commits
-
-
Ken Rockot authored
This is a reland of 596311e0 Original change's description: > [WebLayer] Use NetErrorAutoReloader > > Navigations which fail with network errors may attempt to > auto-reload in some cases, in order to more seamlessly recover > from transient failures. > > This behavior was previously implemented renderer-side and copied > verbatim from Chrome. The Chrome implementation has been moved > browser-side (see bug for why) and also made into a reusable > component. > > This changes WebLayer to use the same component implementation > and deletes all the corresponding renderer logic. > > Fixed: 1098578 > Change-Id: I10c337abcae36f64be47f31b89e36c7393989077 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311371 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792028} Tbr: mmenke@chromium.org Change-Id: I4dd0aaef47650d14c52b6b2ddcf35cee27d2ef35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324934 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#792826}
-
Sophie Chang authored
Bug: 1108610 Change-Id: I427b51c39b8b62a33ad262d8b8e21b864709bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324995 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792825}
-
Mike Dougherty authored
This reverts commit 1fbe4cc4. Reason for revert: Xcode 12 beta 3 takes more than 25 seconds to start loading content in WKWebView. Original change's description: > Roll bots to Xcode 12 beta 3 > > Bots rolled with the following script: > git grep -l '12a6163b' | xargs sed -i '' -e 's/12a6163b/12a8169fg/g' > > to update: > infra/config/lib/builders.star > infra/config/subprojects/chromium/master-only/ci.star > infra/config/subprojects/chromium/master-only/try.star > testing/buildbot/mixins.pyl > testing/buildbot/waterfalls.pyl > > then configs were generated with: > ./infra/config/main.star > ./testing/buildbot/generate_buildbot_json.py > > CIPD packages: > infra_internal/ios/xcode/mac 12a8169fg > infra_internal/ios/xcode/ios 12a8169fg > > Bug: 1108576 > Change-Id: I0edaaf6d945e0f1e061d930d16194f01b17fd851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315436 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792067} TBR=dpranke@google.com,michaeldo@chromium.org,lindsayw@chromium.org,gbeaty@chromium.org,kimstephanie@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108576 Ignore-CQ-Freeze: Changes do not affect CQ. Change-Id: I94996e3092c9a4f4d5961fc497c8c3e1fade0a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327190Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792824}
-
Brian Sheedy authored
Includes the hermetic Xcode binary directory as a data dependency for Telemetry tests on Mac. Xcode is required in order to symbolize minidumps on Mac, and this previously worked by accident due to Xcode previously being installed system-wide. generate_breakpad_symbols.py already supports using the hermetic binary, so we just need to ensure that it's available on a swarming task. Also re-enables the tests that were disabled due to the missing Xcode binaries. Bug: 1110441 Change-Id: Icb703e08c65c27c4b6300710033be138a0bd4da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324883 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792823}
-
Dominic Mazzoni authored
The Switch Access feature on Chrome OS needs to explicitly control scrollable containers. Expose the current scroll position via GetAccessibleNodeData, and implement the required accessible actions to set the scroll offset or scroll by one page in any direction. Bug: 1108941 Change-Id: Icaf36b762b6651f04feb497012d7a029d87062ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319545 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#792822}
-
Lan Wei authored
We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, https://github.com/w3c/webdriver/pull/1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". Bug: 1040611 Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972Reviewed-by:
-
Robbie McElrath authored
We changed how we store the seed date in October 2019 and included fallback logic to handle the old date format. This CL removes that logic now that the change has been in prod for a (long) while. Bug: 1013390 Change-Id: Ie860871aa77c7d1018f62559742045b3238a1342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317717Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#792820}
-
Daniel Rubery authored
This metric is used to ensure that we aren't clearing too many events, which would cause a regression in the accuracy of referrer chains. Fixed: 1095051 Change-Id: I5c2b79d3de3b0815d8a05798613b5227766db1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321228Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#792819}
-
Manas Verma authored
This CL creates the JavaRef for AuthenticatorImpl when request is made, rather than in constructor. Bug: 949269 Change-Id: I43244cafde4f2e98d69caa7adfe347ee1334af5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314030 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#792818}
-
Toni Baržić authored
This reverts commit 9bc4b728. Reason for revert: Suspected cause for ChromeSessionManagerTest.OobeNewUser flakiness. see BUG=1110996 Original change's description: > cros oobe: Make Gaia screen a part of wizard controller screens > > This CL modifies code in a way that GaiaScreenHandler is owned and > handled by GaiaScreen. > > TBR=alemate@chromium.org > > Bug: 1079199 > Change-Id: Idea2f8b9a2974007286e9e8562d1bcee0f2df423 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279800 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792674} TBR=antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org Change-Id: I7e677d7b35b414b3ef18023a8fc4052c25fec3cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327314Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792817}
-
Dale Curtis authored
This remove the "8" suffix from method names and plumbs the previously hard-coded kGray_8_SkColorType as a variable to the YUV decoding path. During the "IsYuv" query stage the YUV bit depth is now passed up to the image decoding cache. The cache will then choose to enable high bit depth YUV decoding if the necessary texture capabilities are available (specifically the R16_EXT or LUMINANCE_F16 extensions). For high bit depth decoding, if R16_EXT is available, the new SkColorType is kA16_unorm_SkColorType otherwise for LUMINANCE_F16 it will be kA16_float_SkColorType. Fixed: 1008448 Tests: Updated unittests. Change-Id: I42a11524d85ab59f57bd59082aec0e5156933815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316332 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792816}
-
Xiaocheng Hu authored
This patch triages the following WPT failures: external/wpt/css/css-pseudo/selection-input-011.html external/wpt/css/css-pseudo/selection-textarea-011.html external/wpt/css/css-pseudo/selection-intercharacter-011.html external/wpt/css/css-pseudo/selection-intercharacter-012.html external/wpt/css/css-pseudo/selection-contenteditable-011.html Bug: 1110286, 1110495, 1110504, 1110512 Change-Id: I975519913dad329eb883b31140210615c7cf932d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324940 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792815}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1da974976b2a..52a98ac3af69 2020-07-29 mmortensen@google.com BuildAPI: Add UnmountPath to SDK controller. 2020-07-29 zhuohao@chromium.org kukui-tablet: Adds new builder and signer type 2020-07-28 pceballos@google.com licensing: Allow Google-TOS for sys-firmware/falcon-firmware 2020-07-28 vapier@chromium.org virtualenv_wrapper: emit a short error message when venv fails If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I859d94cfdf697c35cab0abe4574a83d37e79d5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792814}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Id90af91b2a1bf1db17f0a814a077e42a92c05ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325098Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792813}
-
dpapad authored
Initial approach where the sidenav gets hidden/shown without any animation. Also there is a visible flash in the plugin area as a result of repainting after the sidenav is closed, which will have to be addressed in follow up polish. Bug: 1110015 Change-Id: I879198d6d90d2f384998be56186a3fd7f1aabd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324202 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792812}
-
Andrew Grieve authored
* Properly parse foo="value with spaces" * Hardcode list of tags that are allowed to be multi-line * Make android:name attribute first. Bug: 1064151 Change-Id: I375e80ba9c9de63995d436c3249ca277280a96fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324973 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792811}
-
Sam Sappenfield authored
Create a new state and event within the component type. Within the UpdateEngine and UpdateClient create SendRegistrationPing that calls for registration event to be sent. The execution path for the the registration ping is not taken by the code inside the component updater The change is needed for the code in //chrome/updater. Bug:1096733 Change-Id: I0f239d8d837eb22dda49165ae04698d896860578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290195Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Samantha Sappenfield <t-sasap@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792810}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f587337c306..96d6c6f04dcb 2020-07-29 fmalita@chromium.org [skottie] Re-enable inval tracking in viewer 2020-07-29 elliotevans@google.com Fix SIMD CanvasKit build to output to the expected directory. 2020-07-29 adlai@google.com Migrate MakeFromYUVATexturesCopy* to GrRecordingContext 2020-07-29 jvanverth@google.com Reland "Metal: Hold refs for input buffers from bindBuffer calls." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I93af0965b62eb39f0598b59031a555e4156c4a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326278Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/cfacaaffd1fe..c626b912dc45 2020-07-29 dsinclair@google.com Update some language usage. (#1124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: If4fb93af12a30faac79b9ef0467fa94887d1905f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326283Reviewed-by:
-
Akihiro Ota authored
This change adds a unit test for a popup button that controls itself. Without the associated fix, the test fails due to an infinite recursive loop. Adding a check for self-references in the code fixes the infinite loop and allows the test to pass. Bug: 1109569 Change-Id: Id98a0cb89e513bf6f35ffa66b15a58e5aa570cbc AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326303Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#792807}
-
Mila Green authored
Bug: 1107586 Change-Id: I7ced77b044da43ae4b9d23b5065c396fdbb570f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321531 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
-
Teresa Kang authored
To better showcase the impact of willReadFrequently, a benchmark test that simulates a real world use case of frequent reads from getImageData is added. Bug: 1090180 Change-Id: Ibee406e65698f4c5e23c53caf72853f037102721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285513Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#792805}
-
Jan Wilken Dörrie authored
This change registers the zxcvbn data component. This step was missing in the previous CL. Bug: 1104878 Change-Id: I5b909f67694b2e122be6dff312ff53c33d05fc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326631Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16c50deb5eb4..a307488e3859 2020-07-29 treehugger-gerrit@google.com Merge "Added support for importing v2 flow events from json" 2020-07-29 treehugger-gerrit@google.com Merge "Added support for importing v1 flow events from json" 2020-07-29 treehugger-gerrit@google.com Merge "Add new metric for queuing delay scroll jank cause." 2020-07-29 treehugger-gerrit@google.com Merge "Add NOLINT for FDs that we do not want to be CLOEXEC." 2020-07-29 primiano@google.com Merge "GN: don't run linux_find_llvm.py when is_system_compiler=true" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0da034ccf671598feced50880021fe971127c350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326289Reviewed-by:
-
Robert Ogden authored
This is a small refactor CL that sets the ground work for enabling conncurent URL Loaders. There is no behavior change. Bug: 1110962 Change-Id: I98c54048be9319378b3b3da1c81061e4b4a95ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327011Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#792802}
-
Alexander Surkov authored
Indeed haspopup is not a state and always used with a value, for example, haspopup=menu, thus the filter makes no sense Bug: 1100991 Change-Id: I37b6232e6d36e56892454107e729a5533c6d0ee9 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323561 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
If this is not done, when the button's visual state changes, its text color changes but its background does not. For prominent buttons the result is very hard to read. Bug: 1109798 Change-Id: Id00c1cc7d9ec7c5a71ac5e4f72949883497ab025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321056 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL: HttpPasswordStoreMigrator was conditionally run against only the profile store. After this CL: HttpPasswordStoreMigrator is run against both the profile and account stores. Bug: 1107741 Change-Id: Iadb17cc15884085f09dfbef78ed755d9b49869a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315895 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792799}
-
Jian Li authored
This fixes the problem that the animation for the native view may stop at some circumstance. Bug: none Change-Id: I92370a803ca3031a0856c57a53996e41f91d5123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324102 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#792798}
-
David Tseng authored
This change is a speculative response to the bug below. The bug observes that touch exploration is broken on CFM's main UI. Assuming that observation is true, this change reverts back to sending mouse moves from js. This should be functionally the same as sending mouse moves from C++ in TouchExplorationController as an EventRewriter. R=dmazzoni@chromium.org Bug: b/161161531 Change-Id: I3ae0cfe421708e3630d2d5a0d99d402ec40fa7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316451 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf0b46bf5298c5df40ee14e0b1ba71cd5a6d686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326590Reviewed-by:
-
Yuchen Liu authored
So that we can control it from the cloud. Bug: internal b/160753974 Test: Build Change-Id: I5b29df076727f7c0063836f9ff08cfd1107ad904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325169Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792795}
-
Nina Satragno authored
This is a reland of a0f7bda2 I changed the logic that verifies that frames have rendered so as to not rely on rendering that might slightly change depending on the platform, since on several mac bots the jpeg rendered *looked* the same but the binary was different. Original change's description: > [webui] Re-Enable cr-lottie tests > > It's not clear if these tests will still be flaky on the CI or not. We > made some changes that may have deflaked them. > > Bug: 1103865, 1021474b > Change-Id: Icfe7ed6637868fc29e30c0d182f985a6b38aa000 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311144 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791463} Bug: 1103865 Bug: 1021474b Change-Id: I34406a02dcf1be4d1ff62304e6b824fecd7e8df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320075 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792794}
-
Aaron Leventhal authored
The object at the point in the middle of the focused target isn't necessarily the same as the focused target. For example, the object in the middle of a 2-line link is often an object behind it. Bug: 1082489 Change-Id: If5aff8dc97a917a2465957dd509cabdd9b2c45cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303307 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792793}
-
Robert Ma authored
`wpt lint --ignore-glob` uses fnmatch to match patterns, which means 1. Patterns must match the full filename (we need a wildcard at the beginning). 2. Path separators are not treated specially (i.e. we need to use platform-dependent path separators). Furthermore, we need to ignore OWNERS files, too, which was forgotten in an earlier change. Add tests to prevent regressions. Fixed: 1103374 Change-Id: I62e6ea5ebef900c60b10a325f01683fa5ed836c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326110 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#792792}
-
Teresa Kang authored
- Move getImageData-cpu perf test to rendering benchmark - Remove repeated-draw and repeated-getImageData tests - Replace usages of Math.random with a counter to force different fill color for each frame, to keep the tests simple and reduce dependency Bug: 1077148 Change-Id: Ib7caed70f6a86122c74cee6045179162b3448874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316454Reviewed-by:
-
Hans Wennborg authored
This also updates the Clang version to 12.0.0. Ran `tools/clang/scripts/upload_revision.py 7e8d5a90f2c101388d3b0bbce8555e871c670232`. Bug: 1107461 Binary-Size: Being investigated async in crbug.com/1110413 Change-Id: Ie0dac66069bec3cf10bfe355b5044ebc7af22d88 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320674Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792790}
-
Mohamed Amir Yosef authored
This is a pure refactoring CL. Following up CLs will inject the account store when appropriate. Bug: 1107741 Change-Id: Ic3e31d3f412456c596f9ce97185e90b1b9e5d47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315151 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792789}
-
Randy Rossi authored
The ax_tree_id retrieved from the main frame can change since the main frame may be swapped by the webview due to navigation requests. This CL uses the cast web content's tab id to identify the tab from which the current main frame can be retrieved and (hence the ax tree id). Bug: NONE Test: Display assistant build with weather webview screen Change-Id: I0e8a23a79271a853652b2dcf09dfcf4403f94b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325030Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792788}
-
Nicolas Arciniega authored
This is a reland of 33f234e7 This change differs from the original change in that: - This one dynamically loads WinHttp functions that are not supported in Windows 7 and below (see WinHttpProxyResolverFunctions). - This change fixes a string copy issue in the unit tests. This change creates a functional proxy resolver for Windows that relies on WinHttp APIs. This is not in its final state, though. This CL represents the simplest, least-work way to implement this proxy resolution service. Work still to come includes: - Complete NetLogs - Better error reporting from WinHttp APIs - Proxy Delegate - Proxy retry info - Assurance that the proxy configs we're receiving are from the system The WindowsSystemProxyResolutionService is the object that external callers use to resolve a proxy. These callers can keep track of the status of this proxy resolution via a ProxyResolutionRequest, implemented here as a WindowsSystemProxyResolutionRequest. The request object is mainly intended to kick off a specific proxy resolution and report a result via a caller-provided callback. Both of these objects deal with a WindowsSystemProxyResolver. The WindowsSystemProxyResolver is a new class that does all the required interfacing with WinHttp APIs. It is a reference counted object created by the WindowsSystemProxyResolutionService. Once created, it is used for the lifetime of the WindowsSystemProxyResolutionService. Throughout that time, the Resolver indirectly keeps a WinHttp session handle open. Each WindowsSystemProxyResolutionRequest is given a reference to the new resolver. When the Request object attempts to resolve a proxy for a given URL, it'll call into the Resolver object. Under the hood, the Resolver object creates a handle for the proxy resolution and runs the async call to WinHttp. At any time, the Request object can choose to ignore a pending result from the Resolver (ex: shutdown). The Resolver object must be reference counted because async WinHttp calls call back directly into the Resolver object, so it needs to stay alive as long as we're waiting for an async response from WinHttp. Another new object is the WinHttpAPIWrapper, which is just a thin wrapper over WinHttp APIs which we use to enable easier testing and to simplify some interactions with WinHttp. A WinHttpAPIWrapper is owned by a WindowsSystemProxyResolver. The Resolver object is the only object that should interact with the Wrapper object in any meaningful way. Internally, the WinHttpAPIWrapper keeps track of the opened WinHttp session handle that we're using for the lifetime of the Resolver object. This feature is only supported in Windows 8 and above. Prior versions of Windows will not be able to instantiate the WindowsSystemProxyResolutionService. Loading the right functions for Windows 8+ is handled by the WinHttpProxyResolverFunctions singleton. This change includes tests for the WindowsSystemProxyResolver layer (by mocking out the WinHttpAPIWrapper) and the WindowsSystemProxyResolutionService (by mocking out the WindowsSystemProxyResolver). Bug: 1032820 Change-Id: I1075e5c918e5aa14f7317853e6a39103ad9383d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310672Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792787}
-
