- 05 Nov, 2019 39 commits
-
-
Sorin Jianu authored
* Removes //chrome/updater:updater_constants target * Fixes the dependencies to get a clean run for 'gn check out/default //chrome/updater/*' R=waffles CC=milagreen Bug: 1021336 Change-Id: I50febba965a5d1684ffef0c259dc9bd7e743d34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898776 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712385}
-
Chris Palmer authored
It (sometimes) measurably hurts run-time performance, but we don't have a strong case for its defensive value. The canary check in release mode hurts performance as it requires going completely out of line to compare against a global. Speedometer total Linux: 2.5% Win: 1.4% v8.browsing (metric: blink-gc-total which covers the whole phase) Linux CNN: 11% Linux FB: Noise blink_perf.bindings Linux: Noise Impact: We think the performance impact is noticeable. The canary is only present on 64bit. The canary is only present on Oilpan object and not off-heap objects that are referred to by scoped_refptr<> or regular malloced objects. The canary is not present in V8 which is the first line of attack. The canary is present on all Oilpan objects which means that it is spread across many pages. Any read gadget (e.g. high-performance Spectre gadget) is sufficient to find the value for the current renderer. Impact: The canary can guard against linear overwrites when there's no other info leak present. This mechanism is only enabled on 64-bit. Pointer compression of the Oilpan heap will make the memory overhead of the canary visible. Impact: Similar to not emitting the canary on 32-bit because of memory overhead, we should probably not emit the canary when moving into a future with pointer compression. Change-Id: I6ddb610d0e697fe9407667b72ce4efe4c3720431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879865 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712384}
-
Wez authored
FilteredServiceDirectory is used to create sandboxed directories with subsets of the services available to the caller. For use-cases like integration testing, it is useful to allow specific services to have fake test implementations added, for example, alongside the production services exposed via the directory. Change-Id: I2d751770eb04a138e45f2f019a69323a4cadd3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896535 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712383}
-
Eric Roman authored
Bug: 1021236 Change-Id: I19ec9a8d9618ec8b28deb95cbe46d9ea25be66e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896394 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#712382}
-
Dale Curtis authored
Per bug, test is scheduled for deletion, so just blanket disable. BUG=1004299 TBR=csharrison Change-Id: Ia055c4700340bafa8c11abb9894cc19a12e6b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898766Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712381}
-
Findit authored
This reverts commit 08aba315. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 712315 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA4YWJhMzE1MmJjMjk3ZTFlMzAwZGEyOWZkYWE2M2NjOTY3MTAzMDcM Sample Failed Build: https://ci.chromium.org/b/8897675907369267936 Sample Failed Step: compile Original change's description: > Register the updater app id in registry (Windows). > > Send both the updater and Chrome app ids in the "update apps" use case. > With this change, --install and --ua commands work as expected, meaning > the app ids and the versions are sent during update checks. > > There is a edge case, not handled currently, where the app id for > the updater is not available until the first update check has happened. > This is going to be resolved in a future CL which lands as part of > fixing this CR bug. > > R=waffles > > Bug: 1020285 > Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712315} Change-Id: I82dcc710be51b507c48a66de5dcb3b9d48a50c44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898537 Cr-Commit-Position: refs/heads/master@{#712380}
-
Dale Curtis authored
BUG=783450 TBR=poromov Change-Id: If1011b161745c67e6938f2fa71032423136d2919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898624Reviewed-by:
-
Jesse Schettler authored
Add new print preview metrics for ARC printing. Also, replace UMA macros with UMA functions in PrintRenderFrameHelper. Bug: b:143787611 Change-Id: I4cbbacd04245312ccd1237c9e0dd15989915c1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896300Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#712378}
-
Wez authored
Change-Id: I7e43ea82867177c1aeab089f8f1e35abb802d1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712377}
-
Gyuyoung Kim authored
This CL converts CompositingModeReporterPtr to mojo::Remote<viz::mojom::CompositingModeReporter> in RenderThreadImpl. Bug: 955171 Change-Id: If36579920d065b49e539c37a17a37b2782f5f6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896491Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#712376}
-
Devlin Cronin authored
Unit tests are nice - they are faster and less flaky than browser tests. Add a unit test suite for the ExtensionsMenuView class, and a super basic test that checks extensions are shown in the menu. This is mostly just a jumping-off point so we can easily add more unit tests as we move forward (and add any that are needed to have coverage parity with the old implementation). Bug: 959926, 984654 Change-Id: I04a4d9af02ef1075bb4f0180fbf90c1b615008c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880074Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712375}
-
Shimi Zhang authored
Bug: None Change-Id: I2d62164864a0386f9c524552ac73ec477e0182fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896342 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712374}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5cbb77739e8d..71b0f0b588d6 git log 5cbb77739e8d..71b0f0b588d6 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 j.vigil@samsung.com EGL: Implement EGL_KHR_surfaceless_context Created with: gclient setdep -r src/third_party/angle@71b0f0b588d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ieefe13e1fc312664482bf8cc9608c7c60920bdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712373}
-
Natalie Chouinard authored
Cleaning up JavascriptPreference migration logic that was introduce >4 years ago. Bug: 1016957 Change-Id: I587e0d9722850b861bac8cc768476ae4e36ce93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895328Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712372}
-
Kenichi Ishibashi authored
To investigate invalid states where a redundant service worker is controlling clients. DevTools' application tab shows clients nicely but it doesn't show redundant service workers. Bug: 1015692 Change-Id: I6102f5d897e8e91a49d8502d8876cac809a2c181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890516Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712371}
-
Yuchen Liu authored
This is helpful for debugging media issues on Fuchsia. Once we're confident on the media playback quality, we can revert this patch. Bug: 1021274 Test: Build, deploy and verify the DVLOG shows in the log. Change-Id: I542cc66763af0b1e5e216ec70b821f6ed8bfb123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898511 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Devlin Cronin authored
With the ExtensionsMenu feature, we're changing how extensions in the toolbar presented. However, many tests leverage conceptually simple behavior that should continue to work - such as clicking on an extension opening a popup, or an extension having a presence in the toolbar. We should find a way to apply these tests to both the current behavior and the new ExtensionsMenu behavior. BrowserActionTestUtil is a (platform-agnostic) test utility class for exercising the behavior of extensions in the toolbar. (Note that the name "BrowserAction" is legacy; it actually tests all extension actions). This provides an abstract interface for performing actions like clicking on extensions, getting icons, and determining the number of extensions in the toolbar, and is a common method used by platform- agnostic tests exercising these behaviors. We can repurpose this class with an ExtensionsMenu-specific implementation, which allows us to reuse many of the existing tests without updating them to know about the ExtensionsMenu experiment. While this won't work for all tests (since some exercise behavior specific to the presentation in the toolbar), it should allow us to leverage the same tests for basic functionality like clicking on extensions. Introduce ExtensionsMenuTestUtil, an implementation of BrowserActionTestUtil that works with the ExtensionsMenu UI, and use this iff the ExtensionsToolbarMenu feature is enabled. This reduces the number of browser tests on Linux that fail with the ExtensionsToolbarMenu feature enabled from 105 to 74. Bug: 984654 Change-Id: Ife6d663ca59db9032f5442a297f6b0ac51a2528a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877660 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Mike Wittman authored
Updates the metadata function interfaces to use only the required types, in preparation for refactoring them into separate class. Bug: 1895969 Change-Id: I8b80d091d457e7a43d8593a39a71531b1923c27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896914 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712368}
-
François Doray authored
The freezing origin trial opt-out/in is not a typical new Web feature that Web developers would like to try out. It is an explicit way to opt-in/out of an intervention. If we set the opt-in with --enable-experimental-web-platform-features: Web developers may be surprised that their site gets frozen when playing audio, using WebUSB... If we set the opt-out with --enable-experimental-web-platform-features: Web developers will not be able to observe how their site works with freezing. Therefore, this CL ensures that --enable-experimental-web-platform-features does not set the origin trial opt-out/in. Bug: 1020567 Change-Id: I7c595224fa236d554d2548476b36472f676ed2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894878Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#712367}
-
Wez authored
Bug: 1020694 Change-Id: I5f0e03328646456dbc1289a259d99b7bd9d8e79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893545 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712366}
-
Hesen Zhang authored
- Create UpdateNotificationConfig, enables reading from finch. - Also added unit test for finch config. - TODO: Add finch config in server side. Bug: 1013685 Change-Id: I36042690ac1f68445a360d59247a082969504229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895309Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712365}
-
Yue Li authored
The cl replaces the use of webm video with lottie animation in Assistant opt-in flow. Also update the style to center the lottie animation. Bug: b/1012793 Test: Manual Test Change-Id: I620d01dee2bf9c6670f57ec2390b6b0bf0da53df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891336Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#712364}
-
Dale Curtis authored
BUG=1020758 TBR=sky Change-Id: Ie5e866191d0c0a290f6667f8da80ea809a32cdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896391Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebd3e84c13c3..6bfec1fd1dc3 Created with: gclient setdep -r src-internal@6bfec1fd1dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848,chromium:None Change-Id: I2c2c7b8f8315cc6e6d4c805e96987ad6771f295b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898627Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712362}
-
Jay Harris authored
This is a follow up to https://crrev.com/c/1890394 adding a test. Bug: 1019319 Change-Id: Icc3498a0975c5370299fe558b212cb4c5b8a8232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893604 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#712361}
-
John Lee authored
Swiping a tab (in either direction, up or down) initially begins by animating opacity from 0 to 1, and then animates the max-width to 0 to hide the space the TabElement takes in the tab strip. The tab will only close if the user lets go of the pointer past this max-width threshold or if the user swipes quick enough. Bug: 1014679 Change-Id: I060876c1c2916cb69e964f39c18f72a4d379931f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888380 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#712360}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72de1a08. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie98cb58d377b7ffc2b78c08b3182e12c19f00414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898174Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712359}
-
Mike Wittman authored
Default arguments on virtual functions are not permitted by the style guide. The argument was also only unspecified in test code, which is updated to always specify it. Change-Id: If415e408c365f5a9c9b68273a369680934cf0ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895970 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Demotes the toggle button from a ToolbarButton to a LabelButton, and the pointer to it all the way to View. Some visual regressions relative to the caret (i.e. no ink drop, and ':D' is not a useful indicator of what the button does). Also, the translation string is about to be changed again so maybe this CL would add pointless busywork for our translators? This is an intermediate first step in changing the toggle button to a tab counter. It replaces the caret image with a non-informative, incorrectly styled, hardcoded-content text label. Bug: 999557 Change-Id: I9f964dd22c251aceaf6c3faa5eb1106161663cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885552Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#712357}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3940.0-1572260209-benchmark-80.0.3954.0-r1 to 80-3945.13-1572864139-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ibaeb68dda3b911f49c3104664aa836557c0cfb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898750Reviewed-by:
-
David Benjamin authored
This bug was fixed by disabling prerender. Bug: 755921 Change-Id: I1892c44de558a6d7857e5ee62134a415d1bcca4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898551 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712355}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c78356feca93..30b5b3814199 git log c78356feca93..30b5b3814199 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 oysteine@google.com Merge "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence" Created with: gclient setdep -r src/third_party/perfetto@30b5b3814199 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic2880651b41a1c95d773a699623f6e81a20be200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898523Reviewed-by:
-
gogerald authored
Bug: 982018 Change-Id: I03d55c949e27870332409111a677bb3170b5549d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894460 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712353}
-
Tarun Bansal authored
Require callers to specify profile type when checking lite mode state. Currently, the callers only have to specify the PrefService object. However, that object does not encapsulate all the information necessary to make the decision since the prefs are carried over from regular profile to the incognito. Change-Id: I739f2b2814a16b8cc69ab71ac490e7fbad1dae6c Bug: 1014144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892552 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712352}
-
Jordy Greenblatt authored
A previous migration to using cr-link-row instead of directly using a subpage-arrow class cr-icon-button did not update the selector in forcusConfig_ to match. As a result, when the user routes back to the OS search page, the DOM and a11y focus go to the full page. This CL updates the selector in focusConfig_. Bug: 1003992 Change-Id: I57bf325a9ea5fe4f7719924cf9c2abbedde9de9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897492 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Auto-Submit: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#712351}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3931.2-1572259441-benchmark-80.0.3954.0-r1 to 80-3943.1-1572873357-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ia64eb420d4d1ea2c9291edf176dae8ec3f798189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898746Reviewed-by:
-
Collin Baker authored
Bug: 1013646 Change-Id: I1eadbafe47401508d12e69cf5663de764935ec19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885258 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
David Trainor authored
As a precursor to moving downloads home to a module, remove all references to Profile and place them in the factory. Bug: 1018425 Change-Id: Ifd5c529ffa20585841cefc49c48c097ef09afdce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881947Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#712348}
-
Toni Barzic authored
And add some delay before stating opacity animation. BUG=1020735 Change-Id: I5fabd3923c55ecf969727b2887e32dd938873b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895080Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712347}
-
- 04 Nov, 2019 1 commit
-
-
Christopher Cameron authored
Implement ScrollbarThemeMac::PaintScrollCorner. This function needs to know properties of its vertical scrollbar (is it on left or right, is it in dark mode, etc), to be correctly implemented. Plumb these arguments through. Pass by pointer for fear that they not always exist. Determine the CocoaScrollbarPainter::Params from the Cocoa ScrollbarAnimator and ScrollbarPainter classes. Leave all of the code to update those classes in place, as an incantation (attempts to change it cause bizarre bugs -- it needs to be removed in one go). Update layout tests. Bug: 961835 Change-Id: I883c5614ebfaaab3c0cf32117d210392ffec030a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889296 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712346}
-
