- 26 Apr, 2016 40 commits
-
-
justincohen authored
This ended up pulling in a bunch of v8 code that doesn't work with the ninja-xcode bindings. BUG= Review URL: https://codereview.chromium.org/1922863003 Cr-Commit-Position: refs/heads/master@{#389888}
-
eugenebut authored
This API is necessary to remove loading progress code from Tab, which is currently stores the loading progress and provides it to Toolbar. Corresponding method does not exist in WebContents, because on Desktop the progress is not shown in UI and on Android progress is stored in WebContentsDelegateAndroid. BUG=None Review URL: https://codereview.chromium.org/1905393002 Cr-Commit-Position: refs/heads/master@{#389887}
-
stip authored
This allows use of the gtest test generator and easy swarming. https://codereview.chromium.org/1915003004/ is the build-side change. https://chromereviews.googleplex.com/411237013/ is the build_internal-side change. BUG=525873 Review URL: https://codereview.chromium.org/1918733002 Cr-Commit-Position: refs/heads/master@{#389886}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea682869..0c48cc8c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1923633002 Cr-Commit-Position: refs/heads/master@{#389885}
-
sky authored
BUG=603369 TEST=covered by tests R=jamescook@chromium.org Review URL: https://codereview.chromium.org/1920153003 Cr-Commit-Position: refs/heads/master@{#389884}
-
wangxianzhu authored
Use correct paint offset and clip, and apply zoom factor. Some changes are based on https://bugs.webkit.org/show_bug.cgi?id=143527. BUG=475128 TEST=fast/images/imagemap-focus-ring-in-positioned-container.html TEST=fast/images/imagemap-focus-ring-with-paint-root-offset.html TEST=fast/images/imagemap-focus-ring-with-scale-transform.html TBR=dmazzoni@chromium.org (passive change under Source/modules/accessibility due to function renaming) Review URL: https://codereview.chromium.org/1912863002 Cr-Commit-Position: refs/heads/master@{#389883}
-
rsesek authored
BUG=431177 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1919373002 Cr-Commit-Position: refs/heads/master@{#389882}
-
shivanisha authored
BUG=part of 585134 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation This is a part of the design for 585134 which includes a larger set of traces. As part of that design we also noticed overlapping traces that existed earlier for navigation start to commit. As discussed with carlosk@, this change also reverts the earlier traces which only covered PlzNavigate and adds the new traces that cover the following scenarios: - plzNavigate and traditional flows - committed and aborted/failed/canceled loads This patch adds the async begin and end traces in the constructor and destructor of NavigationHandleImpl respectively. That would cover all of the scenarios as detailed in the design doc (https://docs.google.com/a/chromium.org/document/d/1yM2khCxLC5AV3X4y7cyuCNCFHCmq9CpqQzDwK6MROaw/edit?usp=sharing). The start time of Navigation is passed in the constructor and that would be used as the trace start timestamp. For failed/aborted provisional loads, the argument net error code will give the error code. In this patch I am adding them in the existing "navigation" category only and later they might be extended for new categories like "loading". Review URL: https://codereview.chromium.org/1825533002 Cr-Commit-Position: refs/heads/master@{#389881}
-
piman authored
It's not used. BUG=None Review URL: https://codereview.chromium.org/1922783004 Cr-Commit-Position: refs/heads/master@{#389880}
-
j.isorce authored
Currently llvmpipe driver from Mesa is black listed. It is fast and stable enough to allow using the gpu process. But only enable WebGL, other features still won't use the gpu process. For example the 2D Compositing Skia is faster than gpu compositing on software GL driver. BUG=571899 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org TEST= GALLIUM_DRIVER=llvmpipe LIBGL_ALWAYS_SOFTWARE=1 chrome CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1548893004 Cr-Commit-Position: refs/heads/master@{#389879}
-
chongz authored
On Mac with an external JIS PC keyboard, pressing "Convert", "NonConvert" and "KanaMode" keys will always produce |NSFlagsChanged| NSEvent with |keycode| == 255. Which will then cause blink to fire two "keydown" events. These three keys do not exist in Apple's Japanese keyboard, and there is no way for us to distinguish them or get any useful information (and it requires hack to mock "keydown"/"keyup"). Safari generates two "keydown"s (with no useful information). Firefox does not generate keyevents for these keys, this CL matches Firefox's bahavior. BUG=601964 Review URL: https://codereview.chromium.org/1923023002 Cr-Commit-Position: refs/heads/master@{#389878}
-
creis authored
Revert of Reland: [qcms] Fix build_output_lut to return correct data for parametric curves (patchset #14 id:260001 of https://codereview.chromium.org/1862053002/ ) Reason for revert: This broke the Windows compile (again). https://build.chromium.org/p/chromium/builders/Win/builds/42772 Original issue's description: > [qcms] Fix build_output_lut to return correct data for parametric curves > > build_output_lut() does not invert a parametric gamma curve when > computing the output curve data. The effect has not been visible > since Chrome only uses the output gamma values from the precache > table (which is inverted). > > Make build_output_lut() return inverted data for parametric gamma > curves. Add a test to write the inverted data, and the output of > LCMS function DefaultEvalParametricFn, to a file for comparison. > > For now the size of input and output gamma table for parametric > curves is hard-coded to 256; assert this in the test code. See > compute_curve_gamma_table_type_parametric for details. Future > implementations might return an arbitrary-sized table. > > BUG=600338 > > Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801 > Cr-Commit-Position: refs/heads/master@{#389754} > > Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f > Cr-Commit-Position: refs/heads/master@{#389866} TBR=noel@chromium.org,radu.velea@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600338 Review URL: https://codereview.chromium.org/1920253003 Cr-Commit-Position: refs/heads/master@{#389877}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/82ecc5773faa..8ffab6fc0eff $ git log 82ecc5773..8ffab6fc0 --date=short --no-merges --format='%ad %ae %s' 2016-04-26 borenet Whitespace change to trigger bots after recipe fix CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=stephana@google.com Review URL: https://codereview.chromium.org/1918243003 Cr-Commit-Position: refs/heads/master@{#389876}
-
dbasehore authored
To handle lucid sleep (where we need to silently resume the system), turn off the displays on suspend. This also removes the delay for restoring the display state added in "On resume perform a delayed call to SetDisplayPower()" According to the bug for that change, it didn't seem to help with the issue anyways. BUG=535021 TEST=suspend/resume of various cros platforms with/without external monitor connected Review URL: https://codereview.chromium.org/1861593002 Cr-Commit-Position: refs/heads/master@{#389875}
-
kapishnikov authored
BUG=601972 Review URL: https://codereview.chromium.org/1915683002 Cr-Commit-Position: refs/heads/master@{#389874}
-
jaydasika authored
In hit testing, we should use the render surface screen space transform (which doesn't have sublayer scale) instead of the screen_space_transform stored on the transform node (which has the sublayer scale baked in) as the clips stored in clip tree already account for the scale. BUG=604731 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1917043002 Cr-Commit-Position: refs/heads/master@{#389873}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/89ac5c3cccf7..7744caa3a0f0 $ git log 89ac5c3cc..7744caa3a --date=short --no-merges --format='%ad %ae %s' BUG=605972,606052,606706 TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1923583002 Cr-Commit-Position: refs/heads/master@{#389872}
-
chrome://local-statehamelphi authored
BUG=506331 Review URL: https://codereview.chromium.org/1910323002 Cr-Commit-Position: refs/heads/master@{#389871}
-
zhongyi authored
BUG=603636 Review URL: https://codereview.chromium.org/1895533004 Cr-Commit-Position: refs/heads/master@{#389870}
-
dsinclair authored
BUG=chromium:606726 Review URL: https://codereview.chromium.org/1918363002 Cr-Commit-Position: refs/heads/master@{#389869}
-
dmurph authored
We have substantial crashes since adding bad_message errors for invalid blob messages. It looks like there is a pre-existing condition where blob references are race casing across processes. While we investigate the issue, we want to remove this crash so it's not making the situation worse (crashing instead of having a broken blob). I'm keeping the uuid.empty() condition as a bad message, because that's definitely an error that shouldn't be happening. BUG=606065 Review URL: https://codereview.chromium.org/1913343002 Cr-Commit-Position: refs/heads/master@{#389868}
-
miu authored
The capture callback must always be run, or eventually the capture decision logic will think there are too many captures in-flight. This closes some "holes" in content::AuraWindowCaptureMachine where methods exit early without running the callback. This is a potential fix for crbug 600031. BUG=600031 Review URL: https://codereview.chromium.org/1913283004 Cr-Commit-Position: refs/heads/master@{#389867}
-
radu.velea authored
build_output_lut() does not invert a parametric gamma curve when computing the output curve data. The effect has not been visible since Chrome only uses the output gamma values from the precache table (which is inverted). Make build_output_lut() return inverted data for parametric gamma curves. Add a test to write the inverted data, and the output of LCMS function DefaultEvalParametricFn, to a file for comparison. For now the size of input and output gamma table for parametric curves is hard-coded to 256; assert this in the test code. See compute_curve_gamma_table_type_parametric for details. Future implementations might return an arbitrary-sized table. BUG=600338 Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801 Cr-Commit-Position: refs/heads/master@{#389754} Review URL: https://codereview.chromium.org/1862053002 Cr-Commit-Position: refs/heads/master@{#389866}
-
xunjieli authored
This CL adds a flush mode and a flush() method to Cronet's BidirectionalStream API and buffers writes until flush() is called. By default, Cronet flushes after every write(). net::BidirectionalStreamQuicImpl uses ScopedPacketBundler to bundle small writes into one data packet along with request headers. net::BidirectionalStreamSpdyImpl will do an extra memcpy to combine small write buffers into a big one. BidirectionalStreamSpdyImpl doesn't combine header frame with data frame currently. BUG=599902 Review URL: https://codereview.chromium.org/1856073002 Cr-Commit-Position: refs/heads/master@{#389865}
-
hlopko authored
It turns out that we don't have to trace as much as expected, plus automation cannot often be applied anyway. So let's just get rid of it and write traceWrapper methods by hand. LOG=no BUG=468240 Review URL: https://codereview.chromium.org/1917883002 Cr-Commit-Position: refs/heads/master@{#389864}
-
ekaramad authored
This refactoring is the first step in relanding "Browser Side Text Input State Tracking for OOPIF" (original CL: https://codereview.chromium.org/1652483002). For context on initialization of all struct variables refer to this CL: https://codereview.chromium.org/1894473002. For context on the default copy constructor refer to this CL: https://codereview.chromium.org/1867153002. BUG=578168 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1914603002 Cr-Commit-Position: refs/heads/master@{#389863}
-
nasko authored
This CL adds an explicit navigation from within an iframe to about:blank. It verifies that the iframe stays in the same process after navigation has completed as the initiator of the navigation is the iframe itself. BUG=591509 Review URL: https://codereview.chromium.org/1917223002 Cr-Commit-Position: refs/heads/master@{#389862}
-
ochang authored
Also removes an unneeded dep from message_lib.gyp. BUG=605926 Review URL: https://codereview.chromium.org/1916493003 Cr-Commit-Position: refs/heads/master@{#389861}
-
asargent authored
Matt isn't working on chrome stuff anymore Review URL: https://codereview.chromium.org/1916133002 Cr-Commit-Position: refs/heads/master@{#389860}
-
rockot authored
Adds several new system API methods: - MojoAllocMessage: Allocates a new message object for a fixed payload size and set of handles - MojoFreeMessage: Frees a message object - MojoGetMessageBuffer: Acquires a mutable buffer address to manipulate message object payload - MojoWriteMessageNew: Writes a message object to a message pipe, relinquishing ownership - MojoReadMessageNew: Reads a message object from a message pipe, taking ownership Message objects themselves are respresented in the public API by an opaque MojoMessageHandle. The purpose of these APIs is to encapsulate ownership transfer of message buffers, allowing us to avoid several redundant copies that are forced by MojoWriteMessage() and MojoReadMessage() design. BUG=597379 Review URL: https://codereview.chromium.org/1880823005 Cr-Commit-Position: refs/heads/master@{#389859}
-
mkwst authored
The current code checks for an exact origin match when creating a Request. That doesn't match the specification; see step 3.1 of https://w3c.github.io/webappsec-credential-management/#body-extraction. BUG=606788 Review URL: https://codereview.chromium.org/1918253002 Cr-Commit-Position: refs/heads/master@{#389858}
-
birenroy authored
With incremental decode, headers may contain incomplete opcode. The change is divided into two parts: the HpackInputStream change in hpack_input_stream.h/cc, and the HpackDecoder change in Hpack_decoder.h/cc. After new data are added to the buffer (by calling HandleControlFrameHeadersData()), a new HpackInputStream is created based on the current data in the buffer, and as many data as possible are parsed. When an opcode is parsed successfully, remember the current position in the header (by calling MarkCurrentPosition()), and move on to the next opcode. If an opcode is incomplete, we return from the current parsing with false, and mark need_more_data_ to be true. The data have been successfully parsed will be removed from the buffer. Since we incrementally decode headers as data arrive, we remove the decode code in HandleControlFrameHeadersComplete(). This CL lands server change 116551169 by yasong. BUG=488484 Review URL: https://codereview.chromium.org/1914193002 Cr-Commit-Position: refs/heads/master@{#389857}
-
xunjieli authored
The internal read buffer for upload is 14520 for QUIC, 2852 for SPDY, and 16384 for normal stream. SPDY is too small compared to normal stream and QUIC. This CL increases the read buffer to 16384 so it is comparable to the other two implementations. This will make it easier for net embedders to configure uploads to work well across different transports. This CL additionally updates flow control tests so they take into account the new buffer size when zeroing out window size. BUG=606784 Review URL: https://codereview.chromium.org/1914663002 Cr-Commit-Position: refs/heads/master@{#389856}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/34b5eb49..ea682869 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1923543002 Cr-Commit-Position: refs/heads/master@{#389855}
-
jbudorick authored
BUG=606798 TBR=changwan@chromium.org,qinmin@chromium.org Review URL: https://codereview.chromium.org/1920303002 Cr-Commit-Position: refs/heads/master@{#389854}
-
apacible authored
Fixes text going off the banner instead of moving to the second line. BUG=606823 Review URL: https://codereview.chromium.org/1916193005 Cr-Commit-Position: refs/heads/master@{#389853}
-
sky authored
Last remaining bit is shell ids. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Review URL: https://codereview.chromium.org/1914093002 Cr-Commit-Position: refs/heads/master@{#389852}
-
xidachen authored
BUG=605186 Review URL: https://codereview.chromium.org/1917193002 Cr-Commit-Position: refs/heads/master@{#389851}
-
dskiba authored
This change enables check-ipc option for find-bad-constructs Clang plugin on Android. With that option Clang plugin will check that the following types are not used in IPC messages: 1. Types: long / unsigned long (but not typedefs to) 2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t, rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t (including typedefs to) 3. Any template referencing the above (e.g. std::vector<size_t>) These types are banned because they are not stable across 32/64-bit platforms. BUG=581409 Review URL: https://codereview.chromium.org/1904553002 Cr-Commit-Position: refs/heads/master@{#389850}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/86ae3d161412..82ecc5773faa $ git log 86ae3d161..82ecc5773 --date=short --no-merges --format='%ad %ae %s' 2016-04-26 bsalomon Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ ) 2016-04-26 rmistry Return error code when get_images_from_skps has failures. 2016-04-26 msarett Do not globally register drawables in test code 2016-04-26 herb Add guards for edge cases. 2016-04-26 egdaniel Remove unnessary uniform barriers in Vulkan. 2016-04-26 jvanverth Add automatic generation of mipmaps to Vulkan 2016-04-26 jvanverth Fix animation with stats in VulkanViewer GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918083003 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=stephana@google.com Review URL: https://codereview.chromium.org/1914153003 Cr-Commit-Position: refs/heads/master@{#389849}
-