1. 22 Jul, 2020 2 commits
    • Adlai Holler's avatar
      Migrate to GrRecordingContext version of SkImage::isValid · 01462f98
      Adlai Holler authored
      This unblocks http://review.skia.org/304776. After that lands, we can
      come back and remove the explicit cast.
      
      The inclusion of GrDirectContext.h is "jumping ahead" to where Chromium
      CL 2297920 is taking us, and it is in the process of landing. We could
      have imported GrContext.h but then we'd have a needless conflict.
      
      Bug: skia:104662
      Change-Id: Ibc6b5a5061577bca59a3b57ce16a1af0298d0f5b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310974
      Commit-Queue: Adlai Holler <adlai@google.com>
      Auto-Submit: Adlai Holler <adlai@google.com>
      Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#790604}
      01462f98
    • Evan Stade's avatar
      WebLayer: adjust browser controls visibility code · 53cfb65b
      Evan Stade authored
      Since WebLayer was sending old_state for the constraint, a switch from
      SHOWN to HIDDEN, as when entering fullscreen, could hit a DCHECK in
      browser_controls_offset_manager.cc
      
      I think some confusion arises from the re-use of a single enum for both
      the _constraint_ and the _current state_. Code used the terms old_state
      and new_state, when really the RenderFrameHost method expected a new
      constraint and new desired state. The BOTH value in the context of a
      constraint means unconstrained, and in the context of a state means
      "don't change unless you have to to conform to the constraint".
      
      Test: requestFullscreen on an element in weblayer shell doesn't cause
            the renderer to crash in debug
      
      Bug: 1107647
      Change-Id: I4f72e1144a9fc9a0cf0934b9640c660867c0d971
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310652
      Commit-Queue: Evan Stade <estade@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#790603}
      53cfb65b
  2. 21 Jul, 2020 38 commits