Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 27 Mar, 2019 4 commits
    • Thomas Guilbert's avatar
      Cleanup MediaPlayerRendererClient · 01538f1f
      Thomas Guilbert authored 
      This CL cleans up the technical debt introduced by adding MPR/MPRClient
specific methods to general purpose interfaces.

When adding MediaPlayerRenderer (MPR), a few 1-off methods were tacked
on to existing interfaces, to avoid plumbing new paths through the
entire media pipeline. Thanks to the CreateRenderer split, it is now
easier to extract these functions into strongly typed, specialized
Mojo interfaces, that are only used by the classes that need them.

The CL add renderer_extensions.mojom, which defines the
MediaPlayerRendererExt and the MediaPlayerRendereClientExt.

MediaPlayerRendererClientExt defines the events that the MPRC needs to
listen to, coming from the MPR in the browser process.
It allows us to remove RendererClient::OnDurationChanged(), and bubbles
up duration changes via ForwardDurationChangeToDemuxerHost().
It also allows us to send video size change events directly to the
MPRC, which can now avoid implementing RendererClient pass-through
methods, just to update its StreamTextureWrapper.

MediaPlayerRendererExt defines the extra methods that the MPR needs to
expose to the MPRC.
It allows us to move InitiateScopedSurfaceRequest() out of MojoRenderer,
and paves the way to simplifying the "bad call" logic is in place in the
MojoRendererService.

Bug: 669606
Change-Id: I2a8a537beb2e4d8f8d34b6256f5a2b4ab6af0715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524525
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644605}
      01538f1f
    • Bill Orr's avatar
      Fix a crash and a timeout issue. · 956fd70f
      Bill Orr authored 
      WebXR may not submit frames if pose data is null.  Pose data will
be null if WebXR isn't visible.  However, we want at least one pose
data to be non-null to know that WebXR is ready to submit frames.

The fix is to hand out a non-null pose data.

Also, fix a crash.  graphics_ is set to null when UI hides, but we
may still have an outstanding frame callback.

Change-Id: Ib304a0b56d8737da1d8200cbb6257645755c99ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540616Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644604}
      956fd70f
    • Julie Jeongeun Kim's avatar
      OnionSoup: Move embedded_frame_sink.mojom to public/mojom/frame_sinks · 8b3d5524
      Julie Jeongeun Kim authored 
      This CL moves public/platform/modules/frame_sinks to public/mojom
to gather mojom files to mojom folder and updates paths for
embedded_frame_sink.mojom.

Bug: 919393
Change-Id: If73981416f251d651fa34f114a68d9f58a14a268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534585Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#644603}
      8b3d5524
    • Peter Kasting's avatar
      Disable flaky test on Mac. · f4fbf501
      Peter Kasting authored 
      Bug: 945846
TBR: noel
Change-Id: I9b62ee039e537cc6485514d7e744b6a702b2bb17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539212Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644602}
      f4fbf501
  3. 26 Mar, 2019 36 commits