- 12 Mar, 2020 40 commits
-
-
arthursonzogni authored
When a response is blocked by CORP because of the COEP header, check the reporting API is worker. This patch adds 4x2=8 new WPT tests. For every 4 context: - Document - SharedWorker - DedicatedWorker - ServiceWorker For the 2 headers: - Cross-Origin-Embedder-Policy - Cross-Origin-Embedder-Policy-Report-Only Bug: 1059727, 1031542, 887967 Change-Id: I797e36d0cfc982862e85dbc9a49c661fee46bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096687 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749603}
-
Kamila Hasanbega authored
This reverts commit 546fc2fa. Reason for revert: [Sheriff] This causes failures https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/2304 Original change's description: > Add a first integration test involving both Sync and PasswordManager > > The test sets up Sync-the-transport, has the user opt-in to the account > password storage, and makes sure that saves go to the correct store. > > This requires a few changes to password_manager_test_base.h/cc: > - Most notably: The password manager tests used to set up a > MockPasswordFeatureManager (in order to make IsGenerationEnabled() > return true), but the new combined tests require a real > PasswordFeatureManager. So this CL removes the mock (which also lets > us remove CustomPasswordManagerClient), and instead sets up a > TestSyncService which claims "everything is active" and so also makes > IsGenerationEnabled() true. > - Some simple refactorings to avoid duplicating test setup code: > - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(), > into a new static helper. > - Exposed PasswordStoreResultsObserver (it used to be fully defined > in the .cc). > - Exposed a version of CheckThatCredentialsStored() that takes a > PasswordStore parameter. > > Bug: 1058339 > Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749220} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: Ifb6bdf160c9b53d2b1b50bdaef69389668376910 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098705Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#749602}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/484bb8a03b97..2896bf697b66 git log 484bb8a03b97..2896bf697b66 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 mbonadei@webrtc.org Add ios_use_goma_rbe=true to iOS bots. Created with: gclient setdep -r src/third_party/webrtc@2896bf697b66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic7e479afadf0d9686972222f82caf94554a14123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749601}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I2cc48ece3f4fffe121ec2402617ff3a1b6ecd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100287Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749600}
-
Clemens Arbesser authored
EQUAL is available for all value types. All other comparisons are currently only supported for strings, integers, and dates. Bug: b/145043394 Change-Id: I003074fd5437e1f1e83aa7f4b779a3416b707193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095113Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749599}
-
Michael Lippautz authored
Avoid biasing the metric with many 0-samples and only emit the sample when the GC was actually compacting memory. Bug: 1056170 Change-Id: I906b7b639fa96b53acc6f3b7235a015f6322123f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098625Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749598}
-
Yuki Shiino authored
IDL attributes of type Nullable (e.g. "long?") are currently implemented as: int32_t attrName(bool& is_null); void setAttrName(int32_t value, bool is_null); however, the following APIs are preferable. base::Optional<int32_t> attrName(); void setAttrName(base::Optional<int32_t> value); In order to update bindings APIs of IDL attributes, this patch adds the base::Optional version. Once the bindings generator switches to the new APIs, the old explicit is_null version will be removed. Bug: 1060971, 839389 Change-Id: I6d06d0f2a241c8405f814ce16b9aade8abbe6caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007326Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#749597}
-
Gyuyoung Kim authored
This CL converts BlinkTestHostMsg_PrintMessage to BlinkTestClient interface. But, BlinkTestRunner::PrintMessage needs to send a message only when it's on the mainframe in order to sync with the existing behavior. Like BlinkTestHostMsg_ResetDone conversion, this message has been sent to the main frame. So, this CL moves |is_secondary_window| from WebTestRenderFrameObserver to BlinkTestRunner. Additionally, this CL removes blink_test_messages.h/cc files and related things(e.g. BlinkTestMsgStart) finally. Bug: 1039247, 1059322 Change-Id: I91dfc9256cacc63b1397c46ed1d6c582ab01b6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089435 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#749596}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1fd0b36..55e6902b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I43f1a9fcd23cc3626686b6b1e2e9b60039db0605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100209Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749595}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I32a0a2622c45838df1a7cc51009d88e5adb8bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089775 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee9e28d54f35..a5e36d303614 git log ee9e28d54f35..a5e36d303614 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 szuend@chromium.org Consider all JavaScript to have side effects Created with: gclient setdep -r src/third_party/devtools-frontend/src@a5e36d303614 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1031243 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I56c62577c7b146b6d531676dfe62915151f1e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100232Reviewed-by:
-
Anastasiia Nikolaienko authored
Add profile image fetcher to fetch parent profile images for 'parents list' screen. Bug: 1043108 Change-Id: Id21f43359d2470c5d68129a7d75821acd0fd5be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043877 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#749592}
-
Ewann authored
- Implements the page info site security view controller. - Fixes stop [pageInfoCoordinator stop]. - Renames PageInfoButtonAction to PageInfoSiteSecurityButtonAction. screenshots: https://drive.google.com/drive/folders/1ilG-PTprtWe3QO7sbJUhv_ilwWNmXPwx?usp=sharing Bug: 1038919 Change-Id: I09a492c31cf50c3472903017e871fd8a0757d54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093218Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#749591}
-
Koji Ishii authored
This is a follow up for r749120 crrev.com/c/2089894 This patch has no behavior changes. Bug: 982194 Change-Id: I18775e577dae67b90e98ecddb5b28babca1175e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098165Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749590}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: Ie64acba83e6965a0fd7efe88fbb8c15a95550047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091345 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e5bd9b1e658..84780f7dc5e1 git log 2e5bd9b1e658..84780f7dc5e1 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 shrekshao@google.com Speculative fix: getProgramiv always returns a valid program Created with: gclient setdep -r src/third_party/angle@84780f7dc5e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:991020 Tbr: jmadill@google.com Change-Id: I3264c3e42594f7345899f405d074c291b5a572e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099646Reviewed-by:
-
Kei Nakashima authored
Implemented iterators of NewLinkedHashSet using those of VectorBackedLinkedList. Also made some iterator-related APIs public to use them in NewLinkedHashSet. Change-Id: Ifa4a7c60bfbd3673a1f3923f911cde3eebca612f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097904 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, RespondWithCallbacks in payment_app_provider_impl.cc contained three callbacks, only one of which was used at any time. This patch changes RespondWithCallbacks into an abstract class with three concrete sub-classes instead: CanMakePaymentResponWithCallback, InvokeRespondWithCallback, and AbortRespondWithCallback. In addition, when the payment handler respond with "false" to "abortpayment" event, payment_app_provider_impl.cc no longer clears the list of Invoke callbacks, because "false" indicates that the payment has not been aborted. After this patch, there're three callback classes with one callback member variable each. Bug: 1060298 Change-Id: Ie5c141bc01a6d3c663afd768ea829b750587f0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094666 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749586}
-
Hiroshige Hayashizaki authored
As a part of turning down Built-in Modules in Blink. Bug: 829084, 972476, 1055006 Change-Id: Ibd0fcc327977d1fcd5da811e7f0b245ae9f9f797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094493 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#749585}
-
Makoto Shimazu authored
This adds COEP reporter for service worker contexts. CORP failures happening on subresource requests initiated from a service worker are reported to the COEP reporter owned by EmbeddedWorkerInstance. Bug: 1056122 Change-Id: I7884487e0261b4d85bf98b5844c3e34c0b985ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098166 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749584}
-
Side Yilmaz authored
|getLastUsedRegularProfileKey|. |ProfileKey#getLastUsedProfileKey| is depreciated and replaced with |ProfileKey#getLastUsedRegularProfileKey|. This change replaces |ProfileKey#getLastUsedProfileKey#getOriginalKey| with |ProfileKey#getLastUsedRegularProfileKey|. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ic55693571ad10395ff9c88e5bf965b0578768c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089869Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749583}
-
Domenic Denicola authored
This seems to be leftover from a Blink-side implementation of origin policy. The classes defined in these files are not referenced elsewhere in the Chromium codebase and are not involved in our current origin policy implementation. https://crbug.com/1060184 tracks adding a new fuzzer for the modern implementation, to replace the one deleted here (that is currently fuzzing dead code). Fixes: 1056673 Change-Id: Idccac39753caa275c62f303a5f635cf6f74235b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079258Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e10db6f8d6..905a6de3705f Created with: gclient setdep -r src-internal@905a6de3705f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040328,chromium:996088 Tbr: jbudorick@google.com Change-Id: Ie9907a73866865febc31891bcc9aedf051e1a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100143Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749581}
-
Rouslan Solomakhin authored
Before this patch, payment_app_provider_impl.cc received a CanMakePaymentResponsePtr from the renderer process and forwarded only its "can_make_payment" field to the service worker payment app factories. This patch forwards the full CanMakePaymentResponsePtr instead of the boolean, but the "ready_for_minimal_ui" field is always false and "account_balance" field is never set. After this patch, payment_app_provider_impl.cc forwards the full CanMakePaymentResponsePtr structure to the service worker payment app factories. Bug: 1005076 Change-Id: I3e076034a83f66bf42b92fcadf0e9f248395f15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090803Reviewed-by:
-
Alan Cutter authored
This test started flakily crashing after: https://chromium-review.googlesource.com/c/chromium/src/+/2090877 First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17501 TBR=pkasting@chromium.org Bug: 1060421 Change-Id: Ib24e672b8757992c0d10bc3e7b745d3cb8e79f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100172Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749579}
-
Eriko Kurimoto authored
This CL adds tests for subresource fetching from HTTP(S) scheme url dedicated workers and shared workers. Currently, we have subresource fetching tests from ONLY data: URL dedicated workers . In this CL, we improve the test coverage by adding subresource fetching tests from HTTP(S) scheme url workers which are more normal. Bug: 989399 Change-Id: Icf83cd359fa64df94c5ff93210c7a1c7bce12944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077321Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#749578}
-
Colin Blundell authored
This is a direct dependency on ExternalNavigationDelegateImpl, which will stay in //chrome after ExternalNavigationHandler is componentized. This CL abstracts the method through ExternalNavigationDelegate. Bug: 1031465 Change-Id: Ia307d675d08af0492a1bad658c95f76ae8778111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095547 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749577}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: I23fb1ad19251bae8e1917b6089b3cb75385e74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097031 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749576}
-
David authored
This cl also * adds the id of the MediaApp into chromium (will need it for metrics later) * adds a test parameterized test (since SystemWebAppManagerBrowserTest is now paramterized), currently expects the inverse. Bug: b/144886504, 877898, 1054195 Change-Id: I1d862b04d47092e45ad08415b707612a1e5464fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082659 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749575}
-
Viktor Semeniuk authored
This change allows adding new entities to the bottom of the compromised credentials list. Special sorting applied. Also, deleted elements are removed from the list. Bug: 1047726 Change-Id: I3af45a94670091b61cf517d0637877f9f852901b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094983 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749574}
-
Noel Gordon authored
Wheel events over the drop-down menu (a <dialog>) can cause directory tree to show vertical scrollbars even though the user cannot possibly interact with the directory tree (they are in a <dialog> element). Do not draw directory tree scrollbars in this case - if the drop-down is open, post that state to the <html> element so CSS can detect, and block tree overflow behavior. Bug: 1035691 Change-Id: Id40017a1b4ff576e4b16efc22e661e3169710e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098169Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1743144ab839..7bb74c4299b8 git log 1743144ab839..7bb74c4299b8 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 43a5bd0c..5309fd86 (470 commits) 2020-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c5b3cbdb4502..2e5bd9b1e658 (10 commits) Created with: gclient setdep -r src/third_party/skia@7bb74c4299b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I55730253e1595162be0a8b8804197620ebcb3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100138Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/276dc290d7ce..ee9e28d54f35 git log 276dc290d7ce..ee9e28d54f35 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@ee9e28d54f35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I40c1008d83d11043cfb93eaf2a7066fbdedb6c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100082Reviewed-by:
-
Mikel Astiz authored
Tests can be simplified if TestBookmarkClient offers support for constructing the managed bookmarks folder, since it's not supposed to be constructed in an arbitrary fashion anyway. Bug: 1060311 Change-Id: I388daca001474fab2b0810d3a581b3a36e5f78ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096963 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The function is not used and can be trivially removed. Bug: 1060311 Change-Id: I24966e362e71ae5cc1a68e8af63e547a2f4ea5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098075Reviewed-by:
-
Omer Katz authored
Bug: 1060756 Change-Id: I1dc1e252e5d3a0b4dea15ae463e61e420eb39406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098904Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749568}
-
Wez authored
The NetworkChangeNotifierFuchsia.* tests were being run with a testing::InSequence instance active, causing EXPECT_CALL()s to be verified with strict ordering. NotifyNetworkChangeOnInitialIPChange is the only test that has an ordering expectation, so move the InSequence inside that test. Also fix the test to specify expectations on the observers before causing them to be called, as required by GMock. Bug: 1060566 Change-Id: I7a03cdba154b070a95bc05b08737418fcbfc5841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098078 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749567}
-
Yutaka Hirano authored
Bug: 887967 Change-Id: I1352c4a1f4dccc294c6765e609da8c9e92c6f90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098190Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749566}
-
Kuo Jen Wei authored
Bug: 1059191 Test: tast run <DUT> CCAUI* Test: See if the multi fps UI hidden on device with 30, 60 fps capability builtin camera. Change-Id: I1f2037ba871089a4e7d106cb101cff0631eb8a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098188Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#749565}
-
Kent Tamura authored
Also moves cached_state_for_active_selection_ to ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Ie32cdf5eb9cba2daf7031b20dc71a9ca907d92e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098191 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
