Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 05 Nov, 2019 38 commits
  3. 04 Nov, 2019 2 commits
    • Christopher Cameron's avatar
      Use CocoaScrollbarPainter in Blink, fix corners, fix thumb clipping · 5a934f16
      Christopher Cameron authored 
      Implement ScrollbarThemeMac::PaintScrollCorner. This function needs
to know properties of its vertical scrollbar (is it on left or right,
is it in dark mode, etc), to be correctly implemented. Plumb these
arguments through. Pass by pointer for fear that they not always exist.

Determine the CocoaScrollbarPainter::Params from the Cocoa
ScrollbarAnimator and ScrollbarPainter classes. Leave all of the code
to update those classes in place, as an incantation (attempts to change
it cause bizarre bugs -- it needs to be removed in one go).

Update layout tests.

Bug: 961835
Change-Id: I883c5614ebfaaab3c0cf32117d210392ffec030a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889296
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712346}
      5a934f16
    • Shimi Zhang's avatar
      [JJI] Don't use evaluateJavascript() to validate test · 57091c19
      Shimi Zhang authored 
      Event listeners for the injected JS object are different
from evaluateJavascript() in a way that evaluateJavascript()
will execute the JavaScript immediately when it reaches to
the renderer, however JJI's event listener posted to the event
loop asynchronously. So we can't expect that a listener is
executed before evaluateJavascript().

This CL changed the validation to relying on the async call
of the listeners instead of using evaluateJavascript().

Bug: 1015023
Test: Run both tests locally 1000 times, didn't see any failure.

Change-Id: I1434b43f5dbc7f2700580c9c053453f5d20398c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894248
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712345}
      57091c19