- 17 Apr, 2020 40 commits
-
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Ia2227f00e07d6f1cb26f55f52df571383a8e8137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154728Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760136}
-
Michael Lippautz authored
This reverts commit bde0ab78. Reason for revert: Possibly causing https://bugs.chromium.org/p/chromium/issues/detail?id=1071874 Original change's description: > heap: Remove GetHeapObjectHeader from mixins > > The methods in the macro are put on every GarbageCollectedMixin which > is expensive in terms of binary size. The HoH getter can be replaced > with GetTraceDescriptor(). > > Change-Id: I0daaf3fc51a95f71baf7f6c7bed387e94963601f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139758 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760049} TBR=haraken@chromium.org,mlippautz@chromium.org Bug: chromium:1071874 Change-Id: I7d00fe89223ae32c7a3ad0d5f28f2e056eca6fb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154947Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760135}
-
Ian Wells authored
Also add iwells to the feed watchlist. Bug: 1071906 Change-Id: If274e470d9adda8995815122b2e12cd3348be04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154851Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#760134}
-
Theresa Wellington authored
Explicitly update the info icon visibility when the history backend alerts that whether the user has other forms of browsing data has changed. This fixes a bug where sometimes the info icon wouldn't appear until after a user scrolled for users who had previously chosen to hide history info. BUG=1071468 Change-Id: I293e78b46fd6fbe5fd8200cbac0bfb7dfc937f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153930Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760133}
-
Anastasiia Nikolaienko authored
Update strings on 'info for parents' screen in EDU account addition flow. Bug: 1071144 Change-Id: I4330299f95873c101359028bff9027467c021454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153049Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#760132}
-
Yulun Wu authored
Moving logic out of shelf_layout_manager and into a separate controller class. Tests for this behavior are in shelf_drag_handle_unittest.cc: will be refactored into in_app_to_home_nudge_controller_unittest.cc in a follow up CL. Bug: 1062690 Change-Id: Icb44ddcec0a89be131132723d4db0735a4e50825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152953Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760131}
-
Gang Wu authored
Change-Id: I9966644225507f51d5d22189b5e391491ed03587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153569Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760130}
-
Devlin Cronin authored
These are no longer being monitored. Remove the code and update the histograms.xml file. This removes the following histograms: - ExtensionInstallSigner.InvalidCount - ExtensionInstallSigner.SecondsSinceLastRequest - ExtensionInstallSigner.RequestCount - ExtensionInstallSigner.ResultWasValid - ExtensionInstallSigner.UptimeAtTimeOfRequest - ExtensionInstallSigner.FetchSuccess * - ExtensionInstallSigner.GetResponseSuccess * - ExtensionInstallSigner.ParseJsonSuccess * - ExtensionInstallSigner.ParseFieldsSuccess * *These histograms were never added to histograms.xml. Bug: 878095 Change-Id: Ib272b4587c86f2f7693b387bcf6326c56766561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150005 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#760129}
-
David Bokan authored
Prior to https://crrev.com/2d6fe2bcbcb3f2, when a scroll animation was created on the inner viewport, we would latch to the inner viewport scroll node by setting it as the currently scrolling node. This wasn't intentional as the inner viewport should never be latched; the outer viewport represents all viewport scrolling so that scrolling code knows to use the cc::Viewport class to correctly distribute between inner and outer scroll nodes. This was part of the overloaded nature of CurrentlyScrollingNode that the above CL and several follow-ups addressed. The above CL missed an important case: when a scroll updates an in-progress inner viewport animation, it must use the animating ScrollNode, the inner viewport scroll node. After the CL, an animating inner viewport sets the CurrentlyScrollingNode to the outer viewport and incorrectly uses that to update an in-progress curve. In LayerTreeHostImpl::ScrollLatchedScroller, in the case of an existing scroll animation, we call ScrollAnimationUpdateTarget on the CurrentlyScrollingNode. This mostly doesn't cause an issue as the animation knows which ScrollNode it's mutating. However, the passed in ScrollNode is used to clamp the updated target offset which can lead to incorrect scroll offsets. In the linked bug, since outer viewport has no horizontal overflow, the maximum scroll offset is 0 in the x-axis. Thus, when the inner viewport animation is updated, any x component will be zeroed out due to clamping, causing horizontal scrolling even if the update was only vertical. This CL fixes the issue by exposing and using the scroll node that the animation is bound to when updating an animation curve. Bug: 1070561 Change-Id: I7bf1993e1ffc4e06447dcb16e57f193c47fb2391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151005 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#760128}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea66320c09bd..080904627d71 git log ea66320c09bd..080904627d71 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 digit@google.com CMakeLists: Fix Fuchsia build. 2020-04-17 bclayton@google.com Merge changes Ia8226c11,If413b9d6 2020-04-17 bclayton@google.com LLVMReactor: Drop codegenMutex, now thread safe. 2020-04-17 bclayton@google.com LLVMJIT: Remove the TargetMachine cache. 2020-04-17 bclayton@google.com LLVM 7: Set LLVM_ENABLE_THREADS to 1 Created with: gclient setdep -r src/third_party/swiftshader@080904627d71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8992da0069be04f150dca569eae4426f67dafcd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/633ae40e7435..aac66787f172 Created with: gclient setdep -r src-internal@aac66787f172 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070593 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I8f4e4da83ca51322a90f6d97c72a251295c35a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154806Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760126}
-
Anastasiia Nikolaienko authored
Bug: 1071608 Change-Id: Ic756c2d5b2a7536db82eddfc74c3f2a7b393787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153154Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a19abd58cb38..af564a5d0b8b git log a19abd58cb38..af564a5d0b8b --date=short --first-parent --format='%ad %ae %s' 2020-04-17 senorblanco@chromium.org Dawn: implement fences, callbacks and Finish (syncGpu) semantics. 2020-04-17 mtklein@google.com test overdraw filter via public api 2020-04-17 bsalomon@google.com Fix two GrProcessor names that are not valid idenitfiers 2020-04-17 robertphillips@google.com Update DDL test harness to use backendTextures to back tiles (take 2) Created with: gclient setdep -r src/third_party/skia@af564a5d0b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: kjlubick@google.com Change-Id: I46f2e1875f89078afbd22a9f7611dc6f2c5a483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154887Reviewed-by:
-
Allen Bauer authored
Change-Id: I778aded413a596176c3a2b164856db6b873caf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149952 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#760123}
-
Rohit Rao authored
Breakpad supports product data values up to 2550 bytes long, so there is no need for breadcrumbs to implement additional splitting internally. This CL removes the code that splits breadcrumbs data across keys, simplifies APIs around setting breadcrumbs, and removes any associated unittests. BUG=1068802 Change-Id: Ia33320bcbe69c799d62a2ef36cf0e4d11d9f4566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146932 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#760122}
-
Mohamed Amir Yosef authored
This method decided whether the pending credentials in the password form manager can be moved to the account of the currently signed in user. Bug: 1032992 Change-Id: I088a24cb99111014c5f87468ac9fc566c6014c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139658 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760121}
-
Bruce Dawson authored
compute_build_timestamp.py was updated to not do 5 am quantizing on official builds but the behavioral comment at the top was not updated. This change just updates the comment to reflect reality. Also fix a spelling error found by tricium. Bug: 993509 Change-Id: I05e3c03d5846f32a47b7742e01739afd5d4f0564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154532Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#760120}
-
Xida Chen authored
We are seeing OOM crash in FrameSequenceTracker::ReportSubmitFrame and it is pointing at ignored_frame_tokens_ set being too big. The only way this can happen is that a tracker is scheduled for termination, but the last frame took very long time to get its presentation feedback. During this period, there are a lot of frames getting submitted, and these frame tokens will be pushed into ignored_frame_tokens_ set and causing a OOM crash. This CL fixes the problem and added a unit test. Bug: 1070209 Change-Id: I0a9c132d8f9d45a5a89f1ff763b20d9ba12ea524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148164 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760119}
-
Henrique Nakashima authored
Usages have been migrated to chrome/browser/flags:java. Bug: 1041473 Change-Id: I3be7d6e91f887b36650dfe9771f2857fd763f912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151429Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#760118}
-
Toni Barzic authored
Follow-up on CL:2106509 which changed empty container score from -1 to 0. (that CL originally had this change, but it got lost somewhere when I was moving it to a branch for upload). Change-Id: I31d7697770c0a400e504bff0e051b337661d1221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153943Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#760117}
-
Xianzhu Wang authored
This may avoid copying of the struct (56 bytes on LP64) when the compiler can't optimize it away. Change-Id: I94bc3266d4694602ff87c1e02a212e1341c970b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153951 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/de5575dc8a09..ca96cb78e35e git log de5575dc8a09..ca96cb78e35e --date=short --first-parent --format='%ad %ae %s' 2020-04-17 cjmcdonald@chromium.org README: Update testing documentation 2020-04-17 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-17 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-17 allenwebb@google.com remote_access: Add RemoteAccess.CreateTunnel for SSH tunnels. 2020-04-16 camurcu@google.com arc-rvc: Publish cachebuilder.jar on cros bucket 2020-04-16 vapier@chromium.org cbuildbot: manifest_version: fix str-vs-bytes confusion 2020-04-16 cjmcdonald@chromium.org cros_portage_upgrade_unittest: Remove OutputTestCase usage 2020-04-16 cjmcdonald@chromium.org pytest: Remove 'requires_portage' marker 2020-04-16 cjmcdonald@chromium.org pytest: Remove 'redirected_stdin_error' marker 2020-04-16 cjmcdonald@chromium.org pytest: Remove 'mock_error' marker 2020-04-16 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@ca96cb78e35e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I18a12615e1635778e6c8714aa900fa89eee2f6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154808Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e68c05a72371..ec7bd4a323c6 git log e68c05a72371..ec7bd4a323c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 khokhlov@google.com [Telemetry] Add experimental Perfetto tracing agent Created with: gclient setdep -r src/third_party/catapult@ec7bd4a323c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:839068 Tbr: wenbinzhang@google.com Change-Id: I68f32ee5abf957dcb42cd1d10c3f554f79c8820f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154562Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/35ebb85fa793..39aac148144c git log 35ebb85fa793..39aac148144c --date=short --first-parent --format='%ad %ae %s' 2020-04-17 sigurds@chromium.org [issues] Enable issues panel by default Created with: gclient setdep -r src/third_party/devtools-frontend/src@39aac148144c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068116 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ef251ed59fe2f3b2b54d2a1dc52ff6e4ebada95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153017Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ca93436e5b1b..ac65d4531798 $ git log ca93436e5..ac65d4531 --date=short --no-merges --format='%ad %ae %s' 2020-04-09 junyer Remove deprecated APIs. Bump SONAME accordingly. 2020-04-06 junyer Go back to using __builtin_ctzll(). Sigh. 2020-04-05 junyer Return the fanout histogram in a vector, not a map. 2020-04-05 junyer Optimise fanout bucketing. 2020-04-05 junyer Add Clang 10 to the Travis CI matrix. 2020-03-27 junyer Aiieee. Add a missing underscore. 2020-03-27 junyer Include the pattern length in "DFA out of memory" errors. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I60964941fd6cb319f2c497d579cf8609bfbb7e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154810 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760112}
-
Oleh Lamzin authored
Add note in comment that if primary_enabled_usb_ethernet_device_path_ is empty, then IsUsbEnabledDevice(nullptr) returns false. BUG=none TEST=none Change-Id: Icf8737b2ffe8f18ee9ada7cb8055783514d88b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152806Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#760111}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie99cbbf38868e9b404a44a57368fd7f8dab3d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154597Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#760110}
-
Oksana Zhuravlova authored
This change adds a remote call to RemoteObjectHost's ReleaseObject method when the corresponding RemoteObject renderer instance is destroyed. Also removes the entry from RemoteObjectGatewayImpl's map. Bug: 794320 Change-Id: Ib9769ffac5a0cdc8c654164211c163c2ab889c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090922Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#760109}
-
Wan-Teh Chang authored
Change '+' to '_' in that comment. It should read required_previous_frame_index_. Change-Id: I98e3a180be2d4fc3eaba6b01f9f80ec363da088b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153696Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#760108}
-
Elly Fong-Jones authored
Currently, flags expire at every milestone, but this expiration process relies on manual updates at the branch point to several different files. This change automates that entire process. Specifically: * The existing hand-added "UnexpireFlagsM$M" features are replaced with automatically synthesized ones * The existing hand-added "temporary-unexpire-flags-m$M" flags are replaced with automatically synthesized ones * The hand-updated ExpiryEnabledForMstone function is replaced with an automatically synthesized one This is done by: 1) Generating a file //chrome/browser/expired_flags_gen.h, which declares the UnexpireFlagsM$M features and the ExpiryEnabledForMstone function 2) Generating a file //chrome/browser/expired_flags_gen.cc, which defines those features and that function 3) Generating a file //chrome/browser/expired_flags_gen.inc, which is a source fragment defining the temporary-unexpire-flags-m$M flags and binding them to the UnexpireFlagsM$M features 4) Checking those features when deciding whether flag expiry is enabled for flags expiring in a given milestone Points (1) through (3) are done by a new Python script, //tools/flags/generate_unexpire_flags.py, which is invoked during build. Point (4) is done via changes to the existing flags::IsFlagExpired() function. This change also: * Adds test coverage for the proper presence of unexpiration flags corresponding to the current and previous milestone * Adds a bit to the flag "platform" bitmask, kFlagInfrastructure, which causes the generated flags to be exempt from checks for flag metadata or histogram entries * Adds some uses of base::span internal to the flags test APIs * Updates one other flags test API to use base::span instead of passing a (pointer, length) pair After this change, no manual engineering work is needed to expire flags at a new milestone; the change to //chrome/VERSION drives the entire process. Bug: 1068258 Change-Id: Id205f42f043a806ab5be7aa60f203e2bd110f545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142327 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760107}
-
Ted Choc authored
BUG=1037491 Change-Id: Idb59c5fbdc104d2ec6caf552bc0cdcc859339b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153329 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Ted Choc authored
Sigh...lambda formatting makes me so, so very sad. BUG=1071247 Change-Id: Ia9b46ba20d10146a385c9acebc7391acfa23dadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153962Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760105}
-
Sharon Yang authored
Implement media load blocking in WebEngine, using logic in components/media_control. WebEngineIntegrationTest Test: Add BlockMediaPlaybackUnblocked and BlockMediaPlaybackBlocked to Bug: 1057860 Change-Id: I055d170fc942b2f88598e95605a9886fea413026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131210Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#760104}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/da6cda839dac..b613e3ab6b71 git log da6cda839dac..b613e3ab6b71 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 hbos@webrtc.org [Adaptation] Resource::IsAdaptationUpAllowed() for IsBitrateConstrained. 2020-04-17 hbos@webrtc.org [Adaptation] Introduce VideoStreamInputState and its Provider. Created with: gclient setdep -r src/third_party/webrtc@b613e3ab6b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd194b312aadcb78fe84479d94e89b4df2d12c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154564Reviewed-by:
-
Scott Violet authored
At the time OnNavigationStarted() is called it's not safe to call Navigate(). This patch delays the navigate until it is safe (when NavigationThrottleImpl::WillStartRequest() is called). This is a reland because of a use-after-free. In particular, when NavigationThrottle calls out to DoNavigate, navigationThrottle may be deleted. The code was not set up to handle that. BUG=1070569 TEST=NavigationBrowserTest.NavigateFromRendererInitiatedNavigation Change-Id: I769ef0e0143d333e2fddbd997be2dc9de7aba3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154592Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#760102}
-
Anders Hartvoll Ruud authored
This defect actually has no effect in practice, since applying animations is the very last thing that happens while the StyleCascade instance exists in the StyleResolver, but of course that's just luck. Change-Id: I0de314b84889e2a314e1341192cd2f193df4e3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151514Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760101}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8aebb60a8d9d..888c0fe76833 git log 8aebb60a8d9d..888c0fe76833 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 engeg@google.com ReadHttpResponse: Handle 429s with retries and adjust retry count Created with: gclient setdep -r src/third_party/depot_tools@888c0fe76833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071590 Tbr: agable@chromium.org Change-Id: Ia024c1e891c9bcf8d06ad45d18cec2da4da2191f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154807Reviewed-by:
-
Akihiro Ota authored
Before this fix, assistive technologies (I tested with ChromeVox) were unable to navigate into the IME candidates. For ChromeVox in particular, using the arrow keys to navigate the candidates produced no speech output. With this fix, ChromeVox can navigate into the IME candidates and speaks each candidate to the user. Bug: 1034146 Change-Id: I77b584fc2a2648bc5f9fca479b2363d476628ac4 Relnotes: Make Chrome IME accessible to assistive technology. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151672Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#760099}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 to 84-4099.3-1586167754-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If54f8ba805f9403b2fe1777cd9321dc9a5e35488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154888Reviewed-by:
-
Abigail Klein authored
When the caption controller feature is initialized, it should create the UI of the live caption feature. Before this feature, the UI was only created when the kLiveCaptionEnabled pref changed. Note that SODA should only be registered when the pref changes. Bug: 1055150 Change-Id: I5d78520854b1a5ad0d5388724aea236f527a7804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151893 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#760097}
-
